[iOS] Implement camera in custom file upload panel [chromium/src : main]
Quentin Pubert (Gerrit)
Quentin Pubert voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Olivier Robin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Robin (Gerrit)
Olivier Robin added 10 comments![]( "Open in Gerrit")
[self showCamera];are we bypassing the context menu here and below?
I understand that this is what webkit does, but one of the point of the refactor is to add drive in those scenarios
_isPresentingSubMenu = YES;I find the name weird as none of these are sub menus
- (void)adjustCaptureTypeToAvailableDevices;why do we need a method for this? Could this not be automatically computed by preferredCameraDevice ?
mediaInfo[UIImagePickerControllerMediaURL]];when is this deleted?
CHECK_EQ(nil, mediaInfo[UIImagePickerControllerImageURL])is this guaranteed by documentation?
[self submitFileSelection:@[ mediaURL ]];what happens if you have the multiple attribute?
UIImage* image = UIGraphicsGetImageFromCurrentImageContext();ImageWithColor()
EXPECT_TRUE(controller_->HasSubmittedSelection());check "IOS.FileUploadPanel.SubmittedFileCount" histogram?
R"(<html><body><input type="file" id="fileInput" accept="image/*" /></body></html>)";can we format these?
XCUIApplication* app = [[XCUIApplication alloc] init];Why can't you use EG if it is in the same process?
Related details
- Quentin Pubert
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quentin Pubert (Gerrit)
Quentin Pubert voted and added 10 comments![]( "Open in Gerrit")
Votes added by Quentin Pubert
| Auto-Submit | +1 |
| Commit-Queue | +1 |
10 comments
are we bypassing the context menu here and below?
I understand that this is what webkit does, but one of the point of the refactor is to add drive in those scenarios
For now the goal is to reach parity with the native file upload menu. Once this is done then the Drive file picker can be integrated. However we can already expect that it it will be skipped if there is a capture attribute. If the input is meant to select a directory then we may need to adapt the Drive file picker accordingly, or at least move its output to a folder which could then be submitted. We can expect that all cases where the local file picker can be presented can eventually be eligible to also present the Drive file picker.
I find the name weird as none of these are sub menus
I will remove this variable and instead just check if one of the views is presented.
why do we need a method for this? Could this not be automatically computed by preferredCameraDevice ?
This "stateful" behavior is meant to mimic the behavior of the native file upload menu.
mediaInfo[UIImagePickerControllerMediaURL]];Quentin Pubertwhen is this deleted?
Based on what I could find online it's not well defined and appears to have changed at some point around iOS 13. It appears best to make a copy of the file before the delegate call returns on the main thread, which is what happens here when we submit the selection to the controller.
CHECK_EQ(nil, mediaInfo[UIImagePickerControllerImageURL])is this guaranteed by documentation?
According to the document, info is "A dictionary containing the original image and the edited image, if an image was picked; or a filesystem URL for the movie, if a movie was picked." The native file upload menu also makes this verification although it probably does not crash in Release mode if unverified.
what happens if you have the multiple attribute?
This is irrelevant if the camera is used, as per the native behavior.
UIImage* image = UIGraphicsGetImageFromCurrentImageContext();Quentin PubertImageWithColor()
Done
EXPECT_TRUE(controller_->HasSubmittedSelection());Quentin Pubertcheck "IOS.FileUploadPanel.SubmittedFileCount" histogram?
Done
R"(<html><body><input type="file" id="fileInput" accept="image/*" /></body></html>)";Quentin Pubertcan we format these?
Done
XCUIApplication* app = [[XCUIApplication alloc] init];Why can't you use EG if it is in the same process?
- Olivier Robin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Robin (Gerrit)
Olivier Robin voted![]( "Open in Gerrit")
- Quentin Pubert
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[iOS] Implement camera in custom file upload panel
This CL implements the camera action in the custom file upload panel. If
a photo is taken, the JPEG representation of the photo is saved to a
temporary location of the disk and this temporary location is forwarded
to the web page. If there is a capture attribute, the file upload panel
context menu can now be skipped and the camera will be presented
directly.
- M ios/chrome/app/strings/ios_strings.grd
- A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_FILE_UPLOAD_PANEL_TAKE_PHOTO_ACTION_LABEL.png.sha1
- A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_FILE_UPLOAD_PANEL_TAKE_VIDEO_ACTION_LABEL.png.sha1
- M ios/chrome/browser/file_upload_panel/DEPS
- M ios/chrome/browser/file_upload_panel/coordinator/BUILD.gn
- M ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_coordinator.mm
- M ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_mediator.h
- M ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_mediator.mm
- M ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_mediator_unittest.mm
- M ios/chrome/browser/file_upload_panel/test/file_upload_panel_egtest.mm
- M ios/chrome/browser/file_upload_panel/ui/constants.h
- M tools/metrics/histograms/metadata/ios/enums.xml
- M tools/metrics/histograms/metadata/ios/histograms.xml
Code-Review: +1 by Olivier Robin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |