Wire up JXL decoder. [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Dec 25, 2025, 5:19:26 PM12/25/25
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 55:
ccameron chromium . resolved

I would also highly recommend breaking this into a couple CLs.

Like -- you can land a CL that just adds the flags and various enum values for JXL, while not actually adding the codec right now, cause that stuff is mostly mechanical.

Then a second CL could add the codec decoder itself (which would need more scrutiny). And also, if there is any build breakage, the revert would be less painful.

Helmut Januschka

thanks, did it now, feel free to tell me if the split you had in mind was different!

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Hans Wennborg
  • Luca Versari
  • Philip Jägenstedt
  • ccameron chromium
  • mmenke
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
Gerrit-Change-Number: 7184969
Gerrit-PatchSet: 67
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Luca Versari <vel...@google.com>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: mmenke <mme...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
Gerrit-Attention: mmenke <mme...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Luca Versari <vel...@google.com>
Gerrit-Comment-Date: Thu, 25 Dec 2025 22:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ccameron chromium <ccam...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Dec 26, 2025, 5:01:28 PM12/26/25
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 67 (Latest):
Helmut Januschka . resolved

ready for re-review 😊

Gerrit-Comment-Date: Fri, 26 Dec 2025 22:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Honey B (Gerrit)

unread,
Jan 4, 2026, 1:55:41 AM (8 days ago) Jan 4
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

Honey B added 1 comment

File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Hans Wennborg
  • Helmut Januschka
  • Luca Versari
  • Philip Jägenstedt
  • ccameron chromium
  • mmenke
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
      Gerrit-Change-Number: 7184969
      Gerrit-PatchSet: 70
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Luca Versari <vel...@google.com>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
      Gerrit-Reviewer: mmenke <mme...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dale Curtis <dalec...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Honey B <kyoko...@gmail.com>
      Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
      Gerrit-Attention: mmenke <mme...@chromium.org>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
      Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Attention: Luca Versari <vel...@google.com>
      Gerrit-Comment-Date: Sun, 04 Jan 2026 06:55:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      mmenke (Gerrit)

      unread,
      Jan 5, 2026, 11:03:21 AM (6 days ago) Jan 5
      to Helmut Januschka, Honey B, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
      Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and ccameron chromium

      mmenke added 1 comment

      File third_party/blink/common/loader/network_utils.cc
      Line 37, Patchset 70 (Latest):#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)
      return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
      "*;q=0.8";
      #elif BUILDFLAG(ENABLE_JXL_DECODER)
      return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";
      mmenke . unresolved

      What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dave Tapuska
      • Hans Wennborg
      • Helmut Januschka
      • Luca Versari
      • Philip Jägenstedt
      • ccameron chromium
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
      Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Attention: Luca Versari <vel...@google.com>
      Gerrit-Comment-Date: Mon, 05 Jan 2026 16:03:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dave Tapuska (Gerrit)

      unread,
      Jan 5, 2026, 1:46:20 PM (6 days ago) Jan 5
      to Helmut Januschka, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
      Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and ccameron chromium

      Dave Tapuska voted and added 1 comment

      Votes added by Dave Tapuska

      Code-Review+1

      1 comment

      File cc/base/devtools_instrumentation.cc
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hans Wennborg
      • Helmut Januschka
      • Luca Versari
      • Philip Jägenstedt
      • ccameron chromium
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Gerrit-Attention: Luca Versari <vel...@google.com>
        Gerrit-Comment-Date: Mon, 05 Jan 2026 18:46:10 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Helmut Januschka (Gerrit)

        unread,
        Jan 9, 2026, 2:20:13 AM (3 days ago) Jan 9
        to Helmut Januschka, Dave Tapuska, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
        Attention needed from Dave Tapuska, Hans Wennborg, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

        Helmut Januschka added 4 comments

        Patchset-level comments
        File-level comment, Patchset 78 (Latest):
        Helmut Januschka . resolved

        bots are all green now, please let me know if you want me to address anything!

        File cc/base/devtools_instrumentation.cc
        Line 109, Patchset 70: histogram_name = "Renderer4.ImageDecodeTaskDurationUs.Jxl";
        Dave Tapuska . resolved
        Helmut Januschka

        Done

        File third_party/blink/common/loader/network_utils.cc
        Line 37, Patchset 70:#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)

        return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
        "*;q=0.8";
        #elif BUILDFLAG(ENABLE_JXL_DECODER)
        return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";
        mmenke . resolved

        What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.

        Helmut Januschka

        Done. Added runtime checks for `features::kJXLImageFormat` in both `ImageAcceptHeader()` and `FrameAcceptHeaderValue()`.

        File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
        Line 33, Patchset 70: kMaxValue = kJXL,
        Honey B . resolved
        Helmut Januschka

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Dave Tapuska
        • Hans Wennborg
        • Honey B
        • Luca Versari
        • Philip Jägenstedt
        • ccameron chromium
        • mmenke
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
          Gerrit-Change-Number: 7184969
          Gerrit-PatchSet: 78
          Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
          Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
          Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Luca Versari <vel...@google.com>
          Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
          Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
          Gerrit-Reviewer: mmenke <mme...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Dale Curtis <dalec...@chromium.org>
          Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
          Gerrit-CC: Honey B <kyoko...@gmail.com>
          Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-CC: Stephen Chenney <sche...@chromium.org>
          Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
          Gerrit-Attention: Honey B <kyoko...@gmail.com>
          Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
          Gerrit-Attention: mmenke <mme...@chromium.org>
          Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
          Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
          Gerrit-Attention: Luca Versari <vel...@google.com>
          Gerrit-Comment-Date: Fri, 09 Jan 2026 07:19:53 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Honey B <kyoko...@gmail.com>
          Comment-In-Reply-To: mmenke <mme...@chromium.org>
          Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Moritz Firsching (Gerrit)

          unread,
          Jan 9, 2026, 4:29:02 AM (3 days ago) Jan 9
          to Helmut Januschka, Chrome Metrics Logs, Dave Tapuska, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
          Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

          Moritz Firsching added 1 comment

          Patchset-level comments
          Moritz Firsching . resolved

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Dave Tapuska
          • Hans Wennborg
          • Helmut Januschka
          • Honey B
          • Luca Versari
          • Philip Jägenstedt
          • ccameron chromium
          • mmenke
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
          Gerrit-Change-Number: 7184969
          Gerrit-PatchSet: 78
          Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Chrome Metrics Logs <chrome-metrics...@google.com>
          Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
          Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
          Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Luca Versari <vel...@google.com>
          Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
          Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
          Gerrit-Reviewer: mmenke <mme...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Dale Curtis <dalec...@chromium.org>
          Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
          Gerrit-CC: Honey B <kyoko...@gmail.com>
          Gerrit-CC: Moritz Firsching <firs...@google.com>
          Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-CC: Stephen Chenney <sche...@chromium.org>
          Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
          Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
          Gerrit-Attention: Honey B <kyoko...@gmail.com>
          Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
          Gerrit-Attention: mmenke <mme...@chromium.org>
          Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
          Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
          Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
          Gerrit-Attention: Luca Versari <vel...@google.com>
          Gerrit-Comment-Date: Fri, 09 Jan 2026 09:28:44 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Dave Tapuska (Gerrit)

          unread,
          Jan 9, 2026, 10:37:07 AM (2 days ago) Jan 9
          to Helmut Januschka, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
          Attention needed from Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

          Dave Tapuska voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hans Wennborg
          • Helmut Januschka
          • Honey B
          • Luca Versari
          • Philip Jägenstedt
          • ccameron chromium
          • mmenke
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Gerrit-Attention: Luca Versari <vel...@google.com>
            Gerrit-Comment-Date: Fri, 09 Jan 2026 15:36:59 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            mmenke (Gerrit)

            unread,
            Jan 9, 2026, 11:00:09 AM (2 days ago) Jan 9
            to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
            Attention needed from Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt and ccameron chromium

            mmenke voted and added 1 comment

            Votes added by mmenke

            Code-Review+1

            1 comment

            Patchset-level comments
            mmenke . resolved

            Still LGTM

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Hans Wennborg
            • Helmut Januschka
            • Honey B
            • Luca Versari
            • Philip Jägenstedt
            • ccameron chromium
            Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
            Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
            Gerrit-Attention: Luca Versari <vel...@google.com>
            Gerrit-Comment-Date: Fri, 09 Jan 2026 16:00:00 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Honey B (Gerrit)

            unread,
            12:21 AM (20 hours ago) 12:21 AM
            to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
            Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

            Honey B added 1 comment

            File third_party/blink/renderer/platform/blink_platform_unittests_bundle_data.filelist
            Line 149, Patchset 79 (Latest):../../web_tests/images/resources/5_frames_numbered.jxl
            Honey B . unresolved

            Should keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Dave Tapuska
            • Hans Wennborg
            • Helmut Januschka
            • Luca Versari
            • Philip Jägenstedt
            • ccameron chromium
            • mmenke
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
              Gerrit-Change-Number: 7184969
              Gerrit-PatchSet: 79
              Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Chrome Metrics Logs <chrome-metrics...@google.com>
              Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
              Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
              Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Luca Versari <vel...@google.com>
              Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
              Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
              Gerrit-Reviewer: mmenke <mme...@chromium.org>
              Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
              Gerrit-CC: Dale Curtis <dalec...@chromium.org>
              Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
              Gerrit-CC: Honey B <kyoko...@gmail.com>
              Gerrit-CC: Moritz Firsching <firs...@google.com>
              Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
              Gerrit-CC: Stephen Chenney <sche...@chromium.org>
              Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
              Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
              Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
              Gerrit-Attention: mmenke <mme...@chromium.org>
              Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
              Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
              Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
              Gerrit-Attention: Luca Versari <vel...@google.com>
              Gerrit-Comment-Date: Sun, 11 Jan 2026 05:20:22 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Helmut Januschka (Gerrit)

              unread,
              6:10 AM (14 hours ago) 6:10 AM
              to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
              Attention needed from Dave Tapuska, Hans Wennborg, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

              Helmut Januschka added 1 comment

              File third_party/blink/renderer/platform/blink_platform_unittests_bundle_data.filelist
              Line 149, Patchset 79:../../web_tests/images/resources/5_frames_numbered.jxl
              Honey B . resolved

              Should keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.

              Helmut Januschka

              Done

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Dave Tapuska
              • Hans Wennborg
              • Honey B
              • Luca Versari
              • Philip Jägenstedt
              • ccameron chromium
              • mmenke
                Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement is not satisfiedCode-Owners
                  • requirement is not satisfiedCode-Review
                  • requirement is not satisfiedReview-Enforcement
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
                  Gerrit-Change-Number: 7184969
                  Gerrit-PatchSet: 80
                  Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
                  Gerrit-Reviewer: Chrome Metrics Logs <chrome-metrics...@google.com>
                  Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
                  Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
                  Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
                  Gerrit-Reviewer: Luca Versari <vel...@google.com>
                  Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
                  Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
                  Gerrit-Reviewer: mmenke <mme...@chromium.org>
                  Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
                  Gerrit-CC: Dale Curtis <dalec...@chromium.org>
                  Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
                  Gerrit-CC: Honey B <kyoko...@gmail.com>
                  Gerrit-CC: Moritz Firsching <firs...@google.com>
                  Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
                  Gerrit-CC: Stephen Chenney <sche...@chromium.org>
                  Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
                  Gerrit-Attention: Honey B <kyoko...@gmail.com>
                  Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
                  Gerrit-Attention: mmenke <mme...@chromium.org>
                  Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
                  Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
                  Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
                  Gerrit-Attention: Luca Versari <vel...@google.com>
                  Gerrit-Comment-Date: Sun, 11 Jan 2026 11:10:13 +0000
                  Gerrit-HasComments: Yes
                  Gerrit-Has-Labels: No
                  Comment-In-Reply-To: Honey B <kyoko...@gmail.com>
                  satisfied_requirement
                  unsatisfied_requirement
                  open
                  diffy
                  Reply all
                  Reply to author
                  Forward
                  0 new messages