Helmut JanuschkaI would also highly recommend breaking this into a couple CLs.
Like -- you can land a CL that just adds the flags and various enum values for JXL, while not actually adding the codec right now, cause that stuff is mostly mechanical.
Then a second CL could add the codec decoder itself (which would need more scrutiny). And also, if there is any build breakage, the revert would be less painful.
thanks, did it now, feel free to tell me if the split you had in mind was different!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)
return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
"*;q=0.8";
#elif BUILDFLAG(ENABLE_JXL_DECODER)
return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.
| Code-Review | +1 |
histogram_name = "Renderer4.ImageDecodeTaskDurationUs.Jxl";bots are all green now, please let me know if you want me to address anything!
histogram_name = "Renderer4.ImageDecodeTaskDurationUs.Jxl";Done
#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)
return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
"*;q=0.8";
#elif BUILDFLAG(ENABLE_JXL_DECODER)
return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.
Done. Added runtime checks for `features::kJXLImageFormat` in both `ImageAcceptHeader()` and `FrameAcceptHeaderValue()`.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
Still LGTM
../../web_tests/images/resources/5_frames_numbered.jxlShould keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Should keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |