Wire up JXL decoder. [chromium/src : main]
0 views
Skip to first unread message
Helmut Januschka (Gerrit)
Dec 25, 2025, 5:19:26 PM12/25/25
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 55:
ccameron chromium . resolved
Helmut JanuschkaI would also highly recommend breaking this into a couple CLs.
Like -- you can land a CL that just adds the flags and various enum values for JXL, while not actually adding the codec right now, cause that stuff is mostly mechanical.
Then a second CL could add the codec decoder itself (which would need more scrutiny). And also, if there is any build breakage, the revert would be less painful.
thanks, did it now, feel free to tell me if the split you had in mind was different!
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Dec 26, 2025, 5:01:28 PM12/26/25
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Honey B (Gerrit)
Jan 4, 2026, 1:55:41 AMJan 4
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Honey B added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jan 5, 2026, 11:03:21 AMJan 5
to Helmut Januschka, Honey B, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and ccameron chromium
mmenke added 1 comment![]( "Open in Gerrit")
File third_party/blink/common/loader/network_utils.cc
Line 37, Patchset 70 (Latest):
#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)
return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
"*;q=0.8";
#elif BUILDFLAG(ENABLE_JXL_DECODER)
return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";mmenke . unresolved
What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
Dave Tapuska (Gerrit)
Jan 5, 2026, 1:46:20 PMJan 5
to Helmut Januschka, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and ccameron chromium
Dave Tapuska voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Code-Review | +1 |
1 comment
File cc/base/devtools_instrumentation.cc
Line 109, Patchset 70 (Latest):
histogram_name = "Renderer4.ImageDecodeTaskDurationUs.Jxl";Dave Tapuska . unresolved
Related details
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
Helmut Januschka (Gerrit)
Jan 9, 2026, 2:20:13 AMJan 9
to Helmut Januschka, Dave Tapuska, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Helmut Januschka added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 78 (Latest):
Helmut Januschka . resolved
bots are all green now, please let me know if you want me to address anything!
File cc/base/devtools_instrumentation.cc
Line 109, Patchset 70:
histogram_name = "Renderer4.ImageDecodeTaskDurationUs.Jxl";Dave Tapuska . resolved
Helmut Januschka
Done
File third_party/blink/common/loader/network_utils.cc
Line 37, Patchset 70:
#if BUILDFLAG(ENABLE_JXL_DECODER) && BUILDFLAG(ENABLE_AV1_DECODER)
return "image/jxl,image/avif,image/webp,image/apng,image/svg+xml,image/*,*/"
"*;q=0.8";
#elif BUILDFLAG(ENABLE_JXL_DECODER)
return "image/jxl,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8";mmenke . resolved
What if the feature is disabled? We should probably not include jxl, no? That does mean we need runtime checks here in addition to the build-time checks, unfortunately, but think they're needed. We probably also need unit test - admittedly, not very exciting ones. Fine to just hard code these strings there as well.
Helmut Januschka
Done. Added runtime checks for `features::kJXLImageFormat` in both `ImageAcceptHeader()` and `FrameAcceptHeaderValue()`.
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Honey B
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moritz Firsching (Gerrit)
Jan 9, 2026, 4:29:02 AMJan 9
to Helmut Januschka, Chrome Metrics Logs, Dave Tapuska, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Moritz Firsching added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Honey B
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jan 9, 2026, 10:37:07 AMJan 9
to Helmut Januschka, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Honey B
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
mmenke (Gerrit)
Jan 9, 2026, 11:00:09 AMJan 9
to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Honey B, Luca Versari, Philip Jägenstedt and ccameron chromium
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
1 comment
Patchset-level comments
mmenke . resolved
Still LGTM
Related details
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Honey B
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
Honey B (Gerrit)
Jan 11, 2026, 12:21:00 AMJan 11
to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Honey B added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/blink_platform_unittests_bundle_data.filelist
Line 149, Patchset 79 (Latest):
../../web_tests/images/resources/5_frames_numbered.jxlHoney B . unresolved
Should keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jan 11, 2026, 6:10:34 AMJan 11
to Helmut Januschka, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Honey B, ccameron chromium, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Honey B, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/blink_platform_unittests_bundle_data.filelist
Should keep the list sorted. You can use `build/ios/update_bundle_filelist.py` to update this file.
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Honey B
- Luca Versari
- Philip Jägenstedt
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jan 12, 2026, 6:08:16 AMJan 12
to Helmut Januschka, ccameron chromium, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Honey B, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and mmenke
ccameron chromium voted and added 1 comment![]( "Open in Gerrit")
Votes added by ccameron chromium
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Honey B (Gerrit)
Jan 12, 2026, 10:32:47 AMJan 12
to Helmut Januschka, ccameron chromium, Dave Tapuska, Moritz Firsching, Chrome Metrics Logs, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and mmenke
Honey B added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Honey B . resolved
Isn't `chrome-metrics-team+submitter@` just a bot? Maybe you should add `chromium-metrics-reviews@` instead to review the histogram part.
There is a bug that bots are showing up in "Suggest Owners": crbug.com/344912772
gwsq (Gerrit)
Jan 12, 2026, 10:48:44 AMJan 12
to Helmut Januschka, Chromium Metrics Reviews, Mark Pearson, ccameron chromium, Dave Tapuska, Moritz Firsching, Honey B, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Mark Pearson, Philip Jägenstedt and mmenke
Message from gwsq![]( "Open in Gerrit")
From analysis/uma/chrome-metrics.gwsq:
Histograms should by default be reviewed by the owners of the subdirectories. The chromium-met...@google.com gwsq should be used when there are no individual owners, or for escalation to the Metrics team.
If you are interested in becoming a metrics reviewer, please review the instructions at https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Becoming-a-Metrics-Reviewer
Reviewer source(s):
mpea...@chromium.org is from context(analysis/uma/chrome-metrics.gwsq)
Related details
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Luca Versari
- Mark Pearson
- Philip Jägenstedt
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jan 12, 2026, 10:48:53 AMJan 12
to Helmut Januschka, Chromium Metrics Reviews, Mark Pearson, ccameron chromium, Moritz Firsching, Honey B, Vladimir Levin, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Mark Pearson, Philip Jägenstedt and mmenke
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
Vladimir Levin (Gerrit)
Jan 12, 2026, 10:50:20 AMJan 12
to Helmut Januschka, Dave Tapuska, Chromium Metrics Reviews, Mark Pearson, ccameron chromium, Moritz Firsching, Honey B, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Mark Pearson, Philip Jägenstedt and mmenke
Vladimir Levin voted Code-Review+1![]( "Open in Gerrit")
Mark Pearson (Gerrit)
Jan 12, 2026, 12:58:50 PMJan 12
to Helmut Januschka, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Philip Jägenstedt and mmenke
Mark Pearson added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Mark Pearson . resolved
[metrics reviewer]
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
Line 32, Patchset 85 (Latest):
kJXL = 8,Mark Pearson . unresolved
Please don't reuse the existing (deprecated) enum value. We have some users running older versions of Chrome that are still reporting the existing value. Please add a new value (9) for the non-removed implementation of JXL.
Related details
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
Helmut Januschka (Gerrit)
Jan 12, 2026, 3:36:35 PMJan 12
to Helmut Januschka, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, Mark Pearson, ccameron chromium, Moritz Firsching, Honey B, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Luca Versari, Mark Pearson, Philip Jägenstedt and mmenke
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
Please don't reuse the existing (deprecated) enum value. We have some users running older versions of Chrome that are still reporting the existing value. Please add a new value (9) for the non-removed implementation of JXL.
Attention is currently required from:
- Hans Wennborg
- Luca Versari
- Mark Pearson
- Philip Jägenstedt
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jan 12, 2026, 4:31:34 PMJan 12
to Helmut Januschka, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, Mark Pearson, ccameron chromium, Moritz Firsching, Honey B, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari, Mark Pearson and Philip Jägenstedt
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Mark Pearson
- Philip Jägenstedt
Mark Pearson (Gerrit)
Jan 12, 2026, 5:12:14 PMJan 12
to Helmut Januschka, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Hans Wennborg, Helmut Januschka, Luca Versari and Philip Jägenstedt
Mark Pearson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Pearson
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Hans Wennborg
- Helmut Januschka
- Luca Versari
- Philip Jägenstedt
Submit Requirements:
Code-Coverage
Code-Owners
Luca Versari (Gerrit)
Jan 12, 2026, 5:55:05 PMJan 12
to Helmut Januschka, Mark Pearson, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Mark Pearson, Philip Jägenstedt, Vladimir Levin, ccameron chromium and mmenke
Luca Versari voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
- Mark Pearson
- Philip Jägenstedt
- Vladimir Levin
- ccameron chromium
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wan-Teh Chang (Gerrit)
Jan 12, 2026, 5:55:24 PMJan 12
to Helmut Januschka, Wan-Teh Chang, Luca Versari, Mark Pearson, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Mark Pearson, Philip Jägenstedt, Vladimir Levin, ccameron chromium and mmenke
Wan-Teh Chang voted Code-Review+1![]( "Open in Gerrit")
Helmut Januschka (Gerrit)
Jan 12, 2026, 5:57:37 PMJan 12
to Helmut Januschka, Wan-Teh Chang, Luca Versari, Mark Pearson, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Mark Pearson, Philip Jägenstedt, Vladimir Levin, ccameron chromium and mmenke
Helmut Januschka voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
Mark Pearson (Gerrit)
Jan 12, 2026, 7:18:19 PMJan 12
to Helmut Januschka, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Helmut Januschka, Philip Jägenstedt, Vladimir Levin, ccameron chromium and mmenke
Mark Pearson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Pearson
| Code-Review | +1 |
Attention is currently required from:
- Dave Tapuska
- Hans Wennborg
- Helmut Januschka
Chromium LUCI CQ (Gerrit)
Jan 12, 2026, 7:34:26 PMJan 12
to Helmut Januschka, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Wire up JXL decoder.
Integrates JXLImageDecoder and enables the feature:
- MIME type registration (image/jxl) in net/ and blink/
- Accept header updates for image requests
- cc::ImageType::kJXL enum value
- chrome://flags UI for enable-jxl-image-format
- Signature sniffing for JXL magic bytes
- Metrics reporting
Gated behind enable_jxl_decoder build flag (enabled by default).
Bug: 462919304
Binary-Size: Size increase is from jxl-rs Rust library for JPEG XL image decoding.
Fuchsia-Binary-Size: Size increase is from jxl-rs Rust library for JPEG XL image decoding.
Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
Reviewed-by: Wan-Teh Chang <w...@google.com>
Reviewed-by: Luca Versari <vel...@google.com>
Commit-Queue: Helmut Januschka <hel...@januschka.com>
Reviewed-by: Mark Pearson <mpea...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568143}
Files:
- M cc/base/devtools_instrumentation.cc
- M cc/base/devtools_instrumentation.h
- M cc/paint/paint_image.h
- M cc/tiles/image_decode_cache.h
- M chrome/browser/about_flags.cc
- M chrome/browser/flag-metadata.json
- M chrome/browser/flag_descriptions.h
- M chrome/browser/net/chrome_accept_header_browsertest.cc
- M content/browser/network/accept_header_browsertest.cc
- M content/common/content_constants_internal.h
- M content/public/browser/frame_accept_header.cc
- M net/base/mime_util.cc
- M third_party/blink/common/BUILD.gn
- M third_party/blink/common/features.cc
- M third_party/blink/common/loader/network_utils.cc
- A third_party/blink/common/loader/network_utils_unittest.cc
- M third_party/blink/common/mime_util/mime_util.cc
- M third_party/blink/common/mime_util/mime_util_unittest.cc
- M third_party/blink/renderer/core/inspector/inspector_emulation_agent_test.cc
- M third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
- M third_party/blink/renderer/platform/graphics/bitmap_image_metrics.h
- M third_party/blink/renderer/platform/image-decoders/image_decoder.cc
- M third_party/blink/web_tests/TestExpectations
- M third_party/blink/web_tests/VirtualTestSuites
- A third_party/blink/web_tests/virtual/jxl-enabled/README.md
- A third_party/blink/web_tests/virtual/jxl-enabled/http/tests/inspector-protocol/emulation/emulation-set-disabled-image-types-img-expected.txt
- A third_party/blink/web_tests/virtual/jxl-enabled/http/tests/inspector-protocol/emulation/emulation-set-disabled-image-types-picture-expected.txt
- A third_party/blink/web_tests/virtual/jxl-enabled/http/tests/inspector-protocol/prefetch/request-will-be-sent-redirect-cross-site.https-expected.txt
- A third_party/blink/web_tests/virtual/jxl-enabled/http/tests/misc/xhtml-expected.txt
- M tools/metrics/histograms/metadata/blink/enums.xml
- M tools/metrics/histograms/metadata/renderer4/histograms.xml
Change size: L
Delta: 31 files changed, 663 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Wan-Teh Chang, +1 by Luca Versari, +1 by Mark Pearson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Honey B (Gerrit)
Jan 13, 2026, 7:42:24 AMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Helmut Januschka
Honey B added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/image-decoders/image_decoder.cc
Line 222, Patchset 88 (Latest):
return "image/jxl";Honey B . unresolved
Should this also be gated behind the feature flag?
Related details
Attention is currently required from:
- Helmut Januschka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Jan 13, 2026, 8:50:51 AMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/image-decoders/image_decoder.cc
Line 222, Patchset 88 (Latest):
return "image/jxl";Honey B . resolved
Should this also be gated behind the feature flag?
Related details
Attention set is empty
Wan-Teh Chang (Gerrit)
Jan 13, 2026, 2:50:46 PMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Helmut Januschka
Wan-Teh Chang added 4 comments![]( "Open in Gerrit")
File chrome/browser/flag-metadata.json
Line 3483, Patchset 88 (Latest):
"name": "enable-keyboard-rewriter-fix",Wan-Teh Chang . unresolved
Helmut: The addition of enable-keyboard-rewriter-fix seems like a merge error. Please double check.
File net/base/mime_util.cc
Line 186, Patchset 88 (Latest):
{"image/jxl", "jxl"},Wan-Teh Chang . unresolved
Nit: Move this line after the "image/jpeg" line, in alphabetical order?
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
Line 43, Patchset 88 (Latest):
if (type == "jxl") {Wan-Teh Chang . unresolved
Should this be guarded by the feature flag?
Line 65, Patchset 88 (Latest):
} else if (type == "jxl") {Wan-Teh Chang . unresolved
Should this be guarded by the feature flag?
Related details
Attention is currently required from:
- Helmut Januschka
Helmut Januschka (Gerrit)
Jan 13, 2026, 3:42:30 PMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Helmut Januschka added 5 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 88 (Latest):
Helmut Januschka . resolved
@w...@google.com - thanks, follow up https://chromium-review.googlesource.com/c/chromium/src/+/7458407 hopefully the last follow up 😐
File chrome/browser/flag-metadata.json
Line 3483, Patchset 88 (Latest):
"name": "enable-keyboard-rewriter-fix",Wan-Teh Chang . resolved
Helmut: The addition of enable-keyboard-rewriter-fix seems like a merge error. Please double check.
Helmut Januschka
😐 sorry, done
File net/base/mime_util.cc
Line 186, Patchset 88 (Latest):
{"image/jxl", "jxl"},Wan-Teh Chang . resolved
Nit: Move this line after the "image/jpeg" line, in alphabetical order?
Helmut Januschka
Done
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
Line 43, Patchset 88 (Latest):
if (type == "jxl") {Wan-Teh Chang . resolved
Should this be guarded by the feature flag?
Helmut Januschka
yes
Line 65, Patchset 88 (Latest):
} else if (type == "jxl") {Wan-Teh Chang . resolved
Should this be guarded by the feature flag?
Wan-Teh Chang (Gerrit)
Jan 13, 2026, 4:00:14 PMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Wan-Teh Chang added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
Line 66, Patchset 88 (Latest):
use_counter->CountWebDXFeature(WebDXFeature::kJpegxl);Wan-Teh Chang . resolved
Helmut: Just curious: what's the difference between `CountUse()` and `CountWebDXFeature()`? The comments for these two methods are exactly the same:
```
class UseCounter : public GarbageCollectedMixin {
public:
...
// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountUse(mojom::WebFeature feature) = 0;
...
// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountWebDXFeature(WebDXFeature feature) = 0;
};
```
Is `CountWebDXFeature()` preferred in new code?
Helmut Januschka (Gerrit)
Jan 13, 2026, 4:13:28 PMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Honey B, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Helmut Januschka added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
Line 66, Patchset 88 (Latest):
use_counter->CountWebDXFeature(WebDXFeature::kJpegxl);Wan-Teh Chang . resolved
Helmut: Just curious: what's the difference between `CountUse()` and `CountWebDXFeature()`? The comments for these two methods are exactly the same:
```
class UseCounter : public GarbageCollectedMixin {
public:
...// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountUse(mojom::WebFeature feature) = 0;...// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountWebDXFeature(WebDXFeature feature) = 0;
};
```Is `CountWebDXFeature()` preferred in new code?
Helmut Januschka
hope i am right, still new here, it was suggested during a earlier feedback round, to go with DX 😊
`CountUse()` internal metrics recorded to `Blink.UseCounter.Features` histogram. These are Chromium-specific and not shared externally.
`CountWebDXFeature()` Cross-vendor metrics aligned with the https://github.com/web-platform-dx/web-features repository. this can be seen here: https://webstatus.dev/features/jpegxl
Honey B (Gerrit)
Jan 13, 2026, 7:58:36 PMJan 13
to Helmut Januschka, Chromium LUCI CQ, Mark Pearson, Wan-Teh Chang, Luca Versari, Vladimir Levin, Dave Tapuska, Chromium Metrics Reviews, ccameron chromium, Moritz Firsching, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, chromium...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Honey B added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
Line 66, Patchset 88 (Latest):
use_counter->CountWebDXFeature(WebDXFeature::kJpegxl);Wan-Teh Chang . resolved
Helmut JanuschkaHelmut: Just curious: what's the difference between `CountUse()` and `CountWebDXFeature()`? The comments for these two methods are exactly the same:
```
class UseCounter : public GarbageCollectedMixin {
public:
...// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountUse(mojom::WebFeature feature) = 0;...// Counts a use of the given feature. Repeated calls are ignored.
virtual void CountWebDXFeature(WebDXFeature feature) = 0;
};
```Is `CountWebDXFeature()` preferred in new code?
hope i am right, still new here, it was suggested during a earlier feedback round, to go with DX 😊
`CountUse()` internal metrics recorded to `Blink.UseCounter.Features` histogram. These are Chromium-specific and not shared externally.
`CountWebDXFeature()` Cross-vendor metrics aligned with the https://github.com/web-platform-dx/web-features repository. this can be seen here: https://webstatus.dev/features/jpegxl
Honey B
Just to add: both are shared externally, in https://chromestatus.com/metrics/feature/popularity and https://chromestatus.com/metrics/webfeature/popularity respectively.
http://crrev.com/c/5560554 mapped some existing use counters into WebDXFeature counters.
Reply all
Reply to author
Forward
0 new messages