[ios] Add InvalidateInsetRange() to FullscreenBrowserAgent [chromium/src : main]
0 views
Skip to first unread message
Scott Yoder (Gerrit)
11:22 AM (8 hours ago) 11:22 AM
to Gauthier Ambard, Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Scott Yoder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
12:17 PM (7 hours ago) 12:17 PM
to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/fullscreen/model/fullscreen_browser_agent.mm
Line 39, Patchset 2 (Latest):
min_insets_.top = std::max(min_insets_.top, min);Gauthier Ambard . unresolved
Do we want "max" or more like "add" here? If I am calling it with two toolbars on top of each others, going from 10pt to 50pt each, shouldn't the result be 20 to 100?
Related details
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
12:52 PM (6 hours ago) 12:52 PM
to Gauthier Ambard, Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Scott Yoder voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Yoder
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/fullscreen/model/fullscreen_browser_agent.mm
Do we want "max" or more like "add" here? If I am calling it with two toolbars on top of each others, going from 10pt to 50pt each, shouldn't the result be 20 to 100?
Scott Yoder
Yeah, I think you're right. I was originally thinking that the toolbars would need to know not just their min / max height, but where over top of the WebView they are. But I think it is easier for them to just know their min/max height and report that amount, and then it can be added together.
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
12:52 PM (6 hours ago) 12:52 PM
to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Gauthier Ambard voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
12:57 PM (6 hours ago) 12:57 PM
to Gauthier Ambard, Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Scott Yoder voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:55 PM (5 hours ago) 1:55 PM
to Scott Yoder, Gauthier Ambard, Hira Mahmood, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Add InvalidateInsetRange() to FullscreenBrowserAgent
FullscreenBrowserAgent now keeps track of the min and max top and bottom
obscured insets. When InvalidateInsetRange() is called, it zeroes out
the current tracked insets and notifies its observers by calling
WillUpdateObscuredInsetRange().
Observers can respond by calling AddObscuredInsetRange() with the
UIRectEdge (top or bottom) and the amount obscured. The browser agent
then determines and stores the maximum of the newly provided min and max
inset values compared to its current tracked values. It provides public
accessors min_insets() and max_insets() to retrieve the resulting
values.
Fixed: 495744102
Change-Id: I236e679223f58592ceac594acf098cf4cc3f8b70
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Scott Yoder <scott...@google.com>
Cr-Commit-Position: refs/heads/main@{#1604248}
Files:
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent.h
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent.mm
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent_observer.h
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent_observer_bridge.h
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent_observer_bridge.mm
- M ios/chrome/browser/fullscreen/model/fullscreen_browser_agent_unittest.mm
Change size: M
Delta: 6 files changed, 140 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages