IDB: SQLite store - add support for blobs that are stored as files. [chromium/src : main]

0 views

Skip to first unread message

Steve Becker (Gerrit)

unread,

12:21 AM (3 hours ago) 12:21 AM

to Evan Stade, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, storage...@chromium.org

Attention needed from Evan Stade

Steve Becker voted and added 4 comments

Votes added by Steve Becker

Code-Review

4 comments

File content/browser/indexed_db/instance/blob_endpoint.h

Line 24, Patchset 9 (Latest): // Like Clone(), but called by the owner of `this`.

Steve Becker . unresolved

nit: With the interface extracted, this comment lacks context. Maybe we can point the specific Clone() function?

File content/browser/indexed_db/instance/sqlite/database_connection.h

Line 301, Patchset 9 (Latest): // In the case of legacy blobs that are standalone files, the second argument

Steve Becker . unresolved

For extremely large files (1GB+), will SQLite need to use standalone files?

File content/browser/indexed_db/instance/sqlite/database_connection.cc

Line 1075, Patchset 9 (Latest): legacy_blob_files_ = SnapshotLegacyBlobFiles();

Steve Becker . unresolved

If the database contains a lot of legacy blobs, will performance degrade? Could we cache the blob IDs when they become inactive instead?

Line 2127, Patchset 9 (Latest): if (!statement.Step()) {

Steve Becker . unresolved

Is it worthwhile to also log when statement.Step() fails?

Open in Gerrit

Related details

Attention is currently required from:

Evan Stade

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages