Revert "updater: set the default load flags at link time for updatersetup" [chromium/src : main]
0 views
Skip to first unread message
Rakina Zata Amni (Gerrit)
Jun 18, 2026, 12:26:05 AM (13 days ago) Jun 18
to Sorin Jianu, Chromium LUCI CQ, S Ganesh, Will Harris, chromium...@chromium.org
Attention needed from S Ganesh, Sorin Jianu and Will Harris
Rakina Zata Amni has uploaded the change for review![]( "Open in Gerrit")
Rakina Zata Amni would like Sorin Jianu, Chromium LUCI CQ, S Ganesh and Will Harris to review this change.
Commit message
Revert "updater: set the default load flags at link time for updatersetup"
This reverts commit fb08f62833e02fc8254d71dcb7a2c1d755b655bf.
Reason for revert: suspect for updater_tests failures
Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/win-asan/39752/overview
Original change's description:
> updater: set the default load flags at link time for updatersetup
>
> The link option /DEPENDENTLOADFLAG:0x800 which corresponds to
> LOAD_LIBRARY_SEARCH_SYSTEM32 is added to the link flags to limit the
> module search path to the system directory.
>
> Bug: 523382354
> Change-Id: I44d95adeb2417a03e1ec15f14b6eea9238f77a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7951480
> Reviewed-by: S Ganesh <gan...@chromium.org>
> Commit-Queue: Will Harris <w...@chromium.org>
> Auto-Submit: Sorin Jianu <so...@chromium.org>
> Reviewed-by: Will Harris <w...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1648461}
Bug: 523382354
Change-Id: I796d23ed65d3fbc197928faefd9a8be2a6d21b0e
Change diff
diff --git a/chrome/updater/win/installer/BUILD.gn b/chrome/updater/win/installer/BUILD.gn
index 46e93505..f710c38 100644
--- a/chrome/updater/win/installer/BUILD.gn
+++ b/chrome/updater/win/installer/BUILD.gn
@@ -166,8 +166,6 @@
libs = [ "setupapi.lib" ]
- ldflags = [ "/DEPENDENTLOADFLAG:0x800" ]
-
deps = [
":$archive_name",
":${target_name}_version",
Change information
Files:
- M chrome/updater/win/installer/BUILD.gn
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- S Ganesh
- Sorin Jianu
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 18, 2026, 12:26:57 AM (13 days ago) Jun 18
to rubber-...@appspot.gserviceaccount.com, Sorin Jianu, Chromium LUCI CQ, S Ganesh, Will Harris, chromium...@chromium.org
Attention needed from S Ganesh, Sorin Jianu and Will Harris
Rakina Zata Amni voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- S Ganesh
- Sorin Jianu
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jun 18, 2026, 12:27:43 AM (13 days ago) Jun 18
to Rakina Zata Amni, Sorin Jianu, Chromium LUCI CQ, S Ganesh, Will Harris, chromium...@chromium.org
Attention needed from S Ganesh, Sorin Jianu and Will Harris
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- S Ganesh
- Sorin Jianu
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 18, 2026, 12:33:54 AM (13 days ago) Jun 18
to rubber-...@appspot.gserviceaccount.com, Sorin Jianu, Chromium LUCI CQ, S Ganesh, Will Harris, chromium...@chromium.org
Attention needed from S Ganesh, Sorin Jianu and Will Harris
Rakina Zata Amni voted![]( "Open in Gerrit")
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- S Ganesh
- Sorin Jianu
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Jun 18, 2026, 12:58:29 AM (13 days ago) Jun 18
to Rakina Zata Amni, Will Harris, rubber-...@appspot.gserviceaccount.com, Sorin Jianu, Chromium LUCI CQ, S Ganesh, chromium...@chromium.org
Attention needed from Rakina Zata Amni, S Ganesh and Sorin Jianu
Will Harris voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rakina Zata Amni
- S Ganesh
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 2:38:06 AM (13 days ago) Jun 18
to Rakina Zata Amni, Will Harris, rubber-...@appspot.gserviceaccount.com, Sorin Jianu, S Ganesh, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "updater: set the default load flags at link time for updatersetup"
This reverts commit fb08f62833e02fc8254d71dcb7a2c1d755b655bf.
Reason for revert: suspect for updater_tests failures
Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/win-asan/39752/overview
Original change's description:
> updater: set the default load flags at link time for updatersetup
>
> The link option /DEPENDENTLOADFLAG:0x800 which corresponds to
> LOAD_LIBRARY_SEARCH_SYSTEM32 is added to the link flags to limit the
> module search path to the system directory.
>
> Bug: 523382354
> Change-Id: I44d95adeb2417a03e1ec15f14b6eea9238f77a8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7951480
> Reviewed-by: S Ganesh <gan...@chromium.org>
> Commit-Queue: Will Harris <w...@chromium.org>
> Auto-Submit: Sorin Jianu <so...@chromium.org>
> Reviewed-by: Will Harris <w...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1648461}
Bug: 523382354
Change-Id: I796d23ed65d3fbc197928faefd9a8be2a6d21b0e
Commit-Queue: Rakina Zata Amni <rak...@chromium.org>
Auto-Submit: Rakina Zata Amni <rak...@chromium.org>
Owners-Override: Rakina Zata Amni <rak...@chromium.org>
Reviewed-by: Will Harris <w...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648826}
Files:
- M chrome/updater/win/installer/BUILD.gn
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Will Harris, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages