[BNPL-Tabs][Clank] Pass BNPL suggestions when tabs flag is enabled [chromium/src : main]
0 views
Skip to first unread message
Vinny Persky (Gerrit)
Jun 24, 2026, 5:12:18 PM (4 days ago) Jun 24
to Viplav Kadam, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Viplav Kadam
Vinny Persky voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Viplav Kadam
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Viplav Kadam (Gerrit)
Jun 24, 2026, 8:38:29 PM (4 days ago) Jun 24
to Vinny Persky, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Viplav Kadam voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 9:28:28 PM (3 days ago) Jun 24
to Viplav Kadam, Vinny Persky, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[BNPL-Tabs][Clank] Pass BNPL suggestions when tabs flag is enabled
This CL updates `ShouldCreateBnplSuggestionForTouchToFill` to
bypass the check that requires the credit card number field to
be empty, provided that `kAutofillEnablePayNowPayLaterTabs` is enabled.
Previously, BNPL suggestions were always excluded from
Touch-to-Fill if the card number field was non-empty (due to
privacy restrictions when AI amount extraction is enabled). With
the Pay Now Pay Later tabs feature enabled, we want to allow
Passing the BNPL option even in this case because non-empty
credit card number field error will be on the Pay Later tab.
Design: go/clank-pay-now-pay-later-tabs
Bug: 526728883, 526718267
Change-Id: I399d92808006462b775f4e7d72ffc779fdc626f9
Commit-Queue: Viplav Kadam <vipla...@google.com>
Reviewed-by: Vinny Persky <vinny...@google.com>
Cr-Commit-Position: refs/heads/main@{#1652115}
Files:
- M components/autofill/core/browser/suggestions/payments/credit_card_suggestion_generator_unittest.cc
- M components/autofill/core/browser/suggestions/payments/payments_suggestion_generator_util.cc
Change size: S
Delta: 2 files changed, 36 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vinny Persky
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages