[auth-service] Dedupe realm expansion extends [infra/luci/luci-go : main]

0 views

Skip to first unread message

Anne Redulla (Gerrit)

unread,

2:05 AM (18 hours ago) 2:05 AM

to Dan Le Febvre, LUCI CQ, chromium...@chromium.org

Attention needed from Dan Le Febvre

Anne Redulla voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Dan Le Febvre

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Le Febvre (Gerrit)

unread,

3:32 AM (17 hours ago) 3:32 AM

to Anne Redulla, LUCI CQ, chromium...@chromium.org

Attention needed from Anne Redulla

Dan Le Febvre voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Anne Redulla

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

LUCI CQ (Gerrit)

unread,

3:32 AM (17 hours ago) 3:32 AM

to Anne Redulla, Dan Le Febvre, chromium...@chromium.org

LUCI CQ submitted the change

Change information

Commit message:

[auth-service] Dedupe realm expansion extends

This CL tweaks realm expansion to skip adding parent bindings
if they have already been added. This helps in cases such as
a realm which extends other realms that have a common parent.

Another option would be to cache principal bindings per realm,
which would allow for quick lookup. But this would require
storing the per realm bindings slices, i.e. more space.

Bug: b/534824421

Change-Id: I8ef9f51a4bfae1a5dfcb0862896612e0204614e3

Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/8124394

Auto-Submit: Anne Redulla <ared...@google.com>

Commit-Queue: Dan Le Febvre <d...@google.com>

Reviewed-by: Dan Le Febvre <d...@google.com>

Files:

M auth_service/internal/realmsinternals/expansion.go
M auth_service/internal/realmsinternals/expansion_test.go

Change size: M

Delta: 2 files changed, 166 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dan Le Febvre

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages