Add request_id logging in UserMediaProcessor [chromium/src : main]

0 views
Skip to first unread message

Palak Agarwal (Gerrit)

unread,
8:43 AM (4 hours ago) 8:43 AM
to Olga Sharonova, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Attention needed from Olga Sharonova

Palak Agarwal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olga Sharonova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I710e13a9d90ba69aa8e4201bb91023f884244e03
Gerrit-Change-Number: 7689000
Gerrit-PatchSet: 3
Gerrit-Owner: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 12:43:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Sharonova (Gerrit)

unread,
11:20 AM (2 hours ago) 11:20 AM
to Palak Agarwal, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Attention needed from Palak Agarwal

Olga Sharonova added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Olga Sharonova . unresolved

Why do we need to pass request_id around? Don't the have the info in current_request_info_?

Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I710e13a9d90ba69aa8e4201bb91023f884244e03
    Gerrit-Change-Number: 7689000
    Gerrit-PatchSet: 3
    Gerrit-Owner: Palak Agarwal <agp...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Mar 2026 15:20:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Palak Agarwal (Gerrit)

    unread,
    12:08 PM (1 hour ago) 12:08 PM
    to Olga Sharonova, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
    Attention needed from Olga Sharonova

    Palak Agarwal added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3:
    Olga Sharonova . resolved

    Why do we need to pass request_id around? Don't the have the info in current_request_info_?

    Palak Agarwal

    You're right, it's not needed. I was passing around `label` first and then instead used `request_id` as it was a better log than `label` but didn't realize that we don't have to pass it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Olga Sharonova
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I710e13a9d90ba69aa8e4201bb91023f884244e03
      Gerrit-Change-Number: 7689000
      Gerrit-PatchSet: 4
      Gerrit-Owner: Palak Agarwal <agp...@chromium.org>
      Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
      Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
      Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Mar 2026 16:08:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Olga Sharonova <ol...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages