MemoryCoordinator: Add support for the trait IsStateful::kNo [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
12:56 PM (4 hours ago) 12:56 PM
to Andres Ricardo Perez Rojas, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Andres Ricardo Perez Rojas
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andres Ricardo Perez Rojas
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andres Ricardo Perez Rojas (Gerrit)
2:40 PM (2 hours ago) 2:40 PM
to Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Patrick Monette
Andres Ricardo Perez Rojas voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andres Ricardo Perez Rojas
| Code-Review | +1 |
2 comments
Patchset-level comments
Andres Ricardo Perez Rojas . resolved
LGTM with a request for the commit description.
Commit Message
Line 7, Patchset 5 (Latest):
MemoryCoordinator: Add support for the trait IsStateful::kNo
Make sure the memory pressure signal is correctly repeated to memory
consumers that need it.Andres Ricardo Perez Rojas . unresolved
I find the title and the first line a bit confusing.
My understanding is that, before this CL, clients with `IsStateful::kYes` were being "spammed" with redundant calls, but apart from that everything was working correctly, even if not optimal.
But from the title, I would guess that `IsStateful::kNo` clients were being mishandled.
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
2:42 PM (2 hours ago) 2:42 PM
to Andres Ricardo Perez Rojas, Chromium LUCI CQ, chromium...@chromium.org
Patrick Monette added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 5 (Latest):
MemoryCoordinator: Add support for the trait IsStateful::kNo
Make sure the memory pressure signal is correctly repeated to memory
consumers that need it.Andres Ricardo Perez Rojas . resolved
I find the title and the first line a bit confusing.
My understanding is that, before this CL, clients with `IsStateful::kYes` were being "spammed" with redundant calls, but apart from that everything was working correctly, even if not optimal.
But from the title, I would guess that `IsStateful::kNo` clients were being mishandled.
Patrick Monette
Mistake from my end, but because of the early return in SetLimit, non-stateful clients would not repeatedly receive the memory pressure signal.
So the title is correct.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
3:38 PM (1 hour ago) 3:38 PM
to Andres Ricardo Perez Rojas, Chromium LUCI CQ, chromium...@chromium.org
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Patrick Monette . resolved
Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:47 PM (1 hour ago) 3:47 PM
to Patrick Monette, Andres Ricardo Perez Rojas, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
MemoryCoordinator: Add support for the trait IsStateful::kNo
Make sure the memory pressure signal is correctly repeated to memory
consumers that need it.
When MemoryCoordinatorPolicyState::SetLimit() is called with identical
parameters, it automatically detects this as a repeated request. If
release_memory is enabled and the system is under pressure, it triggers
a repeated call to `OnReleaseMemory()` for stateless consumers, while
avoiding redundant notifications to stateful consumers.
Bug: 441951621
Change-Id: I996c67e8ebc59f2ed0121573a95c1175d46ce6ab
Reviewed-by: Andres Ricardo Perez Rojas <andres...@chromium.org>
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637889}
Files:
- M content/common/memory_coordinator/memory_coordinator_policy_state.cc
- M content/common/memory_coordinator/memory_coordinator_policy_state.h
- M content/common/memory_coordinator/memory_coordinator_policy_state_unittest.cc
Change size: M
Delta: 3 files changed, 137 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andres Ricardo Perez Rojas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages