Clarify Service Worker lifetime for Payment Handlers in FAQ [chromium/src : main]

0 views
Skip to first unread message

Yoshisato Yanagisawa (Gerrit)

unread,
4:11 AM (19 hours ago) 4:11 AM
to Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org

Yoshisato Yanagisawa added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yoshisato Yanagisawa . resolved

As suggested by Emily, let me update the document.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
Gerrit-Change-Number: 7462029
Gerrit-PatchSet: 1
Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: Elly FJ <elly...@chromium.org>
Gerrit-CC: Emily Stark <est...@chromium.org>
Gerrit-CC: Mike West <mk...@chromium.org>
Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yoshisato Yanagisawa (Gerrit)

unread,
4:13 AM (19 hours ago) 4:13 AM
to Shunya Shishido, Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org
Attention needed from Shunya Shishido

Yoshisato Yanagisawa voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
Gerrit-Change-Number: 7462029
Gerrit-PatchSet: 1
Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: Elly FJ <elly...@chromium.org>
Gerrit-CC: Emily Stark <est...@chromium.org>
Gerrit-CC: Mike West <mk...@chromium.org>
Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:12:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shunya Shishido (Gerrit)

unread,
4:21 AM (19 hours ago) 4:21 AM
to Yoshisato Yanagisawa, Chromium LUCI CQ, Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org
Attention needed from Yoshisato Yanagisawa

Shunya Shishido voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yoshisato Yanagisawa
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
    Gerrit-Change-Number: 7462029
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Emily Stark <est...@chromium.org>
    Gerrit-CC: Mike West <mk...@chromium.org>
    Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 09:21:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yoshisato Yanagisawa (Gerrit)

    unread,
    8:46 PM (2 hours ago) 8:46 PM
    to Shunya Shishido, Chromium LUCI CQ, Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org

    Yoshisato Yanagisawa voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
    Gerrit-Change-Number: 7462029
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Elly FJ <elly...@chromium.org>
    Gerrit-CC: Emily Stark <est...@chromium.org>
    Gerrit-CC: Mike West <mk...@chromium.org>
    Gerrit-CC: Stephen McGruer <smcg...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 01:46:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yoshisato Yanagisawa (Gerrit)

    unread,
    8:49 PM (2 hours ago) 8:49 PM
    to Shunya Shishido, Chromium LUCI CQ, Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org

    Yoshisato Yanagisawa added 1 comment

    Patchset-level comments
    Yoshisato Yanagisawa . resolved

    For who visit this CL in the future,
    note that the internal discussion has been done in https://groups.google.com/a/google.com/g/chrome-worker/c/ltBNBmM0NmA?e=48417069.

    Gerrit-Comment-Date: Wed, 14 Jan 2026 01:48:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    8:49 PM (2 hours ago) 8:49 PM
    to Yoshisato Yanagisawa, Shunya Shishido, Elly FJ, Mike West, Emily Stark, Stephen McGruer, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Clarify Service Worker lifetime for Payment Handlers in FAQ

    The Service Worker Security FAQ currently states standard termination policies (e.g., 30-second idle timeout) but does not reflect the exception for Payment Handlers.

    To address timeouts in payment flows longer than 5 minutes (an issue raised by partners like Google Pay), http://crrev.com/c/7226437 was implemented to keep a Payment Handler's Service Worker active as long as its payment window is open.

    During the review of that CL, a concern was raised about potential abuse of this extended lifetime. The security team was consulted and concluded that this does not introduce a significant new attack surface. Their rationale was that the worker's activity is tied to a user-visible window, which users are unlikely to keep open indefinitely, making the risk negligible.

    This CL updates the FAQ to make this exception and its security rationale explicit, aligning the documentation with the implemented and security-reviewed behavior.
    Bug: 41438822
    Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
    Reviewed-by: Shunya Shishido <sisid...@chromium.org>
    Commit-Queue: Yoshisato Yanagisawa <yyana...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568853}
    Files:
    • M docs/security/service-worker-security-faq.md
    Change size: XS
    Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Shunya Shishido
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id30ea79d77a8f928c4b91402ac2f3a58cf902937
    Gerrit-Change-Number: 7462029
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages