Remove manual reimplementation of std::optional::transform [chromium/src : main]

0 views
Skip to first unread message

Chris Fredrickson (Gerrit)

unread,
10:01 AM (8 hours ago) 10:01 AM
to Kevin Graney, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from Kevin Graney

Chris Fredrickson voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Graney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29be169ee9f59a77cb994cff88976bd3f8236b11
Gerrit-Change-Number: 7691618
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Kevin Graney <k...@google.com>
Gerrit-Attention: Kevin Graney <k...@google.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 14:01:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Graney (Gerrit)

unread,
10:02 AM (8 hours ago) 10:02 AM
to Chris Fredrickson, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org
Attention needed from Chris Fredrickson

Kevin Graney voted and added 1 comment

Votes added by Kevin Graney

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kevin Graney . resolved

🎉 nice!

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Fredrickson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29be169ee9f59a77cb994cff88976bd3f8236b11
Gerrit-Change-Number: 7691618
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Kevin Graney <k...@google.com>
Gerrit-Attention: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 14:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chris Fredrickson (Gerrit)

unread,
10:14 AM (8 hours ago) 10:14 AM
to Kevin Graney, Chromium LUCI CQ, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org

Chris Fredrickson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29be169ee9f59a77cb994cff88976bd3f8236b11
Gerrit-Change-Number: 7691618
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Kevin Graney <k...@google.com>
Gerrit-Comment-Date: Mon, 23 Mar 2026 14:13:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
10:17 AM (8 hours ago) 10:17 AM
to Chris Fredrickson, Kevin Graney, chromium...@chromium.org, aashna...@google.com, boujan...@google.com, chrstn...@google.com, kmg+...@google.com, mfoltz+wa...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove manual reimplementation of std::optional::transform
Bug: 388070065
Change-Id: I29be169ee9f59a77cb994cff88976bd3f8236b11
Reviewed-by: Kevin Graney <k...@google.com>
Auto-Submit: Chris Fredrickson <cfre...@chromium.org>
Commit-Queue: Chris Fredrickson <cfre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1603451}
Files:
  • M chrome/browser/actor/ui/ui_event_debugstring.cc
Change size: S
Delta: 1 file changed, 1 insertion(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kevin Graney
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29be169ee9f59a77cb994cff88976bd3f8236b11
Gerrit-Change-Number: 7691618
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kevin Graney <k...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages