Refactor check for suggested results in aggregator. [chromium/src : main]

0 views
Skip to first unread message

Darren Shen (Gerrit)

unread,
3:53 AM (20 hours ago) 3:53 AM
to Michael Cui, chromium...@chromium.org
Attention needed from Michael Cui

Darren Shen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Cui
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70d99fb1fd391ec91e9974a8d52bff20170534a9
Gerrit-Change-Number: 5671540
Gerrit-PatchSet: 1
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
Gerrit-Attention: Michael Cui <ml...@google.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 07:52:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Cui (Gerrit)

unread,
8:24 PM (3 hours ago) 8:24 PM
to Darren Shen, Michael Cui, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Darren Shen

Michael Cui voted and added 1 comment

Votes added by Michael Cui

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Cui . resolved

Nice!

Open in Gerrit

Related details

Attention is currently required from:
  • Darren Shen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70d99fb1fd391ec91e9974a8d52bff20170534a9
Gerrit-Change-Number: 5671540
Gerrit-PatchSet: 1
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
Gerrit-Attention: Darren Shen <sh...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 00:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
9:11 PM (2 hours ago) 9:11 PM
to Darren Shen, Michael Cui, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Refactor check for suggested results in aggregator.

Use the section type to ensure the sources that are "suggestions"
are in sync with this check.
Bug: b:345303965
Change-Id: I70d99fb1fd391ec91e9974a8d52bff20170534a9
Reviewed-by: Michael Cui <ml...@google.com>
Commit-Queue: Darren Shen <sh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322508}
Files:
  • M ash/picker/search/picker_search_aggregator.cc
Change size: S
Delta: 1 file changed, 4 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Cui
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I70d99fb1fd391ec91e9974a8d52bff20170534a9
Gerrit-Change-Number: 5671540
Gerrit-PatchSet: 2
Gerrit-Owner: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Darren Shen <sh...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages