[extensions] Add omnibox chip for top-level MIME handler extensions [chromium/src : main]

0 views
Skip to first unread message

Maksim Sisov (Gerrit)

unread,
Apr 27, 2026, 12:49:11 PM (8 days ago) Apr 27
to Chris Thompson, Permissions Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Kevin McNee, James Maclean, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Chris Thompson

Maksim Sisov added 1 comment

Patchset-level comments
File-level comment, Patchset 19 (Latest):
Maksim Sisov . resolved

Chris, ptal. As per discussion in https://docs.google.com/document/d/1jw9oGpoRR-OOf57ItwS--U9INnaDOfpEodkPd4ZNFeA, this will make mime handler extensions use chip and bubble popup that normal extensions use

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Thompson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I48c100f39c5db2129412f663aab13a928df65f9a
Gerrit-Change-Number: 7781086
Gerrit-PatchSet: 19
Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Chris Thompson <cth...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Apr 2026 16:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Maksim Sisov (Gerrit)

unread,
Apr 27, 2026, 12:50:01 PM (8 days ago) Apr 27
to Chris Thompson, Permissions Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Kevin McNee, James Maclean, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Chris Thompson

Maksim Sisov added 1 comment

Patchset-level comments
Maksim Sisov . resolved

Chris, ptal. As per discussion in https://docs.google.com/document/d/1jw9oGpoRR-OOf57ItwS--U9INnaDOfpEodkPd4ZNFeA, this will make mime handler extensions use chip and bubble popup that normal extensions use

Maksim Sisov

Who of the owners do you think I shall ask to review this as well? I'd appreciate if you can suggest someone

Gerrit-Comment-Date: Mon, 27 Apr 2026 16:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maksim Sisov <msi...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Chris Thompson (Gerrit)

unread,
Apr 30, 2026, 4:00:34 PM (5 days ago) Apr 30
to Maksim Sisov, Permissions Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Kevin McNee, James Maclean, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Maksim Sisov

Chris Thompson voted and added 4 comments

Votes added by Chris Thompson

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 21 (Latest):
Chris Thompson . resolved

Did some overall review, but mostly focusing on the location bar display bits. Overall LGTM, although individual owners may have more feedback.

I think one useful thing would be to upload some screenshots of the new UI with an example handler extension in a comment on the implementation bug.

File chrome/browser/ui/views/location_bar/location_icon_view.cc
Line 11, Patchset 21 (Parent):#include "chrome/browser/extensions/extension_ui_util.h"
Chris Thompson . unresolved

include deletions here seem unexpected

File chrome/browser/ui/views/location_bar/webui_location_bar.cc
Line 360, Patchset 21 (Latest): content::WebContents* web_contents = GetWebContents();
Chris Thompson . unresolved

nit: Not needed (Maybe a remnant from earlier changes?)

File extensions/browser/ui_util.cc
Line 25, Patchset 21 (Latest):namespace extensions {
namespace ui_util {
Chris Thompson . unresolved

Please fix this WARNING reported by ClangTidy: check: modernize-concat-nested-namespaces

nested namespaces can be concatenated...

check: modernize-concat-nested-namespaces

nested namespaces can be concatenated (https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html)

(Note: You can add `Skip-Clang-Tidy-Checks: modernize-concat-nested-namespaces` footer to the CL description to skip the check)

(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)

Open in Gerrit

Related details

Attention is currently required from:
  • Maksim Sisov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I48c100f39c5db2129412f663aab13a928df65f9a
    Gerrit-Change-Number: 7781086
    Gerrit-PatchSet: 21
    Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
    Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
    Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Maksim Sisov <msi...@igalia.com>
    Gerrit-Comment-Date: Thu, 30 Apr 2026 20:00:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maksim Sisov (Gerrit)

    unread,
    5:37 AM (3 hours ago) 5:37 AM
    to Chris Thompson, Permissions Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Kevin McNee, James Maclean, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
    Attention needed from Chris Thompson

    Maksim Sisov added 2 comments

    File chrome/browser/ui/views/location_bar/webui_location_bar.cc
    Line 360, Patchset 21: content::WebContents* web_contents = GetWebContents();
    Chris Thompson . resolved

    nit: Not needed (Maybe a remnant from earlier changes?)

    Maksim Sisov

    Done

    File extensions/browser/ui_util.cc
    Line 25, Patchset 21:namespace extensions {
    namespace ui_util {
    Chris Thompson . resolved

    Please fix this WARNING reported by ClangTidy: check: modernize-concat-nested-namespaces

    nested namespaces can be concatenated...

    check: modernize-concat-nested-namespaces

    nested namespaces can be concatenated (https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html)

    (Note: You can add `Skip-Clang-Tidy-Checks: modernize-concat-nested-namespaces` footer to the CL description to skip the check)

    (Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)

    Maksim Sisov

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Thompson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I48c100f39c5db2129412f663aab13a928df65f9a
      Gerrit-Change-Number: 7781086
      Gerrit-PatchSet: 23
      Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
      Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Chris Thompson <cth...@chromium.org>
      Gerrit-Comment-Date: Tue, 05 May 2026 09:36:57 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Chris Thompson <cth...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Maksim Sisov (Gerrit)

      unread,
      7:39 AM (1 hour ago) 7:39 AM
      to Andy Phan, Devlin Cronin, Foromo Daniel Soromou, Chris Thompson, Permissions Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Kevin McNee, James Maclean, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
      Attention needed from Andy Phan, Chris Thompson, Devlin Cronin and Foromo Daniel Soromou

      Maksim Sisov added 1 comment

      Patchset-level comments
      File-level comment, Patchset 23 (Latest):
      Maksim Sisov . resolved

      Andy, please review //e/b/mime_handler
      Devlin, please review //c/b/extensions
      Daniel, please review //chrome/browser/ui/views/location_bar/ and page_info (if possible)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andy Phan
      • Chris Thompson
      • Devlin Cronin
      • Foromo Daniel Soromou
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I48c100f39c5db2129412f663aab13a928df65f9a
      Gerrit-Change-Number: 7781086
      Gerrit-PatchSet: 23
      Gerrit-Owner: Maksim Sisov <msi...@igalia.com>
      Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
      Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
      Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
      Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Kevin McNee <mc...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Andy Phan <andy...@chromium.org>
      Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
      Gerrit-Attention: Chris Thompson <cth...@chromium.org>
      Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Comment-Date: Tue, 05 May 2026 11:39:06 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages