Use same shutdown order in ~TestProfileIOS() as in ~ProfileIOS() [chromium/src : main]
0 views
Skip to first unread message
Max Ihlenfeldt (Gerrit)
7:36 AM (5 hours ago) 7:36 AM
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Max Ihlenfeldt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Max Ihlenfeldt
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
9:24 AM (3 hours ago) 9:24 AM
to Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Max Ihlenfeldt
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Max Ihlenfeldt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:40 AM (3 hours ago) 9:40 AM
to Sylvain Defresne, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use same shutdown order in ~TestProfileIOS() as in ~ProfileIOS()
To bring test and production behaviour closer together, this CL changes
the shutdown order of TestProfileIOS to be the same as ProfileIOS.
Bug: None
Change-Id: I18ff8bf4d933984eddcc486756c2e4acf24ebe04
Reviewed-by: Sylvain Defresne <sdef...@chromium.org>
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Auto-Submit: Max Ihlenfeldt <m...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1658692}
Files:
- M ios/chrome/browser/shared/model/profile/test/test_profile_ios.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sylvain Defresne
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages