settings: Fix finishCurrentSettings() for Android settings in tab [chromium/src : main]
James Cook (Gerrit)
James Cook added 2 comments![]( "Open in Gerrit")
((SettingsActivity) activity).finishCurrentSettings(fragment);FYI - This was the line that was crashing, with ClassCastException.
Related details
- Jinsuk Kim
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jinsuk Kim (Gerrit)
Jinsuk Kim added 3 comments![]( "Open in Gerrit")
// If we have pending back entries, show the correct fragment. This can happen when aWould you check one scenario for this new logic?
1) Enter multi-column settings after signed in.
2) Tap account entry in main settings to show 'Account' in the right pane
3) Tap 'sign out' at the bottom of the right pane
This makes settings (in SettingsActivity) exit, which is not desirable but inevitable, due to finishCurrentSettings called with an empty back stack. I *think* this new logic makes the settings tab stay with the invalidated account subsettings.
((SettingsActivity) activity).finishCurrentSettings(fragment);FYI - This was the line that was crashing, with ClassCastException.
Acknowledged.
How do you feel about extending this class to have its own impl for settings in a tab, as more methods are being overridden? Maybe a TODO if that makes sense to you.
if (mSettingsHostFragment != null && mSettingsHostFragment.isAttachedToActivity()) {Please add a log or use asserts to see if this is called when the fragment is null or in detached state.
Related details
- James Cook
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jinsuk Kim (Gerrit)
Jinsuk Kim added 1 comment![]( "Open in Gerrit")
// If we have pending back entries, show the correct fragment. This can happen when aWould you check one scenario for this new logic?
1) Enter multi-column settings after signed in.
2) Tap account entry in main settings to show 'Account' in the right pane
3) Tap 'sign out' at the bottom of the right paneThis makes settings (in SettingsActivity) exit, which is not desirable but inevitable, due to finishCurrentSettings called with an empty back stack. I *think* this new logic makes the settings tab stay with the invalidated account subsettings.