Add unit tests for StripTabUnderlineManager [chromium/src : main]

0 views
Skip to first unread message

Neil Coronado (Gerrit)

unread,
6:08 PM (3 hours ago) 6:08 PM
to Michael Wu, Sirisha Kavuluru, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Michael Wu

Neil Coronado voted and added 1 comment

Votes added by Neil Coronado

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Neil Coronado . resolved

thanks for adding tests!

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Wu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ae0851918d6b3e5ba3e26bb51c16931cf2cac59
Gerrit-Change-Number: 8129482
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Michael Wu <mk...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 22:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Michael Wu (Gerrit)

unread,
6:20 PM (3 hours ago) 6:20 PM
to Neil Coronado, Sirisha Kavuluru, Chromium LUCI CQ, chromium...@chromium.org

Michael Wu voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ae0851918d6b3e5ba3e26bb51c16931cf2cac59
Gerrit-Change-Number: 8129482
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
Gerrit-CC: Sirisha Kavuluru <skav...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 22:19:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
7:18 PM (2 hours ago) 7:18 PM
to Michael Wu, Neil Coronado, Sirisha Kavuluru, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add unit tests for StripTabUnderlineManager
Bug: 481486143
Change-Id: I8ae0851918d6b3e5ba3e26bb51c16931cf2cac59
Reviewed-by: Neil Coronado <ne...@google.com>
Commit-Queue: Michael Wu <mk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666695}
Files:
  • M chrome/android/junit/BUILD.gn
  • A chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripTabUnderlineManagerTest.java
Change size: M
Delta: 2 files changed, 158 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Neil Coronado
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ae0851918d6b3e5ba3e26bb51c16931cf2cac59
Gerrit-Change-Number: 8129482
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Wu <mk...@google.com>
Gerrit-Reviewer: Neil Coronado <ne...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages