Remove expired histograms for `AppBanners` and `Webapp` [chromium/src : main]

정재원 (Gerrit)

unread,

Nov 25, 2022, 9:03:50 PM11/25/22

to asvitkine...@chromium.org, dominickn+w...@chromium.org, pkotwic...@chromium.org, Dominick Ng, Eric Willigers, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Dominick Ng, Eric Willigers.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Please review this commit.

To view, visit change 4058028. To unsubscribe, or for help writing mail filters, visit settings.

Eric Willigers (Gerrit)

unread,

Nov 26, 2022, 3:18:29 AM11/26/22

to 정재원, asvitkine...@chromium.org, dominickn+w...@chromium.org, pkotwic...@chromium.org, Dominick Ng, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Dominick Ng, 정재원.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Webapp.Install.DisplayMode expired and was replaced with
  Webapp.Install.DisplayMode2.
  This CL removes Webapp.Install.DisplayMode2, which has not expired.

To view, visit change 4058028. To unsubscribe, or for help writing mail filters, visit settings.

정재원 (Gerrit)

unread,

Nov 26, 2022, 6:57:03 AM11/26/22

to asvitkine...@chromium.org, dominickn+w...@chromium.org, pkotwic...@chromium.org, Dominick Ng, Eric Willigers, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Dominick Ng, Eric Willigers.

View Change

2 comments:

Patchset:
- Patch Set #1:
  Webapp.Install.DisplayMode expired and was replaced with […]
  Thank you for your careful review.
  I thought it was expired because DisplayMode2 was listed at the code location in the issue.
  I revised it again to remove MinutesFromFirstVisitToBannerShown only.
Patchset:
- Patch Set #2:
  I revised it, so please review it again.

To view, visit change 4058028. To unsubscribe, or for help writing mail filters, visit settings.

Eric Willigers (Gerrit)

unread,

Nov 26, 2022, 2:54:49 PM11/26/22

to 정재원, asvitkine...@chromium.org, dominickn+w...@chromium.org, pkotwic...@chromium.org, Dominick Ng, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Dominick Ng, 정재원.

Patch set 2:Code-Review +1

View Change

To view, visit change 4058028. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward