[media] Update V4L2VideoEncodeAccelerator to handle ColorSpace changes. [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
May 8, 2026, 9:38:28 AM (2 days ago) May 8
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org
Attention needed from Vasiliy Telezhnikov

Saifuddin Hitawala added 2 comments

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Saifuddin Hitawala . resolved

Please take a look.

File media/gpu/v4l2/v4l2_video_encode_accelerator.cc
Line 1034, Patchset 6: input_color_space_ = frame.ColorSpace();
Saifuddin Hitawala . unresolved

Ideally, this should default here to Rec709 or SRGB if `frame.ColorSpace()` is invalid and also set this default ColorSpace on `frame`, to ensure SharedImage always has a valid ColorSpace on creation. I'm not doing that here now, and we can look into it later as part of later goal.

Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I13e7292ff0eb7af8bdf2b4141b4cf03f987217ba
Gerrit-Change-Number: 7830867
Gerrit-PatchSet: 7
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 13:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
May 8, 2026, 12:05:48 PM (2 days ago) May 8
to Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org
Attention needed from Saifuddin Hitawala

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I13e7292ff0eb7af8bdf2b4141b4cf03f987217ba
    Gerrit-Change-Number: 7830867
    Gerrit-PatchSet: 7
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 16:05:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Saifuddin Hitawala (Gerrit)

    unread,
    May 8, 2026, 12:54:27 PM (2 days ago) May 8
    to Hirokazu Honda, Pilar Molina Lopez, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org
    Attention needed from Hirokazu Honda and Pilar Molina Lopez

    Saifuddin Hitawala added 1 comment

    Patchset-level comments
    Saifuddin Hitawala . resolved

    Thanks! Adding media/ owners to take a look.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hirokazu Honda
    • Pilar Molina Lopez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I13e7292ff0eb7af8bdf2b4141b4cf03f987217ba
    Gerrit-Change-Number: 7830867
    Gerrit-PatchSet: 7
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Hirokazu Honda <hi...@chromium.org>
    Gerrit-Reviewer: Pilar Molina Lopez <pmolin...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Pilar Molina Lopez <pmolin...@chromium.org>
    Gerrit-Attention: Hirokazu Honda <hi...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 16:54:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Pilar Molina Lopez (Gerrit)

    unread,
    May 9, 2026, 10:42:13 AM (yesterday) May 9
    to Saifuddin Hitawala, Hirokazu Honda, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org
    Attention needed from Hirokazu Honda and Saifuddin Hitawala

    Pilar Molina Lopez voted and added 1 comment

    Votes added by Pilar Molina Lopez

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Pilar Molina Lopez . resolved

    lgtm!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hirokazu Honda
    • Saifuddin Hitawala
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I13e7292ff0eb7af8bdf2b4141b4cf03f987217ba
    Gerrit-Change-Number: 7830867
    Gerrit-PatchSet: 8
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Hirokazu Honda <hi...@chromium.org>
    Gerrit-Reviewer: Pilar Molina Lopez <pmolin...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Attention: Hirokazu Honda <hi...@chromium.org>
    Gerrit-Comment-Date: Sat, 09 May 2026 14:42:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hirokazu Honda (Gerrit)

    unread,
    May 9, 2026, 9:16:27 PM (16 hours ago) May 9
    to Saifuddin Hitawala, Pilar Molina Lopez, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, oshima...@chromium.org
    Attention needed from Saifuddin Hitawala

    Hirokazu Honda added 2 comments

    File media/gpu/v4l2/v4l2_video_encode_accelerator.cc
    Line 589, Patchset 8 (Latest): base::FeatureList::IsEnabled(kV4L2VEAUseCorrectColorSpace)
    ? input_color_space_
    : gfx::ColorSpace(),
    Hirokazu Honda . unresolved

    Do you see anything changed by this CL?

    The existing code propagates the input color space.
    https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/chromeos/libyuv_image_processor_backend.cc;l=352;drc=9405179380f3b5222471aa3430a8683f8c88f137

    Besides, V4L2VEA doesn't currently embed the color space information to the stream.

    Line 1034, Patchset 6: input_color_space_ = frame.ColorSpace();
    Saifuddin Hitawala . unresolved

    Ideally, this should default here to Rec709 or SRGB if `frame.ColorSpace()` is invalid and also set this default ColorSpace on `frame`, to ensure SharedImage always has a valid ColorSpace on creation. I'm not doing that here now, and we can look into it later as part of later goal.

    Hirokazu Honda

    Do you have any plan to do this?

    The current code is nothing is set in V4L2VEA::Initialize(), so input_color_space_ is invalid.
    No IP reconfiguration happens if no frame color space is specified.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Saifuddin Hitawala
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I13e7292ff0eb7af8bdf2b4141b4cf03f987217ba
    Gerrit-Change-Number: 7830867
    Gerrit-PatchSet: 8
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Hirokazu Honda <hi...@chromium.org>
    Gerrit-Reviewer: Pilar Molina Lopez <pmolin...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Comment-Date: Sun, 10 May 2026 01:16:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Saifuddin Hitawala <hita...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages