Sort peak usage by percentage instead of raw number [infra/infra : main]

0 views
Skip to first unread message

Pietro Scuttari (Gerrit)

unread,
Sep 25, 2025, 11:25:02 AM (14 hours ago) Sep 25
to chromium...@chromium.org, infra-rev...@chromium.org, fleet-console-...@google.com

Pietro Scuttari has uploaded the change for review

Commit message

Sort peak usage by percentage instead of raw number
Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03

Change diff

diff --git a/go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go b/go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
index 8024195..4b191cc 100644
--- a/go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
+++ b/go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
@@ -136,6 +136,9 @@
 			END
 		`, true
 	}
+	if column == "peak_usage" {
+		return "peak_usage / total_devices", true
+	}
 
 	return "", false
 }

Change information

Files:
  • M go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Gerrit-Change-Number: 6982952
Gerrit-PatchSet: 1
Gerrit-Owner: Pietro Scuttari <pietro...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Pietro Scuttari (Gerrit)

unread,
Sep 25, 2025, 11:27:47 AM (14 hours ago) Sep 25
to Vaghinak Vardanyan, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Vaghinak Vardanyan

Pietro Scuttari voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vaghinak Vardanyan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Gerrit-Change-Number: 6982952
Gerrit-PatchSet: 1
Gerrit-Owner: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Attention: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:27:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vaghinak Vardanyan (Gerrit)

unread,
Sep 25, 2025, 11:43:43 AM (13 hours ago) Sep 25
to Pietro Scuttari, LUCI CQ, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Pietro Scuttari and Vaghinak Vardanyan

Vaghinak Vardanyan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Pietro Scuttari
  • Vaghinak Vardanyan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Gerrit-Change-Number: 6982952
Gerrit-PatchSet: 1
Gerrit-Owner: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Attention: Pietro Scuttari <pietro...@google.com>
Gerrit-Attention: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:43:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Pietro Scuttari (Gerrit)

unread,
Sep 25, 2025, 11:47:16 AM (13 hours ago) Sep 25
to Vaghinak Vardanyan, LUCI CQ, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Vaghinak Vardanyan

Pietro Scuttari voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Vaghinak Vardanyan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Gerrit-Change-Number: 6982952
Gerrit-PatchSet: 3
Gerrit-Owner: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Attention: Vaghinak Vardanyan <vagh...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:47:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

LUCI CQ (Gerrit)

unread,
Sep 25, 2025, 12:05:55 PM (13 hours ago) Sep 25
to Pietro Scuttari, Vaghinak Vardanyan, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org

LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
Insertions: 1, Deletions: 1.

@@ -137,7 +137,7 @@
 		`, true
 	}
 	if column == "peak_usage" {
-		return "peak_usage / total_devices", true
+		return "CAST(peak_usage AS FLOAT)/ NULLIF(total_devices, 0)", true
 	}
 
 	return "", false
```

Change information

Commit message:
Sort peak usage by percentage instead of raw number
Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Commit-Queue: Pietro Scuttari <pietro...@google.com>
Auto-Submit: Pietro Scuttari <pietro...@google.com>
Reviewed-by: Vaghinak Vardanyan <vagh...@google.com>
Cr-Commit-Position: refs/heads/main@{#76610}
Files:
  • M go/src/infra/fleetconsole/internal/consoleserver/list_repair_metrics.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vaghinak Vardanyan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I00b922f83aa2e53ad699be22549ec43f8e6abc03
Gerrit-Change-Number: 6982952
Gerrit-PatchSet: 4
Gerrit-Owner: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Pietro Scuttari <pietro...@google.com>
Gerrit-Reviewer: Vaghinak Vardanyan <vagh...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages