[Extensions] Compile management_util only on Windows and Mac [chromium/src : main]

0 views
Skip to first unread message

Anunoy Ghosh (Gerrit)

unread,
Jul 23, 2026, 1:08:49 PM (2 days ago) Jul 23
to Kelvin Jiang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Kelvin Jiang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kelvin Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d403231c13e3e11a6a50ee1981575b98bedd694
Gerrit-Change-Number: 8139739
Gerrit-PatchSet: 1
Gerrit-Owner: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Jul 2026 17:08:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kelvin Jiang (Gerrit)

unread,
Jul 24, 2026, 9:41:30 PM (18 hours ago) Jul 24
to Anunoy Ghosh, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Anunoy Ghosh

Kelvin Jiang voted and added 2 comments

Votes added by Kelvin Jiang

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kelvin Jiang . resolved

LGTM w nit thanks!

File chrome/browser/extensions/management/management_util.cc
Line 31, Patchset 1 (Latest):}
Kelvin Jiang . unresolved

nit: add newline

Open in Gerrit

Related details

Attention is currently required from:
  • Anunoy Ghosh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d403231c13e3e11a6a50ee1981575b98bedd694
Gerrit-Change-Number: 8139739
Gerrit-PatchSet: 1
Gerrit-Owner: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
Gerrit-Attention: Anunoy Ghosh <anu...@chromium.org>
Gerrit-Comment-Date: Sat, 25 Jul 2026 01:41:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anunoy Ghosh (Gerrit)

unread,
7:52 AM (8 hours ago) 7:52 AM
to Kelvin Jiang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Anunoy Ghosh added 2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Anunoy Ghosh . resolved

Thanks for the review!

File chrome/browser/extensions/management/management_util.cc
Line 31, Patchset 1:}
Kelvin Jiang . resolved

nit: add newline

Anunoy Ghosh

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d403231c13e3e11a6a50ee1981575b98bedd694
    Gerrit-Change-Number: 8139739
    Gerrit-PatchSet: 2
    Gerrit-Owner: Anunoy Ghosh <anu...@chromium.org>
    Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Comment-Date: Sat, 25 Jul 2026 11:52:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kelvin Jiang <kelvi...@chromium.org>
    satisfied_requirement
    open
    diffy

    Anunoy Ghosh (Gerrit)

    unread,
    7:52 AM (8 hours ago) 7:52 AM
    to Kelvin Jiang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Anunoy Ghosh voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d403231c13e3e11a6a50ee1981575b98bedd694
    Gerrit-Change-Number: 8139739
    Gerrit-PatchSet: 2
    Gerrit-Owner: Anunoy Ghosh <anu...@chromium.org>
    Gerrit-Reviewer: Anunoy Ghosh <anu...@chromium.org>
    Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
    Gerrit-Comment-Date: Sat, 25 Jul 2026 11:52:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Anunoy Ghosh (Gerrit)

    unread,
    12:32 PM (3 hours ago) 12:32 PM
    to Kelvin Jiang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Gerrit-Comment-Date: Sat, 25 Jul 2026 16:32:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages