Add totalFrames and discardedFrames stats to MediaStreamTrackProcessor [chromium/src : main]

0 views

Skip to first unread message

Palak Agarwal (Gerrit)

unread,

7:34 AM (1 hour ago) 7:34 AM

to Guido Urdaneta, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org

Attention needed from Guido Urdaneta

Palak Agarwal added 3 comments

File third_party/blink/renderer/modules/breakout_box/frame_queue_underlying_source.cc

Line 65, Patchset 9 (Latest): DCHECK(device_id_.empty() || frame_pool_size_ > 0);

Palak Agarwal . unresolved

why do we have this dcheck? AudioDataQueueUnderlyingSource doesn't satisfy this condition. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source.cc;l=133;drc=be6170c296bfe4547a285b1a3839458151f471c2

Line 197, Patchset 9 (Latest): std::optional<NativeFrameType> popped_frame = frame_queue->Pop();

Palak Agarwal . unresolved

shoudl we add a counter for discarded frames here as well?

Line 311, Patchset 9 (Latest): frame_queue_handle_.Invalidate();

Palak Agarwal . unresolved

shoudl we add a counter for discarded frames here as well?

Open in Gerrit

Related details

Attention is currently required from:

Guido Urdaneta

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages