Cache more GL state both service and client side. (issue 11363191)

gm...@chromium.org

unread,

Nov 12, 2012, 2:46:49 AM11/12/12

to apat...@chromium.org, bre...@chromium.org, chromium...@chromium.org, apat...@chromium.org

Reviewers: apatrick_chromium, brettw,

Message:
Hey Al, PTAL

Hey Brett, can you please bless the ppapi file change?

Thank you

Description:
Cache more GL state both service and client side.

BUG=160370

Please review this at https://codereview.chromium.org/11363191/

SVN Base: http://git.chromium.org/chromium/src.git@master

Affected files:
M gpu/command_buffer/build_gles2_cmd_buffer.py
A gpu/command_buffer/client/client_context_state.h
A + gpu/command_buffer/client/client_context_state.cc
A gpu/command_buffer/client/client_context_state_autogen.h
A gpu/command_buffer/client/client_context_state_impl_autogen.h
M gpu/command_buffer/client/gles2_implementation.h
M gpu/command_buffer/client/gles2_implementation.cc
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h
M gpu/command_buffer/client/gles2_implementation_unittest.cc
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
M gpu/command_buffer/service/context_state.h
M gpu/command_buffer/service/context_state_impl_autogen.h
M gpu/command_buffer/service/gles2_cmd_decoder.cc
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h
M gpu/gpu_common.gypi
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp

bre...@chromium.org

unread,

Nov 13, 2012, 2:20:23 PM11/13/12

to gm...@chromium.org, apat...@chromium.org, chromium...@chromium.org, apat...@chromium.org

ppapi/ lgtm, I didn't look at the rest.

https://codereview.chromium.org/11363191/

apat...@chromium.org

unread,

Nov 13, 2012, 3:22:14 PM11/13/12

to gm...@chromium.org, bre...@chromium.org, chromium...@chromium.org

lgtm

https://codereview.chromium.org/11363191/

commi...@chromium.org

unread,

Nov 13, 2012, 8:32:03 PM11/13/12

to gm...@chromium.org, apat...@chromium.org, bre...@chromium.org, chromium...@chromium.org, apat...@chromium.org

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gm...@chromium.org/11363191/2001

https://chromiumcodereview.appspot.com/11363191/

commi...@chromium.org

unread,

Nov 13, 2012, 8:59:45 PM11/13/12

to gm...@chromium.org, apat...@chromium.org, bre...@chromium.org, chromium...@chromium.org, apat...@chromium.org

Retried try job too often for step(s) compile

https://chromiumcodereview.appspot.com/11363191/

commi...@chromium.org

unread,

Nov 13, 2012, 9:55:57 PM11/13/12

to gm...@chromium.org, apat...@chromium.org, bre...@chromium.org, chromium...@chromium.org, apat...@chromium.org

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/gm...@chromium.org/11363191/25

https://chromiumcodereview.appspot.com/11363191/

commi...@chromium.org

unread,

Nov 13, 2012, 10:17:48 PM11/13/12

to gm...@chromium.org, apat...@chromium.org, bre...@chromium.org, chromium...@chromium.org, apat...@chromium.org

Retried try job too often for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, chrome_frame_net_tests,
chrome_frame_unittests, content_browsertests, content_unittests,
crypto_unittests, gpu_unittests, installer_util_unittests,
interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, mini_installer_test,
nacl_integration, net_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests, unit_tests

https://chromiumcodereview.appspot.com/11363191/