nested app menu: Consolidate submenu enabling logic [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 12:14:35 PM (yesterday) Jul 10
to chromium...@chromium.org, yusufo...@chromium.org, gogeral...@chromium.org, yuezhang...@chromium.org, browser-comp...@chromium.org, meilian...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, android-web...@chromium.org, davidj...@chromium.org, wychen...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

nested app menu: Consolidate submenu enabling logic

This CL is in preparation of using a slightly more complicated logic to
determine whether to enable submenus in the app menu.
Bug: 404074424
Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596

Change diff


Change information

Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/BookmarksItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/HistoryItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/MoreToolsItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
Change size: S
Delta: 5 files changed, 16 insertions(+), 15 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Gerrit-Change-Number: 8073724
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 1:01:58 PM (yesterday) Jul 10
to chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Gerrit-Change-Number: 8073724
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 17:01:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
Jul 10, 2026, 3:02:18 PM (yesterday) Jul 10
to Masa Fujita, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Masa Fujita

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Gerrit-Change-Number: 8073724
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
6:18 AM (11 hours ago) 6:18 AM
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted and added 1 comment

Votes added by Masa Fujita

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Masa Fujita . resolved

Thanks~!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Gerrit-Change-Number: 8073724
Gerrit-PatchSet: 4
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Sat, 11 Jul 2026 10:18:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
6:23 AM (11 hours ago) 6:23 AM
to Masa Fujita, Calder Kitagawa, chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
nested app menu: Consolidate submenu enabling logic

This CL is in preparation of using a slightly more complicated logic to
determine whether to enable submenus in the app menu.
Bug: 404074424
Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Commit-Queue: Masa Fujita <mas...@google.com>
Cr-Commit-Position: refs/heads/main@{#1660714}
Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/BookmarksItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/HistoryItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/MoreToolsItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilder.java
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
Change size: S
Delta: 5 files changed, 16 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Calder Kitagawa
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifdf2e4ea34bf83538d9847193fdd5f48e237f596
Gerrit-Change-Number: 8073724
Gerrit-PatchSet: 5
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages