Minor improvements for page_colors_controller_browsertest.cc. [chromium/src : main]
0 views
Skip to first unread message
Peter Kasting (Gerrit)
Sep 4, 2025, 2:43:18 PM (3 days ago) Sep 4
to Jacques Newman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jacques Newman
Peter Kasting voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jacques Newman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jacques Newman (Gerrit)
Sep 4, 2025, 6:58:42 PM (2 days ago) Sep 4
to Peter Kasting, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Peter Kasting
Jacques Newman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jacques Newman
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Jacques Newman . resolved
Change lgtm, happy to see tests are more readable and running on all platforms.
+Sam Davis for visibility.
Related details
Attention is currently required from:
- Peter Kasting
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kasting (Gerrit)
Sep 4, 2025, 7:01:28 PM (2 days ago) Sep 4
to Jacques Newman, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Peter Kasting voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kasting (Gerrit)
Sep 4, 2025, 8:37:24 PM (2 days ago) Sep 4
to Jacques Newman, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Peter Kasting (Gerrit)
Sep 4, 2025, 8:57:07 PM (2 days ago) Sep 4
to Jacques Newman, Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Peter Kasting voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 9:07:06 PM (2 days ago) Sep 4
to Peter Kasting, Jacques Newman, Sam Davis Omekara, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Minor improvements for page_colors_controller_browsertest.cc.
* Add helper to get the native UI instance
* Consistently check the web theme when looking at things like the
computed page colors, since that's ultimately the instance that will
matter to web content
* Shorten/clarify comments
* Unconditionalize test case I believe passes everywhere
* Don't bother checking the forced colors state on the web instance,
which isn't directly part of PageColorsController's purview
Bug: 432019728
AX-Relnotes: n/a.
Change-Id: I48f4db98cd7e4c29cd47c94d85f676a600966c69
Reviewed-by: Jacques Newman <jane...@microsoft.com>
Commit-Queue: Peter Kasting <pkas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511252}
Files:
- M chrome/browser/accessibility/page_colors_controller_browsertest.cc
Change size: M
Delta: 1 file changed, 77 insertions(+), 109 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jacques Newman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages