Correct Map Store to use StringVal [infra/infra : main]

0 views
Skip to first unread message

Warren Whitman (Gerrit)

unread,
Sep 4, 2025, 9:14:29 PM (2 days ago) Sep 4
to Gowri Denduluri, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Gowri Denduluri

Warren Whitman voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gowri Denduluri
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
Gerrit-Change-Number: 6918009
Gerrit-PatchSet: 1
Gerrit-Owner: Warren Whitman <warr...@google.com>
Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
Gerrit-Reviewer: Warren Whitman <warr...@google.com>
Gerrit-Attention: Gowri Denduluri <gowr...@google.com>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:14:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Gowri Denduluri (Gerrit)

unread,
Sep 5, 2025, 12:11:48 AM (2 days ago) Sep 5
to Warren Whitman, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Warren Whitman

Gowri Denduluri voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Warren Whitman
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
Gerrit-Change-Number: 6918009
Gerrit-PatchSet: 1
Gerrit-Owner: Warren Whitman <warr...@google.com>
Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
Gerrit-Reviewer: Warren Whitman <warr...@google.com>
Gerrit-Attention: Warren Whitman <warr...@google.com>
Gerrit-Comment-Date: Fri, 05 Sep 2025 04:11:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Gowri Denduluri (Gerrit)

unread,
Sep 5, 2025, 12:16:54 AM (2 days ago) Sep 5
to Warren Whitman, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Warren Whitman

Gowri Denduluri added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gowri Denduluri . unresolved

CL is failing presubmit, please fix and retry submit

Open in Gerrit

Related details

Attention is currently required from:
  • Warren Whitman
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
    Gerrit-Change-Number: 6918009
    Gerrit-PatchSet: 1
    Gerrit-Owner: Warren Whitman <warr...@google.com>
    Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
    Gerrit-Reviewer: Warren Whitman <warr...@google.com>
    Gerrit-Attention: Warren Whitman <warr...@google.com>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 04:16:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gowri Denduluri (Gerrit)

    unread,
    Sep 5, 2025, 12:19:40 AM (2 days ago) Sep 5
    to Warren Whitman, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
    Attention needed from Warren Whitman

    Gowri Denduluri added 1 comment

    File go/src/infra/unifiedfleet/app/dumper/nlyte_bq_sync.go
    Line 154, Patchset 1 (Latest): nlyteAssetMap.Store(row.Tag.StringVal, struct{}{})
    Gowri Denduluri . unresolved

    Do we need to check if row.Tag is a non null value?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Warren Whitman
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
    Gerrit-Change-Number: 6918009
    Gerrit-PatchSet: 1
    Gerrit-Owner: Warren Whitman <warr...@google.com>
    Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
    Gerrit-Reviewer: Warren Whitman <warr...@google.com>
    Gerrit-Attention: Warren Whitman <warr...@google.com>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 04:19:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Warren Whitman (Gerrit)

    unread,
    Sep 5, 2025, 5:06:17 PM (2 days ago) Sep 5
    to Gowri Denduluri, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
    Attention needed from Gowri Denduluri

    Warren Whitman added 1 comment

    Patchset-level comments
    Gowri Denduluri . unresolved

    CL is failing presubmit, please fix and retry submit

    Warren Whitman

    I'm not sure the failure is to do with my code directly; seems the presubmit job is failing to load some expected modules?

    Failed to call ['go', 'mod', 'tidy'], return code 1:
    None

    I can try running that locally and see what happens

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gowri Denduluri
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
    Gerrit-Change-Number: 6918009
    Gerrit-PatchSet: 1
    Gerrit-Owner: Warren Whitman <warr...@google.com>
    Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
    Gerrit-Reviewer: Warren Whitman <warr...@google.com>
    Gerrit-Attention: Gowri Denduluri <gowr...@google.com>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 21:06:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Gowri Denduluri <gowr...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Warren Whitman (Gerrit)

    unread,
    Sep 5, 2025, 5:17:15 PM (2 days ago) Sep 5
    to Gowri Denduluri, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
    Attention needed from Gowri Denduluri

    Warren Whitman added 2 comments

    Patchset-level comments
    Gowri Denduluri . resolved

    CL is failing presubmit, please fix and retry submit

    Warren Whitman

    I'm not sure the failure is to do with my code directly; seems the presubmit job is failing to load some expected modules?

    Failed to call ['go', 'mod', 'tidy'], return code 1:
    None

    I can try running that locally and see what happens

    Warren Whitman

    Yeah, local attempt didn't change anything, and presubmit worked just now. Odd.

    File go/src/infra/unifiedfleet/app/dumper/nlyte_bq_sync.go
    Line 154, Patchset 1 (Latest): nlyteAssetMap.Store(row.Tag.StringVal, struct{}{})
    Gowri Denduluri . resolved

    Do we need to check if row.Tag is a non null value?

    Warren Whitman

    If Tag is NULL, making the proto fails, so we would follow the error path.
    Even for code that attempts to access a NULL, the given value is an empty type, so an empty string in this case; it won't panic.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gowri Denduluri
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: infra/infra
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
      Gerrit-Change-Number: 6918009
      Gerrit-PatchSet: 1
      Gerrit-Owner: Warren Whitman <warr...@google.com>
      Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
      Gerrit-Reviewer: Warren Whitman <warr...@google.com>
      Gerrit-Attention: Gowri Denduluri <gowr...@google.com>
      Gerrit-Comment-Date: Fri, 05 Sep 2025 21:17:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Warren Whitman <warr...@google.com>
      Comment-In-Reply-To: Gowri Denduluri <gowr...@google.com>
      satisfied_requirement
      open
      diffy

      Gowri Denduluri (Gerrit)

      unread,
      Sep 5, 2025, 6:32:22 PM (2 days ago) Sep 5
      to Warren Whitman, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
      Attention needed from Warren Whitman

      Gowri Denduluri added 2 comments

      Patchset-level comments
      Gowri Denduluri . resolved

      CL is failing presubmit, please fix and retry submit

      Warren Whitman

      I'm not sure the failure is to do with my code directly; seems the presubmit job is failing to load some expected modules?

      Failed to call ['go', 'mod', 'tidy'], return code 1:
      None

      I can try running that locally and see what happens

      Warren Whitman

      Yeah, local attempt didn't change anything, and presubmit worked just now. Odd.

      Gowri Denduluri

      Ack

      File go/src/infra/unifiedfleet/app/dumper/nlyte_bq_sync.go
      Line 154, Patchset 1 (Latest): nlyteAssetMap.Store(row.Tag.StringVal, struct{}{})
      Gowri Denduluri . resolved

      Do we need to check if row.Tag is a non null value?

      Warren Whitman

      If Tag is NULL, making the proto fails, so we would follow the error path.
      Even for code that attempts to access a NULL, the given value is an empty type, so an empty string in this case; it won't panic.

      Gowri Denduluri

      Ack

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Warren Whitman
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: infra/infra
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedfad79fa4b4f6bdd26a5089d22b463fb7acc9c2
      Gerrit-Change-Number: 6918009
      Gerrit-PatchSet: 1
      Gerrit-Owner: Warren Whitman <warr...@google.com>
      Gerrit-Reviewer: Gowri Denduluri <gowr...@google.com>
      Gerrit-Reviewer: Warren Whitman <warr...@google.com>
      Gerrit-Attention: Warren Whitman <warr...@google.com>
      Gerrit-Comment-Date: Fri, 05 Sep 2025 22:32:18 +0000
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages