[bookmarks] Deflake BookmarkPaneTests [chromium/src : main]

0 views
Skip to first unread message

Brandon Wylie (Gerrit)

unread,
1:57 PM (9 hours ago) 1:57 PM
to Henrique Nakashima, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Henrique Nakashima

Brandon Wylie voted and added 2 comments

Votes added by Brandon Wylie

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 2:
Henrique Nakashima . resolved

Depending on your level of confidence, might be good to land two changes: 1. fixes; 2. re-enable. that way even if it gets reverted you can still look at Test Reviver results with the fixes.

Brandon Wylie

Great idea.

File chrome/test/android/javatests/src/org/chromium/chrome/test/util/BookmarkTestUtil.java
Line 240, Patchset 2: public static void clearBookmarkPrefs() {
Henrique Nakashima . resolved

I think SharedPrefs are already reset between tests, so this shouldn't be necessary.

Brandon Wylie

Wasn't aware, removed!

Open in Gerrit

Related details

Attention is currently required from:
  • Henrique Nakashima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3411ee5bc9680f2a2740de2aadde574a8d791113
Gerrit-Change-Number: 7465832
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
Gerrit-Reviewer: Henrique Nakashima <hnaka...@chromium.org>
Gerrit-Attention: Henrique Nakashima <hnaka...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 18:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Henrique Nakashima <hnaka...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Henrique Nakashima (Gerrit)

unread,
2:37 PM (9 hours ago) 2:37 PM
to Brandon Wylie, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Brandon Wylie

Henrique Nakashima voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Wylie
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3411ee5bc9680f2a2740de2aadde574a8d791113
    Gerrit-Change-Number: 7465832
    Gerrit-PatchSet: 5
    Gerrit-Owner: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Henrique Nakashima <hnaka...@chromium.org>
    Gerrit-Attention: Brandon Wylie <wyl...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 19:37:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Brandon Wylie (Gerrit)

    unread,
    7:40 PM (4 hours ago) 7:40 PM
    to Henrique Nakashima, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

    Brandon Wylie voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3411ee5bc9680f2a2740de2aadde574a8d791113
    Gerrit-Change-Number: 7465832
    Gerrit-PatchSet: 5
    Gerrit-Owner: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Henrique Nakashima <hnaka...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 00:40:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:43 PM (4 hours ago) 7:43 PM
    to Brandon Wylie, Henrique Nakashima, chromium...@chromium.org, browser-comp...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bookmarks] Deflake BookmarkPaneTests

    Will re-enable in a follow-up CL to avoid a potential revert of the
    fixes.
    Bug: 474580496
    Change-Id: I3411ee5bc9680f2a2740de2aadde574a8d791113
    Reviewed-by: Henrique Nakashima <hnaka...@chromium.org>
    Commit-Queue: Brandon Wylie <wyl...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1569437}
    Files:
    • M chrome/browser/bookmarks/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkPaneTest.java
    Change size: XS
    Delta: 1 file changed, 7 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Henrique Nakashima
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3411ee5bc9680f2a2740de2aadde574a8d791113
    Gerrit-Change-Number: 7465832
    Gerrit-PatchSet: 6
    Gerrit-Owner: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Brandon Wylie <wyl...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Henrique Nakashima <hnaka...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages