[Cake] Add linkedServices setting iOS fieldtrial_testing_config back [chromium/src : main]

0 views
Skip to first unread message

Rainhard Findling (Gerrit)

unread,
Sep 23, 2025, 3:07:15 PM (2 days ago) Sep 23
to Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Rainhard Findling voted and added 1 comment

Votes added by Rainhard Findling

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Rainhard Findling . resolved

Mind TAQL? :)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ba9bdf746a16ad91e468e6775953f57f3a667c9
Gerrit-Change-Number: 6975074
Gerrit-PatchSet: 2
Gerrit-Owner: Rainhard Findling <rain...@chromium.org>
Gerrit-Reviewer: Rainhard Findling <rain...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 19:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rainhard Findling (Gerrit)

unread,
Sep 23, 2025, 3:51:42 PM (2 days ago) Sep 23
to Martin Šrámek, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Martin Šrámek

Rainhard Findling voted and added 1 comment

Votes added by Rainhard Findling

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Rainhard Findling . resolved

Another one, mind TAQL? :)

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Šrámek
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8ba9bdf746a16ad91e468e6775953f57f3a667c9
Gerrit-Change-Number: 6975074
Gerrit-PatchSet: 3
Gerrit-Owner: Rainhard Findling <rain...@chromium.org>
Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
Gerrit-Reviewer: Rainhard Findling <rain...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 19:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Martin Šrámek (Gerrit)

unread,
12:01 PM (2 hours ago) 12:01 PM
to Rainhard Findling, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Rainhard Findling

Martin Šrámek voted and added 1 comment

Votes added by Martin Šrámek

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Martin Šrámek . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Rainhard Findling
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ba9bdf746a16ad91e468e6775953f57f3a667c9
    Gerrit-Change-Number: 6975074
    Gerrit-PatchSet: 3
    Gerrit-Owner: Rainhard Findling <rain...@chromium.org>
    Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
    Gerrit-Reviewer: Rainhard Findling <rain...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Rainhard Findling <rain...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 16:01:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    12:50 PM (1 hour ago) 12:50 PM
    to Rainhard Findling, Martin Šrámek, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Cake] Add linkedServices setting iOS fieldtrial_testing_config back

    Turns out we still need the respective feature, bringing back the
    fieldtrial testing config for a while.
    Fixed: 446935947
    Bug: 324091979
    Change-Id: I8ba9bdf746a16ad91e468e6775953f57f3a667c9
    Auto-Submit: Rainhard Findling <rain...@chromium.org>
    Commit-Queue: Martin Šrámek <msr...@chromium.org>
    Reviewed-by: Martin Šrámek <msr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1520690}
    Files:
    • M testing/variations/fieldtrial_testing_config.json
    Change size: S
    Delta: 1 file changed, 15 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Martin Šrámek
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8ba9bdf746a16ad91e468e6775953f57f3a667c9
    Gerrit-Change-Number: 6975074
    Gerrit-PatchSet: 4
    Gerrit-Owner: Rainhard Findling <rain...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
    Gerrit-Reviewer: Rainhard Findling <rain...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages