gcapi_mac: Bump minimum deployment target to macOS 11.0 for Xcode 27 [chromium/src : main]

0 views

Skip to first unread message

Yue She (Gerrit)

unread,

Jul 31, 2026, 5:53:47 PM (2 days ago) Jul 31

to Mark Mentovai, Avi Drissman, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Avi Drissman and Mark Mentovai

Yue She added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Yue She . resolved

ptal. let me know if this is the right way to proceed. changing to `openApplicationAtURL` doesn't seem very trivial because it's going from synchronous to asynchronous method call

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Mark Mentovai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Aug 1, 2026, 8:46:11 PM (11 hours ago) Aug 1

to Yue She, Chromium LUCI CQ, Mark Mentovai, Avi Drissman, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Mark Mentovai and Yue She

Avi Drissman added 1 comment

File chrome/installer/gcapi_mac/gcapi.mm

Line 503, Patchset 2 (Latest):

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
    return [NSWorkspace.sharedWorkspace launchApplication:app_path];
#pragma clang diagnostic pop

Avi Drissman . unresolved

This is trivial to update; please do so. Do not just turn off deprecation warnings.
```suggestion
   [NSWorkspace.sharedWorkspace
       openApplicationAtURL:[NSURL fileURLWithPath:app_path]
              configuration:[NSWorkspaceOpenConfiguration configuration]
          completionHandler:^(NSRunningApplication* app, NSError* error) {
              // handle error
          }];
```