[Autofill] Replace SameFieldAs with FormFieldData::DeepEqual [chromium/src : main]
0 views
Skip to first unread message
Piotr Kotynia (Gerrit)
Jun 9, 2025, 3:53:43 PM6/9/25
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Christoph Schwering
Piotr Kotynia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Piotr Kotynia . resolved
Hi Chris, PTAL. This is the https://chromium-review.googlesource.com/c/chromium/src/+/6618748 change behind the kill switch.
Related details
Attention is currently required from:
- Christoph Schwering
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Jun 12, 2025, 8:09:59 AM6/12/25
to Piotr Kotynia, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Kotynia
Christoph Schwering voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christoph Schwering
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Piotr Kotynia
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Jun 12, 2025, 8:18:04 AM6/12/25
to Dominic Battré, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Piotr Kotynia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Piotr Kotynia . resolved
Hi Dominic, could you review `c/a/b/form_data_android.cc`?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battré (Gerrit)
Jun 12, 2025, 8:25:13 AM6/12/25
to Piotr Kotynia, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Kotynia
Dominic Battré voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Piotr Kotynia
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Jun 12, 2025, 8:52:25 AM6/12/25
to Dominic Battré, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Piotr Kotynia voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 8:57:07 AM6/12/25
to Piotr Kotynia, Dominic Battré, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Autofill] Replace SameFieldAs with FormFieldData::DeepEqual
This CL replaces all calls of the deprecated `SameFieldAs` with
`FormFieldData::DeepEqual`. This change is introduced behind a kill
switch.
Bug: 40183094
Change-Id: I93818fe79e2fe91f7f4e85bf649564f3d27e97c0
Reviewed-by: Christoph Schwering <schw...@google.com>
Reviewed-by: Dominic Battré <bat...@chromium.org>
Commit-Queue: Piotr Kotynia <piotrk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1472995}
Files:
- M components/android_autofill/browser/form_data_android.cc
- M components/autofill/core/browser/foundations/autofill_manager.cc
- M components/autofill/core/common/autofill_features.cc
- M components/autofill/core/common/autofill_features.h
Change size: S
Delta: 4 files changed, 19 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christoph Schwering, +1 by Dominic Battré
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Jun 12, 2025, 9:17:52 AM6/12/25
to Piotr Kotynia, Chromium LUCI CQ, Dominic Battré, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Attention needed from Piotr Kotynia
Jihad Hanna added 1 comment![]( "Open in Gerrit")
File components/android_autofill/browser/form_data_android.cc
Line 54, Patchset 4 (Latest):
if (base::FeatureList::IsEnabled(
features::kAutofillUseDeepEqualInsteadOfSameFieldAs)
? FormFieldData::DeepEqual(form_.fields()[i], field)
: form_.fields()[i].SameFieldAs(field)) {Jihad Hanna . unresolved
What about just comparing global ids here instead of the whole equality function?
Related details
Attention is currently required from:
- Piotr Kotynia
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Kotynia (Gerrit)
Jun 12, 2025, 9:19:51 AM6/12/25
to Chromium LUCI CQ, Jihad Hanna, Dominic Battré, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org
Piotr Kotynia added 1 comment![]( "Open in Gerrit")
File components/android_autofill/browser/form_data_android.cc
Line 54, Patchset 4 (Latest):
if (base::FeatureList::IsEnabled(
features::kAutofillUseDeepEqualInsteadOfSameFieldAs)
? FormFieldData::DeepEqual(form_.fields()[i], field)
: form_.fields()[i].SameFieldAs(field)) {Jihad Hanna . unresolved
What about just comparing global ids here instead of the whole equality function?
Piotr Kotynia
I am not very into this logic, but sounds good from the high level. +cc @schw...@google.com
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages