Refactor DeviceStatusCollectorTest [chromium/src : main]

0 views
Skip to first unread message

Jun Ishiguro (Gerrit)

unread,
Apr 9, 2026, 5:00:56 AM (4 days ago) Apr 9
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cros-report...@google.com
Attention needed from Hidehiko Abe

Jun Ishiguro added 2 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Jun Ishiguro . resolved

PTAL

File chrome/browser/ash/policy/status_collector/device_status_collector_unittest.cc
Line 3960, Patchset 5 (Parent): void SetUp() override {
Jun Ishiguro . resolved

Seems like this did not call the parent SetUp() intentionally.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a49661760934b3c1d71fdb7908e01556373a003
Gerrit-Change-Number: 7734911
Gerrit-PatchSet: 5
Gerrit-Owner: Jun Ishiguro <ju...@google.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Apr 2026 09:00:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Apr 9, 2026, 1:45:32 PM (4 days ago) Apr 9
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cros-report...@google.com
Attention needed from Jun Ishiguro

Hidehiko Abe added 2 comments

File chrome/browser/ash/policy/status_collector/device_status_collector_unittest.cc
Line 882, Patchset 5 (Latest): session_manager_ = std::make_unique<session_manager::SessionManager>(
std::make_unique<session_manager::FakeSessionManagerDelegate>());
user_manager_.Reset(std::make_unique<user_manager::UserManagerImpl>(
std::make_unique<user_manager::FakeUserManagerDelegate>(),
TestingBrowserProcess::GetGlobal()->GetTestingLocalState()));
Hidehiko Abe . unresolved

can we use TestUserSessionManager?

Line 4088, Patchset 5 (Latest): void TearDown() override { DeviceStatusCollectorTestBase::TearDown(); }
Hidehiko Abe . unresolved

nit: you can remove.

Open in Gerrit

Related details

Attention is currently required from:
  • Jun Ishiguro
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a49661760934b3c1d71fdb7908e01556373a003
    Gerrit-Change-Number: 7734911
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jun Ishiguro <ju...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-Attention: Jun Ishiguro <ju...@google.com>
    Gerrit-Comment-Date: Thu, 09 Apr 2026 17:44:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jun Ishiguro (Gerrit)

    unread,
    6:39 AM (2 hours ago) 6:39 AM
    to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cros-report...@google.com
    Attention needed from Hidehiko Abe

    Jun Ishiguro added 2 comments

    File chrome/browser/ash/policy/status_collector/device_status_collector_unittest.cc
    Line 882, Patchset 5: session_manager_ = std::make_unique<session_manager::SessionManager>(

    std::make_unique<session_manager::FakeSessionManagerDelegate>());
    user_manager_.Reset(std::make_unique<user_manager::UserManagerImpl>(
    std::make_unique<user_manager::FakeUserManagerDelegate>(),
    TestingBrowserProcess::GetGlobal()->GetTestingLocalState()));
    Hidehiko Abe . resolved

    can we use TestUserSessionManager?

    Jun Ishiguro

    Done

    Line 4088, Patchset 5: void TearDown() override { DeviceStatusCollectorTestBase::TearDown(); }
    Hidehiko Abe . resolved

    nit: you can remove.

    Jun Ishiguro

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a49661760934b3c1d71fdb7908e01556373a003
      Gerrit-Change-Number: 7734911
      Gerrit-PatchSet: 6
      Gerrit-Owner: Jun Ishiguro <ju...@google.com>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Comment-Date: Mon, 13 Apr 2026 10:39:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages