Modularize enterprise/signin OIDC test mocks [chromium/src : main]
0 views
Skip to first unread message
Erik Chen (Gerrit)
Jul 20, 2026, 10:59:20 PM (2 days ago) Jul 20
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Thomas Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jul 20, 2026, 11:19:43 PM (2 days ago) Jul 20
to Erik Chen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Erik Chen
Thomas Lukaszewicz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Jul 21, 2026, 1:39:43 AM (yesterday) Jul 21
to Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org
Erik Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 21, 2026, 1:43:06 AM (yesterday) Jul 21
to Erik Chen, Thomas Lukaszewicz, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Modularize enterprise/signin OIDC test mocks
Move mock_oidc_authentication_signin_interceptor and
mock_user_policy_oidc_signin_service out of //chrome/test into a
new //chrome/browser/enterprise/signin:test_support source_set, and
depend on it from the two browser_tests consumers (enterprise/signin
and enterprise/profile_management).
Bug: 353332589
AGENT_GENERATED_CL
Change-Id: I97a8d34e6b967a88cd925cf579a651bb8d0106e8
Commit-Queue: Erik Chen <erik...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665193}
Files:
- M chrome/browser/enterprise/profile_management/BUILD.gn
- M chrome/browser/enterprise/signin/BUILD.gn
- M chrome/test/BUILD.gn
Change size: S
Delta: 3 files changed, 21 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jul 21, 2026, 1:56:45 PM (13 hours ago) Jul 21
to Erik Chen, Chromium LUCI CQ, Lei Zhang, Thomas Lukaszewicz, chromium...@chromium.org
Attention needed from Erik Chen
Lei Zhang added 1 comment![]( "Open in Gerrit")
File chrome/test/BUILD.gn
Line 1030, Patchset 3 (Latest):
sources += [Lei Zhang . unresolved
1. This empty block should have been deleted.
2. This file should have been formatted. Now there are several pending CLs where other developers are modifying this file and all of them are trying to reformat this.
Related details
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Jul 21, 2026, 4:34:39 PM (11 hours ago) Jul 21
to Chromium LUCI CQ, Lei Zhang, Thomas Lukaszewicz, chromium...@chromium.org
Erik Chen added 1 comment![]( "Open in Gerrit")
File chrome/test/BUILD.gn
Line 1030, Patchset 3 (Latest):
sources += [Lei Zhang . resolved
1. This empty block should have been deleted.
2. This file should have been formatted. Now there are several pending CLs where other developers are modifying this file and all of them are trying to reformat this.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages