extensions: Update BUILD.gn files for sync_file_system unit tests [chromium/src : main]
0 views
Skip to first unread message
James Cook (Gerrit)
May 26, 2026, 10:18:16 PM (2 days ago) May 26
to Mingyu Lei, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, kinuko+...@chromium.org, storage...@chromium.org
Attention needed from Mingyu Lei
James Cook added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/sync_file_system/BUILD.gn
Line 167, Patchset 1 (Latest):
"drive_backend/callback_helper_unittest.cc",James Cook . unresolved
This block is cut/paste from chrome/test/BUILD.gn. No modifications.
Line 217, Patchset 1 (Latest):
deps = [James Cook . unresolved
This block came from running "gn check" repeatedly until it passed.
Related details
Attention is currently required from:
- Mingyu Lei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
May 27, 2026, 10:26:48 PM (19 hours ago) May 27
to Mingyu Lei, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, kinuko+...@chromium.org, storage...@chromium.org
Attention needed from Mingyu Lei
James Cook added 1 comment![]( "Open in Gerrit")
Patchset-level comments
James Cook . resolved
Mingyu, friendly ping?
Mingyu Lei (Gerrit)
3:26 AM (14 hours ago) 3:26 AM
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, kinuko+...@chromium.org, storage...@chromium.org
Attention needed from James Cook
Mingyu Lei voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mingyu Lei
| Code-Review | +1 |
2 comments
File chrome/browser/sync_file_system/BUILD.gn
Line 167, Patchset 1 (Latest):
"drive_backend/callback_helper_unittest.cc",James Cook . resolved
This block is cut/paste from chrome/test/BUILD.gn. No modifications.
Mingyu Lei
Acknowledged
Line 217, Patchset 1 (Latest):
deps = [James Cook . resolved
This block came from running "gn check" repeatedly until it passed.
Mingyu Lei
Acknowledged, it would be nice if we can have some tools to do this, but maybe a simple skill will allow AI to do it fast :)
Related details
Attention is currently required from:
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
1:21 PM (4 hours ago) 1:21 PM
to Mingyu Lei, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, kinuko+...@chromium.org, storage...@chromium.org
James Cook voted and added 1 comment![]( "Open in Gerrit")
Votes added by James Cook
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:37 PM (1 hour ago) 3:37 PM
to James Cook, Mingyu Lei, Achuith Bhandarkar, chromium...@chromium.org, kinuko+...@chromium.org, storage...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
extensions: Update BUILD.gn files for sync_file_system unit tests
As part of the bring-up of extensions on desktop Android we're auditing
extensions-related test files. To make the audit easier, and improve
BUILD.gn hygiene, move the sync_file_system unit test file references
out of the monolithic chrome/test/BUILD.gn file and into
chrome/browser/sync_file_system/BUILD.gn, which is closer to where the
files actually live.
Bug: 469417243
Change-Id: I3a22450d6622431a8edc2bb53b0ac84d9c1c8a03
Reviewed-by: Mingyu Lei <le...@chromium.org>
Commit-Queue: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637877}
Files:
- M chrome/browser/sync_file_system/BUILD.gn
- M chrome/test/BUILD.gn
Change size: M
Delta: 2 files changed, 77 insertions(+), 50 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mingyu Lei
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages