[ios] Update back forward list navigation manager prior to state updates [chromium/src : main]
0 views
Skip to first unread message
John Wu (Gerrit)
Jun 11, 2025, 2:18:19 PM6/11/25
to Kyle Hickinson, Chromium LUCI CQ, Claudio DeSouza, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com
Attention needed from Kyle Hickinson
John Wu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kyle Hickinson
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Claudio DeSouza (Gerrit)
Jun 12, 2025, 9:01:24 AM6/12/25
to Kyle Hickinson, John Wu, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com
Attention needed from Kyle Hickinson
Claudio DeSouza voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kyle Hickinson
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Claudio DeSouza (Gerrit)
Jun 12, 2025, 9:01:33 AM6/12/25
to Kyle Hickinson, John Wu, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com
Attention needed from Kyle Hickinson
Claudio DeSouza voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Kyle Hickinson
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 9:12:17 AM6/12/25
to Kyle Hickinson, Claudio DeSouza, John Wu, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Update back forward list navigation manager prior to state updates
This fixes a potential crash when observing the `canGoBack` and
`canGoForward` properties if the underlying `WebState` is reset
after creating the back forward list
Fixed: 422433400
Change-Id: I0326e1c336de43ae28fc0682c89617cb4916672e
Reviewed-by: John Wu <j...@chromium.org>
Commit-Queue: Claudio DeSouza <cdes...@chromium.org>
Reviewed-by: Claudio DeSouza <cdes...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1472999}
Files:
- M ios/web_view/internal/cwv_web_view.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Claudio DeSouza, +1 by John Wu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages