nested app menu: Directly show groups in "Move tab to group" [chromium/src : main]

0 views

Skip to first unread message

Masa Fujita (Gerrit)

unread,

1:05 PM (1 hour ago) 1:05 PM

to chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, jmedle...@chromium.org, browser-comp...@chromium.org, srahim...@chromium.org, asvitki...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

nested app menu: Directly show groups in "Move tab to group"

"Move tab to group" used to bring up a dialog that allowed the user to
move tab to existing tab groups, but per UX direction, we instead show
the list of available tab groups in a list. This is very similar to how
the tab strip context menu behaves. We also hide "Move tab to group"
when there is no tab group to move to.

Demo: http://screenshot/5VhqwP2EzBHokq8

Change-Id: I39a329ca50d59117e879b9202fff8d8351d92748

Change diff

Change information

Files:

M chrome/android/java/res/values/ids.xml
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilder.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilderUnitTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java
M chrome/browser/ui/android/appmenu/BUILD.gn
A chrome/browser/ui/android/appmenu/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuTabGroupItemProperties.java

Change size: L

Delta: 9 files changed, 292 insertions(+), 69 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Masa Fujita (Gerrit)

unread,

1:06 PM (1 hour ago) 1:06 PM

to Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, browser-comp...@chromium.org, jmedle...@chromium.org, srahim...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue