app menu: Add more unit tests for TabGroupBuilder [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Jul 5, 2026, 11:28:13 PM (6 days ago) Jul 5
to chromium...@chromium.org, Peter Beverloo, lizeb+watch...@chromium.org, browser-comp...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

app menu: Add more unit tests for TabGroupBuilder
Bug: 404074424
Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3

Change diff


Change information

Files:
  • M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilderUnitTest.java
Change size: M
Delta: 1 file changed, 53 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 6, 2026, 12:30:14 AM (6 days ago) Jul 6
to chromium...@chromium.org, Peter Beverloo, browser-comp...@chromium.org, lizeb+watch...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 04:29:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 10, 2026, 1:06:01 PM (yesterday) Jul 10
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, browser-comp...@chromium.org, lizeb+watch...@chromium.org
Attention needed from Calder Kitagawa

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 17:05:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
Jul 10, 2026, 3:03:18 PM (23 hours ago) Jul 10
to Masa Fujita, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, browser-comp...@chromium.org, lizeb+watch...@chromium.org
Attention needed from Masa Fujita

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
6:19 AM (8 hours ago) 6:19 AM
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, browser-comp...@chromium.org, lizeb+watch...@chromium.org

Masa Fujita voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 2
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Comment-Date: Sat, 11 Jul 2026 10:18:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
6:22 AM (8 hours ago) 6:22 AM
to Masa Fujita, Calder Kitagawa, chromium...@chromium.org, Peter Beverloo, browser-comp...@chromium.org, lizeb+watch...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
app menu: Add more unit tests for TabGroupBuilder
Bug: 404074424
Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Commit-Queue: Masa Fujita <mas...@google.com>
Cr-Commit-Position: refs/heads/main@{#1660713}
Files:
  • M chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabGroupItemBuilderUnitTest.java
Change size: M
Delta: 1 file changed, 53 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Calder Kitagawa
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb461a2ca09521116142e34c14d586d882fe87a3
Gerrit-Change-Number: 8043934
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages