Apply EXIF orientation data in SVG feImage filters [chromium/src : main]

0 views
Skip to first unread message

Stephen Chenney (Gerrit)

unread,
3:35 PM (1 hour ago) 3:35 PM
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Philip Rogers

Stephen Chenney added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Stephen Chenney . resolved

Note the rects in the test are to indicate the filter effect region, to ensure it is correctly set for orientation. This knocks off one privacy issue.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7294d8017adc9bed617d78174dada835aa5870dc
Gerrit-Change-Number: 7883999
Gerrit-PatchSet: 1
Gerrit-Owner: Stephen Chenney <sche...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Thu, 28 May 2026 19:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
4:19 PM (1 hour ago) 4:19 PM
to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
Attention needed from Stephen Chenney

Philip Rogers added 6 comments

Commit Message
Line 7, Patchset 1 (Latest):Apply EXIF orientation data in SVG feImage filters
Philip Rogers . unresolved

Usage of this is fairly low (https://chromestatus.com/metrics/feature/timeline/popularity/5757), so this is very likely to be web compatible, as only a small percentage of the small number of feImages will have EXIF data.

How do Safari and Firefox handle this? If we are diverging from their behavior, can you file a spec issue for this?

File third_party/blink/renderer/core/svg/graphics/filters/svg_fe_image.cc
Line 280, Patchset 1 (Latest): // with different CSS properties. The filter appearannce might then vary
Philip Rogers . unresolved

nit: appearannce -> appearance

File third_party/blink/web_tests/external/wpt/css/filter-effects/feImage-orientation.tentative.html
Line 24, Patchset 1 (Latest): <rect x="10" y="10" width="100" height="100" filter="url(#f1)"/>
Philip Rogers . unresolved

nit: indentation

File third_party/blink/web_tests/external/wpt/css/filter-effects/reference/feImage-orientation-ref.html
Line 7, Patchset 1 (Latest):<link rel="help" href="https://drafts.fxtf.org/filter-effects/#feImageElement">
Philip Rogers . unresolved

update this (or remove it, as it's just a reference)

Line 22, Patchset 1 (Latest): <rect x="10" y="10" width="100" height="100" filter="url(#f1)"/>
Philip Rogers . unresolved

nit: indentation

Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Chenney
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7294d8017adc9bed617d78174dada835aa5870dc
    Gerrit-Change-Number: 7883999
    Gerrit-PatchSet: 1
    Gerrit-Owner: Stephen Chenney <sche...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 May 2026 20:19:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    4:23 PM (1 hour ago) 4:23 PM
    to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, blink-revie...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org
    Attention needed from Stephen Chenney

    Philip Rogers added 1 comment

    Commit Message
    Line 7, Patchset 1 (Latest):Apply EXIF orientation data in SVG feImage filters
    Philip Rogers . unresolved

    Usage of this is fairly low (https://chromestatus.com/metrics/feature/timeline/popularity/5757), so this is very likely to be web compatible, as only a small percentage of the small number of feImages will have EXIF data.

    How do Safari and Firefox handle this? If we are diverging from their behavior, can you file a spec issue for this?

    Philip Rogers

    Ah, I now see https://github.com/w3c/svgwg/issues/819#issuecomment-4565532924. Can we wait for this to resolve before landing this?

    Gerrit-Comment-Date: Thu, 28 May 2026 20:23:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages