Disable #enable-toolbar-swipe-on-non-desktop-lff by default [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Apr 13, 2026, 11:12:02 AM (yesterday) Apr 13
to chromium...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

Disable #enable-toolbar-swipe-on-non-desktop-lff by default
Bug: 493270994
Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a

Change diff

diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
index 644f5f9..cf048df 100644
--- a/chrome/browser/flags/android/chrome_feature_list.cc
+++ b/chrome/browser/flags/android/chrome_feature_list.cc
@@ -717,7 +717,7 @@
 BASE_FEATURE(kEnableEscapeHandlingForSecondaryActivities, base::FEATURE_DISABLED_BY_DEFAULT);
 BASE_FEATURE(kEnableSwipeToSwitchPane, base::FEATURE_DISABLED_BY_DEFAULT);
 BASE_FEATURE(kEnableToolbarPositioningInResizeMode, base::FEATURE_ENABLED_BY_DEFAULT);
-BASE_FEATURE(kEnableToolbarSwipeOnNonDesktopLff, base::FEATURE_ENABLED_BY_DEFAULT);
+BASE_FEATURE(kEnableToolbarSwipeOnNonDesktopLff, base::FEATURE_DISABLED_BY_DEFAULT);
 BASE_FEATURE(kEnableXAxisActivityTransition, base::FEATURE_DISABLED_BY_DEFAULT);
 BASE_FEATURE(kEnforceIncognitoIsolation, base::FEATURE_DISABLED_BY_DEFAULT);
 BASE_FEATURE(kEscCancelDrag, base::FEATURE_ENABLED_BY_DEFAULT);

Change information

Files:
  • M chrome/browser/flags/android/chrome_feature_list.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a
Gerrit-Change-Number: 7754606
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Apr 13, 2026, 11:13:12 AM (yesterday) Apr 13
to chromium...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a
Gerrit-Change-Number: 7754606
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 15:12:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Apr 13, 2026, 11:14:16 AM (yesterday) Apr 13
to Sirisha Kavuluru, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Attention needed from Sirisha Kavuluru

Masa Fujita added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Masa Fujita . resolved

We need to specify a minimum version to start finch experiments, which means we have to merge the fixed CL first, which means we have to disable it first.

Open in Gerrit

Related details

Attention is currently required from:
  • Sirisha Kavuluru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a
Gerrit-Change-Number: 7754606
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 15:13:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sirisha Kavuluru (Gerrit)

unread,
Apr 13, 2026, 12:31:34 PM (23 hours ago) Apr 13
to Masa Fujita, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org
Attention needed from Masa Fujita

Sirisha Kavuluru added 1 comment

File chrome/browser/flags/android/chrome_feature_list.cc
Line 720, Patchset 1 (Parent):BASE_FEATURE(kEnableToolbarSwipeOnNonDesktopLff, base::FEATURE_ENABLED_BY_DEFAULT);
Sirisha Kavuluru . unresolved

Can you add context on why we are disabling again ? We just enabled this last week?

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a
    Gerrit-Change-Number: 7754606
    Gerrit-PatchSet: 1
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Attention: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 16:31:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    Apr 13, 2026, 12:38:29 PM (23 hours ago) Apr 13
    to Sirisha Kavuluru, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org

    Masa Fujita added 1 comment

    Patchset-level comments
    Masa Fujita . resolved

    We need to specify a minimum version to start finch experiments, which means we have to merge the fixed CL first, which means we have to disable it first.

    Masa Fujita

    @skav...@google.com sorry should have tagged you here - I couldn't figure out a way to start a finch experiment on a non-merged CL. So, as soon as we merge the previous enabling CL, the feature is going to be enabled by default, which is doesn't meet the stable merge criteria. If my understanding is correct, I think we have to disable it by default (merge the this CL and the previous CL) and then gradually enable it via finch

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I99b8f7717be28d3ba11a43fd7d177889d90fb29a
    Gerrit-Change-Number: 7754606
    Gerrit-PatchSet: 1
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 16:37:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Masa Fujita <mas...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    4:47 AM (7 hours ago) 4:47 AM
    to Sirisha Kavuluru, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org

    Masa Fujita abandoned this change.

    View Change

    Abandoned

    Masa Fujita abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages