[iOS] Bump expiry of PasswordManager.BulkCheck.InsecureCredentials.Un... [chromium/src : main]

0 views
Skip to first unread message

Noémie St-Onge (Gerrit)

unread,
Jun 11, 2025, 2:24:47 PM6/11/25
to Ioana Pandele, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Ioana Pandele

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ioana Pandele
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide06d5e6b2ede788727a9d76c7ad32321b5b216f
Gerrit-Change-Number: 6638511
Gerrit-PatchSet: 3
Gerrit-Owner: Noémie St-Onge <noe...@google.com>
Gerrit-Reviewer: Ioana Pandele <ioa...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Ioana Pandele <ioa...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Jun 2025 18:24:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ioana Pandele (Gerrit)

unread,
Jun 12, 2025, 5:33:42 AM6/12/25
to Noémie St-Onge, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Noémie St-Onge

Ioana Pandele voted and added 1 comment

Votes added by Ioana Pandele

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ioana Pandele . resolved

LGTM! Although if it needs another manual bump at the end of the year, we should probably remove it.

Open in Gerrit

Related details

Attention is currently required from:
  • Noémie St-Onge
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide06d5e6b2ede788727a9d76c7ad32321b5b216f
Gerrit-Change-Number: 6638511
Gerrit-PatchSet: 3
Gerrit-Owner: Noémie St-Onge <noe...@google.com>
Gerrit-Reviewer: Ioana Pandele <ioa...@chromium.org>
Gerrit-Reviewer: Noémie St-Onge <noe...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Noémie St-Onge <noe...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 09:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Noémie St-Onge (Gerrit)

unread,
Jun 12, 2025, 9:17:09 AM6/12/25
to Ioana Pandele, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Noémie St-Onge voted and added 1 comment

Votes added by Noémie St-Onge

Commit-Queue+2

1 comment

Patchset-level comments
Ioana Pandele . resolved

LGTM! Although if it needs another manual bump at the end of the year, we should probably remove it.

Noémie St-Onge

SG! Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide06d5e6b2ede788727a9d76c7ad32321b5b216f
Gerrit-Change-Number: 6638511
Gerrit-PatchSet: 3
Gerrit-Owner: Noémie St-Onge <noe...@google.com>
Gerrit-Reviewer: Ioana Pandele <ioa...@chromium.org>
Gerrit-Reviewer: Noémie St-Onge <noe...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 13:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ioana Pandele <ioa...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 12, 2025, 9:20:38 AM6/12/25
to Noémie St-Onge, Ioana Pandele, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[iOS] Bump expiry of PasswordManager.BulkCheck.InsecureCredentials.Un...

This CL bumps the expiry of the
PasswordManager.BulkCheck.InsecureCredentials.Unmuted.Count histogram as
it is still useful to our team.
Fixed: 420443452
Change-Id: Ide06d5e6b2ede788727a9d76c7ad32321b5b216f
Reviewed-by: Ioana Pandele <ioa...@chromium.org>
Commit-Queue: Noémie St-Onge <noe...@google.com>
Cr-Commit-Position: refs/heads/main@{#1473000}
Files:
  • M tools/metrics/histograms/metadata/password/histograms.xml
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ioana Pandele
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide06d5e6b2ede788727a9d76c7ad32321b5b216f
Gerrit-Change-Number: 6638511
Gerrit-PatchSet: 4
Gerrit-Owner: Noémie St-Onge <noe...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ioana Pandele <ioa...@chromium.org>
Gerrit-Reviewer: Noémie St-Onge <noe...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages