Reland "[Reading mode] Show the omnibox immediately." [chromium/src : main]
0 views
Skip to first unread message
Lauren Winston (Gerrit)
5:38 PM (3 hours ago) 5:38 PM
to AyeAye, Chromium LUCI CQ, Kristi Saney, luci-bi...@appspot.gserviceaccount.com, chromium...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, jatapiaro+wat...@google.com
Attention needed from Kristi Saney
Lauren Winston added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lauren Winston . resolved
It passed one of the mac-vm tests. The other failed due to "invalid targets" which I think is just an infra change.
Related details
Attention is currently required from:
- Kristi Saney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kristi Saney (Gerrit)
5:46 PM (3 hours ago) 5:46 PM
to Lauren Winston, AyeAye, Chromium LUCI CQ, luci-bi...@appspot.gserviceaccount.com, chromium...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, jatapiaro+wat...@google.com
Attention needed from Lauren Winston
Kristi Saney voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lauren Winston
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lauren Winston (Gerrit)
5:46 PM (3 hours ago) 5:46 PM
to AyeAye, Chromium LUCI CQ, luci-bi...@appspot.gserviceaccount.com, chromium...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, jatapiaro+wat...@google.com
Lauren Winston voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:33 PM (2 hours ago) 6:33 PM
to Lauren Winston, Kristi Saney, AyeAye, luci-bi...@appspot.gserviceaccount.com, chromium...@chromium.org, lwinston+watc...@google.com, trewin...@google.com, jatapiaro+wat...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[Reading mode] Show the omnibox immediately."
This is a reland of commit aae17939661383de3fb820495431307f43fe0530
Original change's description:
> [Reading mode] Show the omnibox immediately.
>
> This is based on UX feedback.
>
> Bug: 462249711
> Change-Id: I52f64ff7ae07797a239e6bfd48e8f9319403f02d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7453579
> Commit-Queue: Lauren Winston <lwin...@google.com>
> Reviewed-by: Kristi Saney <krist...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1569528}
Bug: 462249711
Change-Id: Ie7265eeb7a6261cb446582cf27c0a49241d06d81
Reviewed-by: Kristi Saney <krist...@google.com>
Commit-Queue: Lauren Winston <lwin...@google.com>
Cr-Commit-Position: refs/heads/main@{#1570058}
Files:
- M chrome/browser/ui/read_anything/read_anything_side_panel_controller.cc
- M chrome/browser/ui/read_anything/read_anything_side_panel_controller.h
- M chrome/browser/ui/read_anything/read_anything_side_panel_controller_interactive_uitest.cc
Change size: M
Delta: 3 files changed, 41 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kristi Saney
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages