[iOS] Replace Symbol helper with new helpers [chromium/src : main]
1 view
Skip to first unread message
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:30:11 AM (2 days ago) Jul 22
to Jérôme Lebel, chromium...@chromium.org, feature-me...@chromium.org, chrome-regionalc...@google.com, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Jérôme Lebel
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Jérôme Lebel to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
R=jle...@chromium.org
Bug: 537673111
Change-Id: If545bbce23537cc6ae62446679c9a5c57d6e60f3
Change diff
Change information
Files:
- M ios/chrome/browser/account_picker/ui_bundled/account_picker_configuration.h
- M ios/chrome/browser/account_picker/ui_bundled/account_picker_confirmation/account_picker_confirmation_screen_view_controller.mm
- M ios/chrome/browser/search_engine_choice/ui/snippet_search_engine_button.mm
- M ios/chrome/browser/settings/ui_bundled/address_bar_preference/cells/address_bar_option_item_view.h
- M ios/chrome/browser/settings/ui_bundled/address_bar_preference/cells/address_bar_option_item_view.mm
- M ios/chrome/browser/settings/ui_bundled/address_bar_preference/cells/address_bar_options_item.mm
- M ios/chrome/browser/settings/ui_bundled/cells/enhanced_safe_browsing_inline_promo_item.mm
- M ios/chrome/browser/settings/ui_bundled/cells/inline_promo_cell.mm
- M ios/chrome/browser/settings/ui_bundled/cells/inline_promo_item_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/cells/passphrase_error_item.mm
- M ios/chrome/browser/settings/ui_bundled/elements/enterprise_info_popover_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/elements/supervised_user_info_popover_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/privacy/privacy_safe_browsing_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/privacy/safe_browsing/safe_browsing_enhanced_protection_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/privacy/safe_browsing/safe_browsing_standard_protection_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/settings_table_view_controller.mm
Change size: M
Delta: 16 files changed, 107 insertions(+), 115 deletions(-)
Related details
Attention is currently required from:
- Jérôme Lebel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:30:39 AM (2 days ago) Jul 22
to Kirubel, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Kirubel
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Kirubel to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_actor_tool_chip_view_controller.mm
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_worklog_item_showcase_view_controller.mm
Change size: S
Delta: 2 files changed, 9 insertions(+), 11 deletions(-)
Related details
Attention is currently required from:
- Kirubel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:31:12 AM (2 days ago) Jul 22
to Christian Xu, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Christian Xu to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/aim/debugger/ui/aim_debugger_view_controller.mm
- M ios/chrome/browser/first_run/omnibox_position/ui/omnibox_position_choice_view_controller.mm
Change size: S
Delta: 2 files changed, 18 insertions(+), 22 deletions(-)
Related details
Attention is currently required from:
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:31:39 AM (2 days ago) Jul 22
to Rohit Rao, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org
Attention needed from Rohit Rao
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Rohit Rao to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/alert_view/ui_bundled/alert_view_controller.mm
- M ios/chrome/browser/catalogs/ui/button_catalog_view_controller.mm
- M ios/chrome/browser/catalogs/ui/table_cell_catalog_view_controller.mm
- M ios/chrome/browser/scanner/ui_bundled/scanner_view.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_detail_icon_item.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_detail_icon_item_unittest.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_detail_text_item.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_item_unittest.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_multi_line_text_edit_item.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_text_button_item.mm
- M ios/chrome/browser/shared/ui/table_view/cells/table_view_text_edit_item.mm
- M ios/chrome/browser/shared/ui/table_view/content_configuration/info_button_content_view.mm
- M ios/chrome/browser/sharing/ui_bundled/qr_generator/qr_generator_view_controller.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/adaptive_toolbar_mediator.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/banner_promo_view.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/buttons/legacy_toolbar_button_factory.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/buttons/toolbar_button_unittest.mm
- M ios/chrome/browser/unit_conversion/ui_bundled/unit_conversion_view_controller.mm
- M ios/chrome/browser/unit_conversion/ui_bundled/unit_type_cell.mm
- M ios/chrome/browser/youtube_incognito/ui/youtube_incognito_enterprise_sheet.mm
- M ios/chrome/browser/youtube_incognito/ui/youtube_incognito_sheet.mm
Change size: M
Delta: 21 files changed, 73 insertions(+), 87 deletions(-)
Related details
Attention is currently required from:
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:32:17 AM (2 days ago) Jul 22
to Eric Ekey, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Eric Ekey
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Eric Ekey to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/app_bar/ui/app_bar_view_controller.mm
- M ios/chrome/browser/toolbar/ui/buttons/toolbar_button_factory.mm
- M ios/chrome/browser/toolbar/ui/buttons/toolbar_button_menu_factory.mm
- M ios/chrome/browser/toolbar/ui/buttons/toolbar_tab_grid_badge_button.mm
Change size: M
Delta: 4 files changed, 34 insertions(+), 59 deletions(-)
Related details
Attention is currently required from:
- Eric Ekey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:32:46 AM (2 days ago) Jul 22
to Jood Hajeer, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Jood Hajeer
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Jood Hajeer to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/authentication/account_menu/ui/account_menu_view_controller.mm
- M ios/chrome/browser/settings/manage_sync/coordinator/manage_sync_settings_mediator.mm
- M ios/chrome/browser/shared/ui/util/identity_snackbar/identity_snackbar_utils.mm
Change size: S
Delta: 3 files changed, 19 insertions(+), 20 deletions(-)
Related details
Attention is currently required from:
- Jood Hajeer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:33:15 AM (2 days ago) Jul 22
to Mihai Sardarescu, chromium...@chromium.org, dullweb...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Mihai Sardarescu
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Mihai Sardarescu to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/authentication/age_mismatch_signout/age_mismatch_learn_more/ui/age_mismatch_learn_more_view_controller.mm
- M ios/chrome/browser/authentication/enterprise/managed_profile_creation/ui/browsing_data_migration_view_controller.mm
- M ios/chrome/browser/authentication/enterprise/managed_profile_creation/ui/managed_profile_learn_more_view_controller.mm
- M ios/chrome/browser/authentication/fullscreen_signin_screen/ui/fullscreen_signin_screen_view_controller.mm
- M ios/chrome/browser/authentication/ui_bundled/cells/central_account_view.mm
- M ios/chrome/browser/authentication/ui_bundled/cells/signin_promo_view.mm
- M ios/chrome/browser/authentication/ui_bundled/cells/table_view_account_item.mm
- M ios/chrome/browser/authentication/ui_bundled/re_signin_infobar_delegate.mm
- M ios/chrome/browser/authentication/ui_bundled/views/identity_view.mm
Change size: S
Delta: 9 files changed, 19 insertions(+), 21 deletions(-)
Related details
Attention is currently required from:
- Mihai Sardarescu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:33:44 AM (2 days ago) Jul 22
to Cheick Cisse, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Cheick Cisse
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Cheick Cisse to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm b/ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm
index a1d4ddf9..e476e5e 100644
--- a/ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm
+++ b/ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm
@@ -151,9 +151,9 @@
#if BUILDFLAG(IOS_USE_BRANDED_ASSETS)
UIImage* icon = MakeSymbolMulticolor(
- CustomSymbolWithPointSize(kMulticolorChromeballSymbol, kLogoSize));
+ SymbolWithPointSize(SymbolMulticolorChromeball, kLogoSize));
#else
- UIImage* icon = CustomSymbolWithPointSize(kChromeProductSymbol, kLogoSize);
+ UIImage* icon = SymbolWithPointSize(SymbolChromeProduct, kLogoSize);
#endif // BUILDFLAG(IOS_USE_BRANDED_ASSETS)
NSString* subtitle;
Change information
Files:
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Cheick Cisse
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:34:21 AM (2 days ago) Jul 22
to Leo Zhao, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Leo Zhao
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Leo Zhao to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/atmemory/test/fake_at_memory_search_provider.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_no_data_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_query_unsupported_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_recent_fills_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_search_result_item.h
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_search_results_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_search_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/ui/at_memory_view_controller.mm
- M ios/chrome/browser/autofill/atmemory/utils/atmemory_ui_util.h
- M ios/chrome/browser/autofill/atmemory/utils/atmemory_ui_util.mm
- M ios/chrome/browser/settings/autofill/autofill_ai/ui/autofill_ai_add_entities_menu_builder.mm
- M ios/chrome/browser/settings/autofill/autofill_ai/ui/autofill_ai_entity_country_item.mm
Change size: M
Delta: 12 files changed, 27 insertions(+), 35 deletions(-)
Related details
Attention is currently required from:
- Leo Zhao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:34:49 AM (2 days ago) Jul 22
to Alexis Hétu, chromium...@chromium.org, rkgibso...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Alexis Hétu
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Alexis Hétu to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/autofill_ai/public/autofill_ai_ui_util.mm
- M ios/chrome/browser/autofill/bnpl/ui/autofill_bnpl_tos_mediator.mm
- M ios/chrome/browser/autofill/bnpl/ui/autofill_bnpl_tos_mediator_unittest.mm
- M ios/chrome/browser/autofill/form_input_accessory/ui/form_input_accessory_view_controller.mm
- M ios/chrome/browser/autofill/form_input_accessory/ui/form_suggestion_label.mm
- M ios/chrome/browser/autofill/payments/ui/credit_card_suggestion_bottom_sheet_view_controller.mm
- M ios/chrome/browser/autofill/scan_save_and_fill/ui/payments_scan_save_and_fill_edit_view_controller.mm
- M ios/chrome/browser/autofill/scan_save_and_fill/ui/payments_scan_save_and_fill_offer_bottom_sheet_view_controller.mm
- M ios/chrome/browser/credential_provider/model/ios_credential_provider_infobar_delegate.mm
Change size: M
Delta: 9 files changed, 54 insertions(+), 79 deletions(-)
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:35:23 AM (2 days ago) Jul 22
to Noémie St-Onge, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Noémie St-Onge
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Noémie St-Onge to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/manual_fill/ui/expanded_manual_fill_view_controller.mm
- M ios/chrome/browser/autofill/manual_fill/ui/manual_fill_card_cell.mm
- M ios/chrome/browser/autofill/manual_fill/ui/manual_fill_cell_utils.mm
Change size: S
Delta: 3 files changed, 13 insertions(+), 17 deletions(-)
Related details
Attention is currently required from:
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:35:54 AM (2 days ago) Jul 22
to Olivier Robin, chromium...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, filesapp...@chromium.org, marq+...@chromium.org
Attention needed from Olivier Robin
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Olivier Robin to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/model/autofill_ai_prefetch_failure_infobar_delegate_ios.mm
- M ios/chrome/browser/autofill/model/form_suggestion_controller.mm
- M ios/chrome/browser/context_menu/ui_bundled/context_menu_configuration_provider.mm
- M ios/chrome/browser/context_menu/ui_bundled/image_preview_view_controller.mm
- M ios/chrome/browser/download/ui/auto_deletion/auto_deletion_iph_view_controller.mm
- M ios/chrome/browser/download/ui/download_list/download_filter_cell.mm
- M ios/chrome/browser/download/ui/download_list/download_list_table_view_controller.mm
- M ios/chrome/browser/download/ui/download_manager_state_view.mm
- M ios/chrome/browser/download/ui/download_manager_view_controller.mm
- M ios/chrome/browser/drive/model/drive_list.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_cell_content_configuration.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_empty_view.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_item.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_table_view_controller.mm
- M ios/chrome/browser/partial_translate/ui_bundled/partial_translate_mediator.mm
- M ios/chrome/browser/reading_list/ui_bundled/reading_list_table_view_item.mm
- M ios/chrome/browser/reading_list/ui_bundled/reading_list_toolbar_button_manager.mm
- M ios/chrome/browser/save_to_photos/ui_bundled/save_to_photos_mediator.mm
- M ios/chrome/browser/search_with/ui_bundled/search_with_mediator.mm
Change size: M
Delta: 19 files changed, 107 insertions(+), 124 deletions(-)
Related details
Attention is currently required from:
- Olivier Robin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:36:22 AM (2 days ago) Jul 22
to Vidhan Jain, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Vidhan Jain
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Vidhan Jain to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_country_selection_table_view_controller.mm
- M ios/chrome/browser/infobars/ui_bundled/modals/autofill_address_profile/infobar_save_address_profile_view_controller.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/autofill_address_profile/save_address_profile_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/autofill_address_profile/save_address_profile_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_profile_table_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_settings_profile_edit_table_view_controller.mm
Change size: M
Delta: 6 files changed, 27 insertions(+), 31 deletions(-)
Related details
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel (Gerrit)
Jul 22, 2026, 10:36:53 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Kirubel voted![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:36:54 AM (2 days ago) Jul 22
to Slobodan Pejic, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, sloboda...@chromium.org, marq+...@chromium.org
Attention needed from Slobodan Pejic
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Slobodan Pejic to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/ui_bundled/bottom_sheet/save_card_bottom_sheet_view_controller.mm
- M ios/chrome/browser/autofill/ui_bundled/bottom_sheet/virtual_card_enrollment_bottom_sheet_view_controller.mm
Change size: S
Delta: 2 files changed, 17 insertions(+), 18 deletions(-)
Related details
Attention is currently required from:
- Slobodan Pejic
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:37:22 AM (2 days ago) Jul 22
to Sebastien S-G, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien S-G
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Sebastien S-G to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/autofill/ui_bundled/branding/branding_view_controller.mm
- M ios/chrome/browser/autofill/ui_bundled/cells/card_unmask_header_item.mm
- M ios/chrome/browser/autofill/ui_bundled/cells/target_account_item.mm
- M ios/chrome/browser/link_to_text/ui_bundled/link_to_text_mediator.mm
Change size: S
Delta: 4 files changed, 15 insertions(+), 15 deletions(-)
Related details
Attention is currently required from:
- Sebastien S-G
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:37:54 AM (2 days ago) Jul 22
to Sergio Collazos, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, knollr+wat...@chromium.org, sloboda...@chromium.org, marq+...@chromium.org
Attention needed from Sergio Collazos
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Sergio Collazos to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/badges/ui_bundled/badge_button_factory.mm
- M ios/chrome/browser/badges/ui_bundled/badge_overflow_menu_util.mm
- M ios/chrome/browser/infobars/ui_bundled/banners/infobar_banner_view_controller.mm
- M ios/chrome/browser/infobars/ui_bundled/modals/infobar_password_container_view_controller.mm
- M ios/chrome/browser/infobars/ui_bundled/modals/infobar_password_table_view_controller.mm
- M ios/chrome/browser/infobars/ui_bundled/modals/infobar_save_card_table_view_controller.mm
- M ios/chrome/browser/recent_tabs/ui/recent_tabs_table_view_controller.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/bookmark_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/copy_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/find_in_page_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/generate_qr_code_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/print_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/reading_list_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/request_desktop_or_mobile_site_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activities/send_tab_to_self_activity.mm
- M ios/chrome/browser/sharing/ui_bundled/activity_services/activity_service_coordinator.mm
Change size: M
Delta: 16 files changed, 65 insertions(+), 76 deletions(-)
Related details
Attention is currently required from:
- Sergio Collazos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:38:24 AM (2 days ago) Jul 22
to Tanmoy Mollik, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Tanmoy Mollik
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Tanmoy Mollik to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/bookmarks/folder_chooser/ui/table_view_bookmarks_folder_item.mm
- M ios/chrome/browser/bookmarks/ui_bundled/cells/bookmark_parent_folder_item.mm
- M ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_mediator.mm
- M ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_node_item.mm
- M ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_view_controller.mm
Change size: S
Delta: 5 files changed, 9 insertions(+), 11 deletions(-)
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:38:51 AM (2 days ago) Jul 22
to Scott Yoder, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Scott Yoder to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm b/ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm
index 3458a04..4084cb8 100644
--- a/ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm
+++ b/ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm
@@ -275,7 +275,7 @@
if ([self isBookmarkedPage]) {
newTitle =
l10n_util::GetNSStringWithFixup(IDS_IOS_KEYBOARD_EDIT_BOOKMARK);
- command.image = DefaultSymbolWithConfiguration(kPencilSymbol, nil);
+ command.image = SymbolWithConfiguration(SymbolPencil, nil);
}
}
// If a new title was determined, set it on the command.
diff --git a/ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm b/ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm
index d8d3926..7cfa3bd 100644
--- a/ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm
+++ b/ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm
@@ -70,7 +70,7 @@
// Configure image.
self.image = SymbolWithPalette(
- DefaultSymbolWithPointSize(kBellBadgeSymbol, kBellBadgeSymbolPointSize),
+ SymbolWithPointSize(SymbolBellBadge, kBellBadgeSymbolPointSize),
@[ [UIColor whiteColor] ]);
self.imageBackgroundColor = [UIColor colorNamed:kBlue500Color];
self.imageViewAccessibilityLabel = kBellIconAccessibilityLabel;
Change information
Files:
- M ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm
- M ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:39:22 AM (2 days ago) Jul 22
to Ginny Huang, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Ginny Huang
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ginny Huang to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/bubble/ui_bundled/bubble_view.mm
- M ios/chrome/browser/content_suggestions/magic_stack/ui/magic_stack_context_menu_interaction_handler.mm
- M ios/chrome/browser/content_suggestions/magic_stack/ui/magic_stack_edit_button_cell.mm
- M ios/chrome/browser/content_suggestions/most_visited_tiles/ui/most_visited_tile_view.mm
- M ios/chrome/browser/content_suggestions/send_tab_to_self/ui/send_tab_promo_config.mm
- M ios/chrome/browser/content_suggestions/set_up_list/ui/set_up_list_item_icon.mm
- M ios/chrome/browser/content_suggestions/ui/cells/content_suggestions_tile_constants.mm
- M ios/chrome/browser/content_suggestions/ui/cells/icon_detail_view.mm
- M ios/chrome/browser/content_suggestions/ui/cells/standalone_module_view_unittest.mm
- M ios/chrome/browser/content_suggestions/ui/content_suggestions_collection_utils.mm
- M ios/chrome/browser/data_import/ui/data_import_credential_conflict_resolution_view_controller.mm
- M ios/chrome/browser/data_import/ui/import_data_item_table_view.mm
Change size: M
Delta: 12 files changed, 80 insertions(+), 87 deletions(-)
Related details
Attention is currently required from:
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:39:46 AM (2 days ago) Jul 22
to Radu Nitescu, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Radu Nitescu
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Radu Nitescu to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/cobrowse/debugger/aim_srp_debugger_breadcrumbs_view_controller.mm
- M ios/chrome/browser/cobrowse/debugger/aim_srp_debugger_url_view_controller.mm
- M ios/chrome/browser/cobrowse/ui/assistant_aim_header_view.mm
Change size: S
Delta: 3 files changed, 17 insertions(+), 18 deletions(-)
Related details
Attention is currently required from:
- Radu Nitescu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:40:16 AM (2 days ago) Jul 22
to Siddhartha S, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Siddhartha S
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Siddhartha S to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm b/ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm
index 6895b2fa..9d8f5d5 100644
--- a/ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm
+++ b/ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm
@@ -699,7 +699,7 @@
ShareKitPreviewItem* preview_item = [[ShareKitPreviewItem alloc] init];
preview_item.title = base::SysUTF8ToNSString(tabs[i].url.GetHost());
preview_item.image = SymbolWithPalette(
- DefaultSymbolWithPointSize(kGlobeAmericasSymbol, kFaviconSize),
+ SymbolWithPointSize(SymbolGlobeAmericas, kFaviconSize),
@[ [UIColor colorNamed:kGrey400Color] ]);
[preview_items addObject:preview_item];
}
diff --git a/ios/chrome/browser/collaboration/model/messaging/infobar/collaboration_out_of_date_infobar_delegate.mm b/ios/chrome/browser/collaboration/model/messaging/infobar/collaboration_out_of_date_infobar_delegate.mm
index 14c3b9db..b017d7d9 100644
--- a/ios/chrome/browser/collaboration/model/messaging/infobar/collaboration_out_of_date_infobar_delegate.mm
+++ b/ios/chrome/browser/collaboration/model/messaging/infobar/collaboration_out_of_date_infobar_delegate.mm
@@ -82,6 +82,6 @@
ui::ImageModel CollaborationOutOfDateInfoBarDelegate::GetIcon() const {
UIImage* symbolImage =
- DefaultSymbolWithPointSize(kTabGroupsSymbol, kInfobarSymbolPointSize);
+ SymbolWithPointSize(SymbolTabGroups, kInfobarSymbolPointSize);
return ui::ImageModel::FromImage(gfx::Image(symbolImage));
}
Change information
Files:
- M ios/chrome/browser/collaboration/model/ios_collaboration_controller_delegate.mm
- M ios/chrome/browser/collaboration/model/messaging/infobar/collaboration_out_of_date_infobar_delegate.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:40:45 AM (2 days ago) Jul 22
to Stepan Khapugin, chromium...@chromium.org, ios-r...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, roagarw...@chromium.org
Attention needed from Stepan Khapugin
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Stepan Khapugin to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/composebox/debugger/composebox_debugger_coordinator.mm
- M ios/chrome/browser/composebox/menu/ui/composebox_menu_shared_tabs_view_controller.mm
- M ios/chrome/browser/composebox/menu/ui/composebox_menu_view_controller.mm
- M ios/chrome/browser/composebox/ui/composebox_favicons_accordion_view.mm
- M ios/chrome/browser/composebox/ui/composebox_input_item_cell.mm
- M ios/chrome/browser/composebox/ui/composebox_input_item_view.mm
- M ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm
- M ios/chrome/browser/composebox/ui/composebox_view_controller.mm
- M ios/chrome/browser/incognito_reauth/ui_bundled/incognito_reauth_view.mm
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_steady_view.mm
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_view_controller.mm
- M ios/chrome/browser/omnibox/ui/popup/omnibox_icon_view.mm
- M ios/chrome/browser/omnibox/ui/popup/omnibox_popup_view_controller.mm
- M ios/chrome/browser/omnibox/ui/popup/row/omnibox_popup_row_trailing_button.mm
- M ios/chrome/browser/spotlight_debugger/ui_bundled/spotlight_debugger_view_controller.mm
Change size: L
Delta: 15 files changed, 121 insertions(+), 145 deletions(-)
Related details
Attention is currently required from:
- Stepan Khapugin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:41:16 AM (2 days ago) Jul 22
to David Maunder, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like David Maunder to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/content_suggestions/price_tracking_promo/ui/price_tracking_promo_config.mm b/ios/chrome/browser/content_suggestions/price_tracking_promo/ui/price_tracking_promo_config.mm
index 1344c166..081daf69 100644
--- a/ios/chrome/browser/content_suggestions/price_tracking_promo/ui/price_tracking_promo_config.mm
+++ b/ios/chrome/browser/content_suggestions/price_tracking_promo/ui/price_tracking_promo_config.mm
@@ -49,7 +49,7 @@
}
- (UIImage*)fallbackSymbolImage {
- return CustomSymbolWithPointSize(kDownTrendSymbol, kFallbackSymbolSize);
+ return SymbolWithPointSize(SymbolDownTrend, kFallbackSymbolSize);
}
- (NSString*)titleText {
Change information
Files:
- M ios/chrome/browser/content_suggestions/price_tracking_promo/ui/price_tracking_promo_config.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- David Maunder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:41:47 AM (2 days ago) Jul 22
to Gloria Fang, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Gloria Fang
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Gloria Fang to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/content_suggestions/shop_card/ui/shop_card_view.mm b/ios/chrome/browser/content_suggestions/shop_card/ui/shop_card_view.mm
index f54c2218..34aa8567 100644
--- a/ios/chrome/browser/content_suggestions/shop_card/ui/shop_card_view.mm
+++ b/ios/chrome/browser/content_suggestions/shop_card/ui/shop_card_view.mm
@@ -318,7 +318,7 @@
}
- (UIImage*)makeDefaultFaviconUIImage {
- return DefaultSymbolWithPointSize(kGlobeAmericasSymbol, kCenterSymbolSize);
+ return SymbolWithPointSize(SymbolGlobeAmericas, kCenterSymbolSize);
}
- (void)addFaviconImageAndContainer:(UIImage*)faviconImage {
Change information
Files:
- M ios/chrome/browser/content_suggestions/shop_card/ui/shop_card_view.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Gloria Fang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:42:16 AM (2 days ago) Jul 22
to Ewann Pellé, chromium...@chromium.org, dtraino...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ewann Pellé to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/content_suggestions/tab_resumption/ui/tab_resumption_config_unittest.mm
- M ios/chrome/browser/content_suggestions/tab_resumption/ui/tab_resumption_view.mm
- M ios/chrome/browser/download/coordinator/activities/open_downloads_folder_activity.mm
- M ios/chrome/browser/saved_tab_groups/favicon/coordinator/tab_group_favicons_grid_configurator.mm
- M ios/chrome/browser/saved_tab_groups/ui/face_pile_view.mm
- M ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_new_tab_button.swift
- M ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_tab_cell.mm
- M ios/chrome/browser/tab_switcher/tab_strip/ui/tab_strip_tab_item.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/pinned_tabs/pinned_item.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_snapshot_and_favicon_configurator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/web_state_tab_switcher_item.mm
Change size: M
Delta: 11 files changed, 27 insertions(+), 29 deletions(-)
Related details
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:42:48 AM (2 days ago) Jul 22
to Robbie Gibson, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Robbie Gibson
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Robbie Gibson to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/contextual_panel/entrypoint/ui/contextual_panel_entrypoint_view_controller.mm
- M ios/chrome/browser/contextual_panel/model/contextual_panel_item_configuration.h
- M ios/chrome/browser/contextual_panel/sample/model/sample_panel_model.mm
- M ios/chrome/browser/contextual_panel/ui/panel_content_view_controller.mm
- M ios/chrome/browser/default_browser/promo/tailored/ui/base_default_browser_promo_view_provider.mm
- M ios/chrome/browser/home_customization/ui/home_customization_background_photo_framing_view_controller.mm
- M ios/chrome/browser/home_customization/ui/home_customization_background_picker_cell.mm
- M ios/chrome/browser/home_customization/ui/home_customization_custom_color_cell.mm
- M ios/chrome/browser/home_customization/ui/home_customization_enterprise_policy_cell.mm
- M ios/chrome/browser/home_customization/ui/home_customization_link_cell.mm
- M ios/chrome/browser/home_customization/ui/home_customization_main_view_controller.mm
- M ios/chrome/browser/home_customization/ui/home_customization_toggle_cell.mm
- M ios/chrome/browser/home_customization/utils/home_customization_helper.mm
- M ios/chrome/browser/level_up/coordinator/level_up_task.h
- M ios/chrome/browser/level_up/coordinator/level_up_task.mm
- M ios/chrome/browser/level_up/model/task_info.h
- M ios/chrome/browser/level_up/model/tasks/ai_search_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/autofill_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/camera_search_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/gemini_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/incognito_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/lens_search_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/password_checkup_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/payment_methods_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/pin_tabs_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/quick_delete_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/safe_browsing_task_info.mm
- M ios/chrome/browser/level_up/model/tasks/tab_groups_task_info.mm
- M ios/chrome/browser/level_up/ui/level_up_progress_view.mm
- M ios/chrome/browser/level_up/ui/level_up_task_row_view.mm
- M ios/chrome/browser/level_up/ui/level_up_view_controller.mm
- M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_mediator.mm
- M ios/chrome/browser/whats_new/ui/cells/whats_new_table_view_item_unittest.mm
Change size: M
Delta: 33 files changed, 76 insertions(+), 67 deletions(-)
Related details
Attention is currently required from:
- Robbie Gibson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:43:24 AM (2 days ago) Jul 22
to Sourav Uttam Sinha, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Sourav Uttam Sinha
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Sourav Uttam Sinha to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/credential_exchange/ui/credential_export_view_controller.mm b/ios/chrome/browser/credential_exchange/ui/credential_export_view_controller.mm
index 13c1b9b..aa8fb9e 100644
--- a/ios/chrome/browser/credential_exchange/ui/credential_export_view_controller.mm
+++ b/ios/chrome/browser/credential_exchange/ui/credential_export_view_controller.mm
@@ -331,7 +331,7 @@
// Creates the menu button for the toolbar.
- (UIBarButtonItem*)createExportMenuButton {
UIImage* icon =
- DefaultSymbolTemplateWithPointSize(kMenuSymbol, kSymbolActionPointSize);
+ SymbolTemplateWithPointSize(SymbolMenu, kSymbolActionPointSize);
UIBarButtonItem* button =
[[UIBarButtonItem alloc] initWithImage:icon
@@ -347,15 +347,15 @@
- (UIMenu*)createExportMenuEnabled:(BOOL)enabled {
__weak __typeof(self) weakSelf = self;
- UIAction* exportAction = [UIAction
- actionWithTitle:l10n_util::GetNSString(
- IDS_IOS_EXPORT_PASSWORDS_DOWNLOAD_CSV)
- image:DefaultSymbolWithPointSize(kArrowDownToLineSymbol,
- kSymbolActionPointSize)
- identifier:nil
- handler:^(UIAction* action) {
- [weakSelf didTapExportCSV];
- }];
+ UIAction* exportAction =
+ [UIAction actionWithTitle:l10n_util::GetNSString(
+ IDS_IOS_EXPORT_PASSWORDS_DOWNLOAD_CSV)
+ image:SymbolWithPointSize(SymbolArrowDownToLine,
+ kSymbolActionPointSize)
+ identifier:nil
+ handler:^(UIAction* action) {
+ [weakSelf didTapExportCSV];
+ }];
if (!enabled) {
exportAction.attributes = UIMenuElementAttributesDisabled;
Change information
Files:
- M ios/chrome/browser/credential_exchange/ui/credential_export_view_controller.mm
Change size: S
Delta: 1 file changed, 10 insertions(+), 10 deletions(-)
Related details
Attention is currently required from:
- Sourav Uttam Sinha
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:43:48 AM (2 days ago) Jul 22
to Quentin Pubert, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Quentin Pubert
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Quentin Pubert to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_coordinator.mm
- M ios/chrome/browser/reader_mode/model/constants.h
- M ios/chrome/browser/reader_mode/model/constants.mm
- M ios/chrome/browser/reader_mode/model/reader_mode_panel_item_configuration.mm
- M ios/chrome/browser/reader_mode/ui/reader_mode_chip_view_controller.mm
Change size: S
Delta: 5 files changed, 20 insertions(+), 9 deletions(-)
Related details
Attention is currently required from:
- Quentin Pubert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cheick Cisse (Gerrit)
Jul 22, 2026, 10:43:50 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Cheick Cisse voted and added 1 comment![]( "Open in Gerrit")
Votes added by Cheick Cisse
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:44:19 AM (2 days ago) Jul 22
to Briana McClure, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Briana McClure to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/first_run/best_features/coordinator/best_features_screen_detail_coordinator.mm
- M ios/chrome/browser/first_run/best_features/ui/best_features_view_controller.mm
- M ios/chrome/browser/first_run/public/best_features_item.mm
- M ios/chrome/browser/welcome_back/ui/welcome_back_view_controller.mm
Change size: S
Delta: 4 files changed, 14 insertions(+), 14 deletions(-)
Related details
Attention is currently required from:
- Briana McClure
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:44:49 AM (2 days ago) Jul 22
to Adam Arcaro, chromium...@chromium.org, thegreenf...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Adam Arcaro to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/intelligence/bwg/model/gemini_tab_helper.mm
- M ios/chrome/browser/intelligence/bwg/model/gemini_utils.mm
- M ios/chrome/browser/intelligence/explain_with_gemini/coordinator/explain_with_gemini_mediator.mm
- M ios/chrome/browser/location_bar/badge/coordinator/location_bar_badge_mediator.mm
- M ios/chrome/browser/location_bar/badge/ui/location_bar_badge_view_controller.mm
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/notifications_promo_view.mm
Change size: M
Delta: 6 files changed, 13 insertions(+), 49 deletions(-)
Related details
Attention is currently required from:
- Adam Arcaro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:45:16 AM (2 days ago) Jul 22
to Francis Beauchamp, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Francis Beauchamp
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Francis Beauchamp to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/intelligence/bwg/ui/gemini_consent_accordion_view.mm
- M ios/chrome/browser/intelligence/bwg/ui/gemini_consent_configuration.mm
- M ios/chrome/browser/intelligence/bwg/ui/gemini_promo_view_controller.mm
- M ios/chrome/browser/intelligence/bwg/ui/gemini_ui_utils.mm
Change size: M
Delta: 4 files changed, 42 insertions(+), 45 deletions(-)
Related details
Attention is currently required from:
- Francis Beauchamp
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:45:45 AM (2 days ago) Jul 22
to Nicolas MacBeth, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Nicolas MacBeth
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Nicolas MacBeth to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator.mm
- M ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_content_entry_point.mm
- M ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_entrypoint_view.mm
- M ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_view_controller.mm
Change size: M
Delta: 4 files changed, 36 insertions(+), 38 deletions(-)
Related details
Attention is currently required from:
- Nicolas MacBeth
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:46:13 AM (2 days ago) Jul 22
to Louis Romero, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Louis Romero
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Louis Romero to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/keyboard/ui_bundled/UIKeyCommand+Chrome.mm
Change size: M
Delta: 1 file changed, 29 insertions(+), 34 deletions(-)
Related details
Attention is currently required from:
- Louis Romero
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:46:41 AM (2 days ago) Jul 22
to Ameur Hosni, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Ameur Hosni
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ameur Hosni to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/lens_overlay/model/lens_overlay_overflow_menu_factory.mm
- M ios/chrome/browser/lens_overlay/ui/lens_overlay_consent_view_controller.mm
- M ios/chrome/browser/lens_overlay/ui/lens_overlay_entrypoint_view.mm
- M ios/chrome/browser/lens_overlay/ui/lens_result_page_view_controller.mm
Change size: S
Delta: 4 files changed, 12 insertions(+), 13 deletions(-)
Related details
Attention is currently required from:
- Ameur Hosni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:47:09 AM (2 days ago) Jul 22
to Sebastien Lalancette, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien Lalancette
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Sebastien Lalancette to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/menu/ui_bundled/action_factory.mm
- M ios/chrome/browser/menu/ui_bundled/action_factory_unittest.mm
- M ios/chrome/browser/menu/ui_bundled/browser_action_factory.mm
- M ios/chrome/browser/menu/ui_bundled/browser_action_factory_unittest.mm
Change size: L
Delta: 4 files changed, 182 insertions(+), 195 deletions(-)
Related details
Attention is currently required from:
- Sebastien Lalancette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:47:41 AM (2 days ago) Jul 22
to Chris Lu, chromium...@chromium.org, thegreenf...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, sloboda...@chromium.org, marq+...@chromium.org
Attention needed from Chris Lu
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Chris Lu to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/ntp/ui_bundled/incognito/incognito_view.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_header_view.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_quick_actions_view_controller.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_redesign_view_controller.mm
- M ios/chrome/browser/ntp/ui_bundled/ntp_identity_disc_button.mm
- M ios/chrome/browser/ntp/ui_bundled/ntp_tools_menu_button.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/permissions/permissions_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/safe_browsing/enhanced_safe_browsing_infobar_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/save_card/save_card_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/save_cvc/save_cvc_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/sync_error_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/tailored_security/tailored_security_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/tailored_security/tailored_security_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/translate/translate_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/translate/translate_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/overscroll_actions/ui_bundled/overscroll_actions_view.mm
Change size: M
Delta: 16 files changed, 58 insertions(+), 63 deletions(-)
Related details
Attention is currently required from:
- Chris Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:48:08 AM (2 days ago) Jul 22
to Ryan Akiyama, chromium...@chromium.org, ios-r...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Ryan Akiyama
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ryan Akiyama to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/omnibox/debugger/autocomplete_match_cell.mm
- M ios/chrome/browser/omnibox/debugger/omnibox_remote_suggestion_event_view_controller.mm
- M ios/chrome/browser/omnibox/model/placeholder_service/placeholder_service.mm
- M ios/chrome/browser/omnibox/model/placeholder_service/placeholder_service_unittest.mm
- M ios/chrome/browser/omnibox/model/suggestions/omnibox_pedal_annotator.mm
- M ios/chrome/browser/omnibox/model/suggestions/suggest_action.mm
- M ios/chrome/browser/omnibox/public/omnibox_suggestion_icon_util.mm
- M ios/chrome/browser/omnibox/public/omnibox_util.mm
- M ios/chrome/browser/omnibox/ui/keyboard_assist/omnibox_assistive_keyboard_views_utils.mm
- M ios/chrome/browser/omnibox/ui/keyboard_assist/omnibox_input_assistant_items.mm
- M ios/chrome/browser/omnibox/ui/omnibox_container_view.mm
- M ios/chrome/browser/omnibox/ui/omnibox_thumbnail_button.mm
Change size: M
Delta: 12 files changed, 58 insertions(+), 77 deletions(-)
Related details
Attention is currently required from:
- Ryan Akiyama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:48:39 AM (2 days ago) Jul 22
to Vincent Boisselle, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Vincent Boisselle
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Vincent Boisselle to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/passwords/password_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/passwords/password_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/passwords/bottom_sheet/coordinator/credential_suggestion_bottom_sheet_mediator.mm
- M ios/chrome/browser/passwords/bottom_sheet/coordinator/passkey_suggestion_bottom_sheet_mediator.mm
- M ios/chrome/browser/passwords/bottom_sheet/ui/credential_suggestion_bottom_sheet_view_controller.mm
- M ios/chrome/browser/passwords/password_suggestion/ui/password_suggestion_utils.mm
- M ios/chrome/browser/passwords/password_suggestion/ui/password_suggestion_view_controller.mm
Change size: S
Delta: 7 files changed, 19 insertions(+), 21 deletions(-)
Related details
Attention is currently required from:
- Vincent Boisselle
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robbie Gibson (Gerrit)
Jul 22, 2026, 10:49:02 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Gauthier Ambard
Robbie Gibson added 6 comments![]( "Open in Gerrit")
File ios/chrome/browser/contextual_panel/model/contextual_panel_item_configuration.h
Line 77, Patchset 1 (Latest):
std::string entrypoint_image_name;Robbie Gibson . unresolved
this can probably be deleted now
File ios/chrome/browser/level_up/coordinator/level_up_task.h
Line 35, Patchset 1 (Latest):
@property(nonatomic, assign, readonly) BOOL isCustomSymbol;Robbie Gibson . unresolved
this too
Line 32, Patchset 1 (Latest):
@property(nonatomic, copy, readonly) NSString* iconSymbolName;Robbie Gibson . unresolved
this can probably be deleted now
Line 26, Patchset 1 (Latest):
#import "ios/chrome/browser/shared/ui/symbols/symbol_enums.h"Robbie Gibson . unresolved
move this to the top of the file
File ios/chrome/browser/level_up/model/task_info.h
Line 37, Patchset 1 (Latest):
virtual bool IsCustomSymbol() const = 0;Robbie Gibson . unresolved
probably delete
Line 34, Patchset 1 (Latest):
virtual std::string GetIconSymbolName() const = 0;Robbie Gibson . unresolved
probably delete
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:49:07 AM (2 days ago) Jul 22
to Filipa Senra, Permissions Reviews, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Filipa Senra
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Filipa Senra to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/page_info/coordinator/page_info_site_security_mediator.mm
- M ios/chrome/browser/page_info/ui/page_info_view_controller.mm
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_browsing_data/ui/quick_delete_browsing_data_view_controller.mm
- M ios/chrome/browser/settings/clear_browsing_data/quick_delete_other_data/ui/quick_delete_other_data_view_controller.mm
- M ios/chrome/browser/settings/clear_browsing_data/ui/pop_up_menu_control.mm
- M ios/chrome/browser/settings/clear_browsing_data/ui/quick_delete_view_controller.mm
Change size: M
Delta: 6 files changed, 30 insertions(+), 36 deletions(-)
Related details
Attention is currently required from:
- Filipa Senra
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:49:36 AM (2 days ago) Jul 22
to Maria Kazinova, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Maria Kazinova
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Maria Kazinova to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/passwords/model/notify_auto_signin_view_controller.mm b/ios/chrome/browser/passwords/model/notify_auto_signin_view_controller.mm
index 588ebdc..98a0163c 100644
--- a/ios/chrome/browser/passwords/model/notify_auto_signin_view_controller.mm
+++ b/ios/chrome/browser/passwords/model/notify_auto_signin_view_controller.mm
@@ -120,7 +120,7 @@
// Load the placeholder user's avatar.
UIImage* placeholderAvatar =
- DefaultSymbolWithPointSize(kPersonCropCircleSymbol, kAvatarSymbolSize);
+ SymbolWithPointSize(SymbolPersonCropCircle, kAvatarSymbolSize);
// View containing user's avatar.
self.avatarView = [[UIImageView alloc] initWithImage:placeholderAvatar];
self.avatarView.translatesAutoresizingMaskIntoConstraints = NO;
Change information
Files:
- M ios/chrome/browser/passwords/model/notify_auto_signin_view_controller.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Maria Kazinova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:50:03 AM (2 days ago) Jul 22
to Viktor Semeniuk, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Viktor Semeniuk
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Viktor Semeniuk to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/passwords/password_breach/ui/password_breach_view_controller.mm b/ios/chrome/browser/passwords/password_breach/ui/password_breach_view_controller.mm
index 8bd4e1e..c7fd609 100644
--- a/ios/chrome/browser/passwords/password_breach/ui/password_breach_view_controller.mm
+++ b/ios/chrome/browser/passwords/password_breach/ui/password_breach_view_controller.mm
@@ -29,7 +29,7 @@
- (void)viewDidLoad {
_helpButton = [[UIBarButtonItem alloc]
- initWithImage:DefaultSymbolWithPointSize(kHelpSymbol, kHelpSymbolSize)
+ initWithImage:SymbolWithPointSize(SymbolHelp, kHelpSymbolSize)
style:UIBarButtonItemStylePlain
target:self
action:@selector(showLearnMore)];
Change information
Files:
- M ios/chrome/browser/passwords/password_breach/ui/password_breach_view_controller.mm
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention is currently required from:
- Viktor Semeniuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:50:35 AM (2 days ago) Jul 22
to Guillaume Jenkins, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Guillaume Jenkins
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Guillaume Jenkins to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/picture_in_picture/ui/picture_in_picture_view_controller.mm b/ios/chrome/browser/picture_in_picture/ui/picture_in_picture_view_controller.mm
index a06e535..9339c555 100644
--- a/ios/chrome/browser/picture_in_picture/ui/picture_in_picture_view_controller.mm
+++ b/ios/chrome/browser/picture_in_picture/ui/picture_in_picture_view_controller.mm
@@ -222,7 +222,7 @@
_playPauseButton.tintColor = [UIColor whiteColor];
UIImage* pauseImage =
- DefaultSymbolWithPointSize(kPauseFillSymbol, kPlayPauseButtonPointSize);
+ SymbolWithPointSize(SymbolPauseFill, kPlayPauseButtonPointSize);
[_playPauseButton setImage:pauseImage forState:UIControlStateNormal];
_playPauseButton.accessibilityLabel =
l10n_util::GetNSString(IDS_IOS_PICTURE_IN_PICTURE_PAUSE);
@@ -313,14 +313,14 @@
if (_player.timeControlStatus == AVPlayerTimeControlStatusPlaying) {
[_player pause];
UIImage* playImage =
- DefaultSymbolWithPointSize(kPlayFillSymbol, kPlayPauseButtonPointSize);
+ SymbolWithPointSize(SymbolPlayFill, kPlayPauseButtonPointSize);
[_playPauseButton setImage:playImage forState:UIControlStateNormal];
_playPauseButton.accessibilityLabel =
l10n_util::GetNSString(IDS_IOS_PICTURE_IN_PICTURE_PLAY);
} else {
[_player play];
UIImage* pauseImage =
- DefaultSymbolWithPointSize(kPauseFillSymbol, kPlayPauseButtonPointSize);
+ SymbolWithPointSize(SymbolPauseFill, kPlayPauseButtonPointSize);
[_playPauseButton setImage:pauseImage forState:UIControlStateNormal];
_playPauseButton.accessibilityLabel =
l10n_util::GetNSString(IDS_IOS_PICTURE_IN_PICTURE_PAUSE);
Change information
Files:
- M ios/chrome/browser/picture_in_picture/ui/picture_in_picture_view_controller.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Guillaume Jenkins
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:51:02 AM (2 days ago) Jul 22
to Gayane Petrosyan, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Gayane Petrosyan
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Gayane Petrosyan to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/price_insights/model/price_insights_model.mm b/ios/chrome/browser/price_insights/model/price_insights_model.mm
index 94d552e..01f0e1c6 100644
--- a/ios/chrome/browser/price_insights/model/price_insights_model.mm
+++ b/ios/chrome/browser/price_insights/model/price_insights_model.mm
@@ -190,10 +190,7 @@
return;
}
- execution_it->second->config->entrypoint_image_name =
- base::SysNSStringToUTF8(kDownTrendSymbol);
- execution_it->second->config->image_type =
- ContextualPanelItemConfiguration::EntrypointImageType::Image;
+ execution_it->second->config->entrypoint_symbol = SymbolDownTrend;
execution_it->second->config->accessibility_label =
l10n_util::GetStringUTF8(IDS_PRICE_INSIGHTS_ACCESSIBILITY);
execution_it->second->config->iph_feature =
diff --git a/ios/chrome/browser/price_insights/ui/price_insights_cell.mm b/ios/chrome/browser/price_insights/ui/price_insights_cell.mm
index d9264814..df1ae8f5 100644
--- a/ios/chrome/browser/price_insights/ui/price_insights_cell.mm
+++ b/ios/chrome/browser/price_insights/ui/price_insights_cell.mm
@@ -301,7 +301,7 @@
verticalStack.isAccessibilityElement = NO;
verticalStack.translatesAutoresizingMaskIntoConstraints = NO;
- UIImage* icon = DefaultSymbolWithPointSize(kOpenImageActionSymbol, kIconSize);
+ UIImage* icon = SymbolWithPointSize(SymbolOpenImageAction, kIconSize);
UIImageView* iconView = [[UIImageView alloc] initWithImage:icon];
iconView.tintColor = [UIColor colorNamed:kGrey500Color];
iconView.isAccessibilityElement = NO;
Change information
Files:
- M ios/chrome/browser/price_insights/model/price_insights_model.mm
- M ios/chrome/browser/price_insights/ui/price_insights_cell.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Gayane Petrosyan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:51:29 AM (2 days ago) Jul 22
to Daniel White, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Daniel White
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Daniel White to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm b/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm
index 9d2a103d..14c732ce 100644
--- a/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm
+++ b/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm
@@ -30,8 +30,7 @@
self.clipsToBounds = YES;
self.tintColor = [UIColor colorNamed:kBlueColor];
- [self setImage:DefaultSymbolTemplateWithPointSize(kMenuSymbol,
- kMenuSymbolPointSize)
+ [self setImage:SymbolTemplateWithPointSize(SymbolMenu, kMenuSymbolPointSize)
forState:UIControlStateNormal];
[NSLayoutConstraint activateConstraints:@[
diff --git a/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm b/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm
index 712ad245..8e4e5b2 100644
--- a/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm
+++ b/ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm
@@ -59,7 +59,7 @@
weight:UIImageSymbolWeightSemibold
scale:UIImageSymbolScaleMedium];
- UIImage* icon = DefaultSymbolWithConfiguration(kBellSymbol, configuration);
+ UIImage* icon = SymbolWithConfiguration(SymbolBell, configuration);
UIAction* stop_tracking = [UIAction
actionWithTitle:
Change information
Files:
- M ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm
- M ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Daniel White
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:51:58 AM (2 days ago) Jul 22
to Ankush Singh, chromium...@chromium.org, jeffreycohen+watc...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org
Attention needed from Ankush Singh
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ankush Singh to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/send_tab_to_self/ui/send_tab_to_self_bottom_sheet_view_controller.mm
- M ios/chrome/browser/send_tab_to_self/ui/send_tab_to_self_table_view_controller.mm
Change size: S
Delta: 2 files changed, 23 insertions(+), 24 deletions(-)
Related details
Attention is currently required from:
- Ankush Singh
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
Jul 22, 2026, 10:52:27 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Gauthier Ambard
Vidhan Jain voted![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:52:30 AM (2 days ago) Jul 22
to Julia Sobiech, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Julia Sobiech
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Julia Sobiech to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/settings/autofill/autofill_and_passwords/utils/autofill_and_passwords_item_utils.mm
Change size: S
Delta: 1 file changed, 16 insertions(+), 17 deletions(-)
Related details
Attention is currently required from:
- Julia Sobiech
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:52:59 AM (2 days ago) Jul 22
to Marke Hallowell, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Marke Hallowell
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Marke Hallowell to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/settings/ui_bundled/notifications/content_notifications/content_notifications_mediator.mm b/ios/chrome/browser/settings/ui_bundled/notifications/content_notifications/content_notifications_mediator.mm
index 9e98102..ce83302 100644
--- a/ios/chrome/browser/settings/ui_bundled/notifications/content_notifications/content_notifications_mediator.mm
+++ b/ios/chrome/browser/settings/ui_bundled/notifications/content_notifications/content_notifications_mediator.mm
@@ -102,7 +102,7 @@
text:
l10n_util::GetNSString(
IDS_IOS_CONTENT_NOTIFICATIONS_PERSONALIZED_NEWS_SETTINGS_TOGGLE_TITLE)
- symbol:DefaultSettingsRootSymbol(kNewspaperSFSymbol)
+ symbol:SettingsRootSymbol(SymbolDiscoverFeed)
symbolTint:UIColor.whiteColor
symbolBackgroundColor:[UIColor colorNamed:kPink500Color]
symbolBorderWidth:0
diff --git a/ios/chrome/browser/settings/ui_bundled/notifications/notifications_mediator.mm b/ios/chrome/browser/settings/ui_bundled/notifications/notifications_mediator.mm
index 24a8643..2cdc4e1 100644
--- a/ios/chrome/browser/settings/ui_bundled/notifications/notifications_mediator.mm
+++ b/ios/chrome/browser/settings/ui_bundled/notifications/notifications_mediator.mm
@@ -144,10 +144,10 @@
- (TableViewSwitchItem*)tipsNotificationsItem {
if (!_tipsNotificationsItem) {
#if BUILDFLAG(IOS_USE_BRANDED_ASSETS)
- UIImage* image = MakeSymbolMulticolor(
- CustomSettingsRootSymbol(kMulticolorChromeballSymbol));
+ UIImage* image =
+ MakeSymbolMulticolor(SettingsRootSymbol(SymbolMulticolorChromeball));
#else
- UIImage* image = CustomSettingsRootSymbol(kChromeProductSymbol);
+ UIImage* image = SettingsRootSymbol(SymbolChromeProduct);
#endif // BUILDFLAG(IOS_USE_BRANDED_ASSETS)
_tipsNotificationsItem = [self
switchItemWithType:NotificationsItemIdentifier::ItemIdentifierTips
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/notifications/content_notifications/content_notifications_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/notifications/notifications_mediator.mm
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Marke Hallowell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:53:28 AM (2 days ago) Jul 22
to Ernesto Izquierdo Clua, chromium...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Ernesto Izquierdo Clua
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Ernesto Izquierdo Clua to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/password/create_password_manager_title_view.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_details/add_password_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_details/password_details_table_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_manager_view_controller_items.mm
- M ios/chrome/browser/settings/ui_bundled/password/passwords_in_other_apps/passwords_in_other_apps_view_controller.mm
Change size: S
Delta: 5 files changed, 22 insertions(+), 25 deletions(-)
Related details
Attention is currently required from:
- Ernesto Izquierdo Clua
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:53:58 AM (2 days ago) Jul 22
to Rafał Godlewski, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, ios-revie...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org
Attention needed from Rafał Godlewski
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Rafał Godlewski to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/family_picker_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/family_picker_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/multi_avatar_image_util.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/recipient_info.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_view_controller.mm
Change size: M
Delta: 7 files changed, 22 insertions(+), 28 deletions(-)
Related details
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:54:26 AM (2 days ago) Jul 22
to Benjamin Williams, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Benjamin Williams to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/settings/ui_bundled/safety_check/safety_check_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/safety_check/safety_check_mediator_unittest.mm
Change size: S
Delta: 2 files changed, 9 insertions(+), 9 deletions(-)
Related details
Attention is currently required from:
- Benjamin Williams
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Jul 22, 2026, 10:54:49 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Gauthier Ambard
Alexis Hétu voted![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:55:04 AM (2 days ago) Jul 22
to Mark Cogan, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Mark Cogan
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Mark Cogan to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/shared/ui/elements/new_feature_badge_view.mm
- M ios/chrome/browser/shared/ui/symbols/colorful_background_symbol_view.h
- M ios/chrome/browser/shared/ui/symbols/colorful_background_symbol_view.mm
- M ios/chrome/browser/shared/ui/symbols/symbol_helpers.mm
Change size: S
Delta: 4 files changed, 13 insertions(+), 17 deletions(-)
Related details
Attention is currently required from:
- Mark Cogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:55:35 AM (2 days ago) Jul 22
to Duong Dac, chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Duong Dac
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Duong Dac to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
diff --git a/ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm b/ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm
index 71f480a..c6d52eac 100644
--- a/ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm
+++ b/ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm
@@ -40,8 +40,8 @@
palette = [transparentPalette copy];
}
- return SymbolWithPalette(
- DefaultSymbolWithPointSize(kXMarkCircleFillSymbol, 30), palette);
+ return SymbolWithPalette(SymbolWithPointSize(SymbolXMarkCircleFill, 30),
+ palette);
}
} // namespace
Change information
Files:
- M ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Duong Dac
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 10:56:00 AM (2 days ago) Jul 22
to Aliona Dangla, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Attention needed from Aliona Dangla
Gauthier Ambard has uploaded the change for review![]( "Open in Gerrit")
Gauthier Ambard would like Aliona Dangla to review this change.
Commit message
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Change diff
Change information
Files:
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/grid_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/group_grid_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/regular/inactive_tabs_button_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/tab_group_activity_summary_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/inactive_tabs/inactive_tabs_user_education_coordinator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_grid_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/create_tab_group_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_log_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_mediator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/shared_tab_group_user_education_coordinator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_notification_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_out_of_date_message_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_bottom_toolbar.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_new_tab_button.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_top_toolbar.mm
Change size: M
Delta: 17 files changed, 40 insertions(+), 44 deletions(-)
Related details
Attention is currently required from:
- Aliona Dangla
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Maunder (Gerrit)
Jul 22, 2026, 10:58:17 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
David Maunder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Maunder . resolved
change seems fine - what is the risk of a visual regression? is it possible to do some local hard coding to automatically show the price tracking promo card with the fallback image to check it and be safe?
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aliona Dangla (Gerrit)
Jul 22, 2026, 10:58:42 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Aliona Dangla voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jul 22, 2026, 10:59:28 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ginny Huang
| Code-Review | +1 |
1 comment
Commit Message
Line 12, Patchset 1 (Latest):
This has been mostly vibe-coded.Ginny Huang . resolved
This has been mostly human-LGTMed.
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Lu (Gerrit)
Jul 22, 2026, 11:01:47 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, thegreenf...@chromium.org
Attention needed from Gauthier Ambard
Chris Lu voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 11:04:59 AM (2 days ago) Jul 22
to Chromium LUCI CQ, Viktor Semeniuk, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Gauthier Ambard voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francis Beauchamp (Gerrit)
Jul 22, 2026, 11:06:05 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Francis Beauchamp voted and added 1 comment![]( "Open in Gerrit")
Votes added by Francis Beauchamp
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Cogan (Gerrit)
Jul 22, 2026, 11:06:33 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Mark Cogan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Cogan
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Mark Cogan . resolved
LGTM
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 11:08:05 AM (2 days ago) Jul 22
to Chromium LUCI CQ, Mark Cogan, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/shared/ui/symbols/colorful_background_symbol_view.h
Line 25, Patchset 1 (Latest):
#import "ios/chrome/browser/shared/ui/symbols/symbol_enums.h"Gauthier Ambard . unresolved
Should be fixed
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ankush Singh (Gerrit)
Jul 22, 2026, 11:08:17 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jeffreycohen+watc...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org
Attention needed from Gauthier Ambard
Ankush Singh voted![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 11:09:15 AM (2 days ago) Jul 22
to Francis Beauchamp, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Gauthier Ambard voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Duong Dac (Gerrit)
Jul 22, 2026, 11:10:38 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Duong Dac voted![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
Jul 22, 2026, 11:19:11 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Scott Yoder voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Yoder
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Scott Yoder . resolved
LGTM. This is great - I really disliked that system and custom symbols meant we had to have two versions of functions to deal with them. And everything that took a symbol had to either take a UIImage, or a name and a boolean, etc. I wrote a whole doc a couple years ago on how we should have an ObjC class to contain a symbol and associated methods to change the configuration, etc. And then I did nothing and forgot I had written the doc! But I think this new Symbol enum is good.
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Robin (Gerrit)
Jul 22, 2026, 11:21:19 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, browser-comp...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Gauthier Ambard
Olivier Robin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Robin
| Code-Review | +1 |
1 comment
File ios/chrome/browser/autofill/model/form_suggestion_controller.mm
Line 109, Patchset 1 (Parent):
DefaultSymbolWithPointSize(kArrowUTurnBackwardSymbol,Olivier Robin . unresolved
should all of these be removed from symbol_names?
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 11:27:11 AM (2 days ago) Jul 22
to Olivier Robin, chromium...@chromium.org, browser-comp...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Gauthier Ambard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gauthier Ambard
| Commit-Queue | +2 |
1 comment
File ios/chrome/browser/autofill/model/form_suggestion_controller.mm
Line 109, Patchset 1 (Parent):
DefaultSymbolWithPointSize(kArrowUTurnBackwardSymbol,Olivier Robin . resolved
should all of these be removed from symbol_names?
Gauthier Ambard
Yes, once the 52 other CLs have landed.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 11:28:45 AM (2 days ago) Jul 22
to Chromium LUCI CQ, Quentin Pubert, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Gauthier Ambard added 2 comments![]( "Open in Gerrit")
File ios/chrome/browser/reader_mode/model/constants.h
Line 255, Patchset 1 (Latest):
#import "ios/chrome/browser/shared/ui/symbols/symbol_enums.h"Gauthier Ambard . unresolved
Need to be fixed
File ios/chrome/browser/reader_mode/model/constants.mm
Line 62, Patchset 1 (Latest):
Symbol GetReaderModeSymbol() {Gauthier Ambard . unresolved
Is that necessary? Check why the other method is still there.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sebastien Lalancette (Gerrit)
Jul 22, 2026, 11:29:07 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Sebastien Lalancette voted and added 2 comments![]( "Open in Gerrit")
Votes added by Sebastien Lalancette
| Code-Review | +1 |
2 comments
File ios/chrome/browser/menu/ui_bundled/browser_action_factory.mm
Line 336, Patchset 1 (Latest):
[handler openURLInNewTab:command];Sebastien Lalancette . unresolved
Please fix this WARNING reported by autoreview issue finding: The indentation here seems incorrect. It was previously 20 spaces, now it's only 14. It should be indented by 2 spaces relative to the start of the block.
Line 361, Patchset 1 (Latest):
[handler openURLInNewTab:command];Sebastien Lalancette . unresolved
Please fix this WARNING reported by autoreview issue finding: The indentation here is also incorrect (under-indented).
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Ekey (Gerrit)
Jul 22, 2026, 11:29:39 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Eric Ekey voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 11:33:17 AM (2 days ago) Jul 22
to Gauthier Ambard, Kirubel, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I6d9744d8a16bd18082332c1877e1997820a05ae7
Reviewed-by: Kirubel <kak...@chromium.org>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Kirubel <kak...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666328}
Files:
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_actor_tool_chip_view_controller.mm
- M ios/chrome/browser/ai_prototyping/ui/ai_prototyping_worklog_item_showcase_view_controller.mm
Change size: S
Delta: 2 files changed, 9 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kirubel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Briana McClure (Gerrit)
Jul 22, 2026, 11:41:04 AM (2 days ago) Jul 22
to Gauthier Ambard, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Briana McClure voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Jul 22, 2026, 11:41:24 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Gauthier Ambard
Rafał Godlewski voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 11:41:30 AM (2 days ago) Jul 22
to Gauthier Ambard, Cheick Cisse, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: Ied4099461f35880a3e17d86341686ad6fa8ac6ca
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Cheick Cisse <cheic...@google.com>
Commit-Queue: Cheick Cisse <cheic...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666337}
Files:
- M ios/chrome/browser/authentication/signin/non_modal_promo/coordinator/non_modal_signin_promo_coordinator.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Cheick Cisse
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 11:46:05 AM (2 days ago) Jul 22
to Gauthier Ambard, Vidhan Jain, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I5af5b4d8e7fc81b6730e5f44f67e418d012118c2
Commit-Queue: Vidhan Jain <vid...@google.com>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Vidhan Jain <vid...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666339}
Files:
- M ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_country_selection_table_view_controller.mm
- M ios/chrome/browser/infobars/ui_bundled/modals/autofill_address_profile/infobar_save_address_profile_view_controller.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/autofill_address_profile/save_address_profile_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/autofill_address_profile/save_address_profile_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_profile_table_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/autofill/autofill_settings_profile_edit_table_view_controller.mm
Change size: M
Delta: 6 files changed, 27 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vidhan Jain
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Cogan (Gerrit)
Jul 22, 2026, 11:50:19 AM (2 days ago) Jul 22
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Mark Cogan added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/shared/ui/symbols/colorful_background_symbol_view.h
Line 25, Patchset 1 (Latest):
#import "ios/chrome/browser/shared/ui/symbols/symbol_enums.h"Gauthier Ambard . resolved
Mark CoganShould be fixed
Acknowledged
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slobodan Pejic (Gerrit)
Jul 22, 2026, 11:57:58 AM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Gauthier Ambard
Slobodan Pejic voted and added 2 comments![]( "Open in Gerrit")
Votes added by Slobodan Pejic
| Code-Review | +1 |
2 comments
Patchset-level comments
Slobodan Pejic . resolved
LGTM
Commit Message
Line 18, Patchset 1 (Latest):
Bug: 537673111Slobodan Pejic . resolved
For posterity, https://crrev.com/c/8129922 introduces the new `SymbolWithPointSize()` function and `Symbol` enum.
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:07:57 PM (2 days ago) Jul 22
to Gauthier Ambard, Ankush Singh, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jeffreycohen+watc...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: Iade9d339c46185f485e403f2b470299ded90a4ad
Reviewed-by: Ankush Singh <ankus...@google.com>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Ankush Singh <ankus...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666366}
Files:
- M ios/chrome/browser/send_tab_to_self/ui/send_tab_to_self_bottom_sheet_view_controller.mm
- M ios/chrome/browser/send_tab_to_self/ui/send_tab_to_self_table_view_controller.mm
Change size: S
Delta: 2 files changed, 23 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ankush Singh
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:10:59 PM (2 days ago) Jul 22
to Gauthier Ambard, Chris Lu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, sloboda...@chromium.org, thegreenf...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I9ed020f7fe924fe815d016789e972f998e9a6b0b
Reviewed-by: Chris Lu <thegre...@chromium.org>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Chris Lu <thegre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666370}
Files:
- M ios/chrome/browser/ntp/ui_bundled/incognito/incognito_view.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_header_view.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_quick_actions_view_controller.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_redesign_view_controller.mm
- M ios/chrome/browser/ntp/ui_bundled/ntp_identity_disc_button.mm
- M ios/chrome/browser/ntp/ui_bundled/ntp_tools_menu_button.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/permissions/permissions_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/safe_browsing/enhanced_safe_browsing_infobar_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/save_card/save_card_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/save_cvc/save_cvc_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/sync_error/sync_error_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/tailored_security/tailored_security_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/tailored_security/tailored_security_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/translate/translate_infobar_banner_overlay_mediator.mm
- M ios/chrome/browser/overlays/ui_bundled/infobar_banner/translate/translate_infobar_banner_overlay_mediator_unittest.mm
- M ios/chrome/browser/overscroll_actions/ui_bundled/overscroll_actions_view.mm
Change size: M
Delta: 16 files changed, 58 insertions(+), 63 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Lu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:11:11 PM (2 days ago) Jul 22
to Gauthier Ambard, Duong Dac, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I1248152b8b1b04a94d02ea9c18c07a5c963ce428
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Duong Dac <dd...@chromium.org>
Reviewed-by: Duong Dac <dd...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666371}
Files:
- M ios/chrome/browser/supervised_user/ui/parent_access_bottom_sheet_view_controller.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Duong Dac
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:12:33 PM (2 days ago) Jul 22
to Gauthier Ambard, Aliona Dangla, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I3521e1b1141feafe7645372dbe453fe9a0893e8b
Reviewed-by: Aliona Dangla <aliona...@chromium.org>
Commit-Queue: Aliona Dangla <aliona...@chromium.org>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666373}
Files:
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/grid_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/group_grid_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/regular/inactive_tabs_button_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/tab_group_activity_summary_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/inactive_tabs/inactive_tabs_user_education_coordinator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_grid_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/create_tab_group_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_log_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_mediator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/recent_activity_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/shared_tab_group_user_education_coordinator.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_group_view_controller.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_notification_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/tab_groups/tab_groups_panel_out_of_date_message_cell.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_bottom_toolbar.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_new_tab_button.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/toolbars/tab_grid_top_toolbar.mm
Change size: M
Delta: 17 files changed, 40 insertions(+), 44 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Aliona Dangla
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Jul 22, 2026, 12:29:08 PM (2 days ago) Jul 22
to Chromium LUCI CQ, Mark Cogan, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Mark Cogan
Gauthier Ambard added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/shared/ui/symbols/colorful_background_symbol_view.h
Line 25, Patchset 1 (Latest):
#import "ios/chrome/browser/shared/ui/symbols/symbol_enums.h"Gauthier Ambard . unresolved
Mark CoganShould be fixed
Acknowledged
Attention is currently required from:
- Mark Cogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:32:25 PM (2 days ago) Jul 22
to Gauthier Ambard, Scott Yoder, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: Ice7b3ae26c231169c3da04c92021b7fb4973d6fa
Commit-Queue: Scott Yoder <scott...@google.com>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Scott Yoder <scott...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666397}
Files:
- M ios/chrome/browser/browser_view/ui_bundled/key_commands_provider.mm
- M ios/chrome/browser/reminder_notifications/ui/reminder_notifications_view_controller.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Scott Yoder
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gayane Petrosyan (Gerrit)
Jul 22, 2026, 12:39:15 PM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Gayane Petrosyan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gayane Petrosyan
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:43:43 PM (2 days ago) Jul 22
to Gauthier Ambard, Olivier Robin, chromium...@chromium.org, browser-comp...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I548c158c8f85fbb8e45a891ec007ca830f06f56a
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Olivier Robin <olivie...@chromium.org>
Commit-Queue: Gauthier Ambard <gam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666412}
Files:
- M ios/chrome/browser/autofill/model/autofill_ai_prefetch_failure_infobar_delegate_ios.mm
- M ios/chrome/browser/autofill/model/form_suggestion_controller.mm
- M ios/chrome/browser/context_menu/ui_bundled/context_menu_configuration_provider.mm
- M ios/chrome/browser/context_menu/ui_bundled/image_preview_view_controller.mm
- M ios/chrome/browser/download/ui/auto_deletion/auto_deletion_iph_view_controller.mm
- M ios/chrome/browser/download/ui/download_list/download_filter_cell.mm
- M ios/chrome/browser/download/ui/download_list/download_list_table_view_controller.mm
- M ios/chrome/browser/download/ui/download_manager_state_view.mm
- M ios/chrome/browser/download/ui/download_manager_view_controller.mm
- M ios/chrome/browser/drive/model/drive_list.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_cell_content_configuration.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_empty_view.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_item.mm
- M ios/chrome/browser/drive_file_picker/ui/drive_file_picker_table_view_controller.mm
- M ios/chrome/browser/partial_translate/ui_bundled/partial_translate_mediator.mm
- M ios/chrome/browser/reading_list/ui_bundled/reading_list_table_view_item.mm
- M ios/chrome/browser/reading_list/ui_bundled/reading_list_toolbar_button_manager.mm
- M ios/chrome/browser/save_to_photos/ui_bundled/save_to_photos_mediator.mm
- M ios/chrome/browser/search_with/ui_bundled/search_with_mediator.mm
Change size: M
Delta: 19 files changed, 107 insertions(+), 124 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Olivier Robin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 12:45:22 PM (2 days ago) Jul 22
to Gauthier Ambard, Briana McClure, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I9773425a8a89f203cccc2b8e031d2e1ad9ac95ab
Reviewed-by: Briana McClure <bmcc...@google.com>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Briana McClure <bmcc...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666413}
Files:
- M ios/chrome/browser/first_run/best_features/coordinator/best_features_screen_detail_coordinator.mm
- M ios/chrome/browser/first_run/best_features/ui/best_features_view_controller.mm
- M ios/chrome/browser/first_run/public/best_features_item.mm
- M ios/chrome/browser/welcome_back/ui/welcome_back_view_controller.mm
Change size: S
Delta: 4 files changed, 14 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Briana McClure
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 1:01:24 PM (2 days ago) Jul 22
to Gauthier Ambard, Rafał Godlewski, chromium...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I00e018b9a1f4aecf2a435b818e9cf1cff3613563
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Rafał Godlewski <rg...@google.com>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666426}
Files:
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/family_picker_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/family_picker_view_controller_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/multi_avatar_image_util.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/recipient_info.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_mediator_unittest.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_sharing/sharing_status_view_controller.mm
Change size: M
Delta: 7 files changed, 22 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rafał Godlewski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ernesto Izquierdo Clua (Gerrit)
Jul 22, 2026, 1:01:27 PM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Attention needed from Gauthier Ambard
Ernesto Izquierdo Clua voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
Jul 22, 2026, 1:02:03 PM (2 days ago) Jul 22
to Gauthier Ambard, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Gauthier Ambard
Adam Arcaro voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel White (Gerrit)
Jul 22, 2026, 1:15:33 PM (2 days ago) Jul 22
to Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Daniel White voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
Jul 22, 2026, 1:15:36 PM (2 days ago) Jul 22
to Gauthier Ambard, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Gauthier Ambard
Adam Arcaro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +0 |
1 comment
File ios/chrome/browser/location_bar/badge/ui/location_bar_badge_view_controller.mm
Line 639, Patchset 1 (Latest):
image = SymbolWithPointSize(config->entrypoint_symbol, symbolPointSize);Adam Arcaro . unresolved
Looks like `entrypoint_symbol` isn't defined in http://osscs/chromium/chromium/src/+/main:ios/chrome/browser/contextual_panel/model/contextual_panel_item_configuration.h?q=ContextualPanelItemConfiguration&ss=chromium
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
Jul 22, 2026, 1:43:52 PM (2 days ago) Jul 22
to Chromium LUCI CQ, Gauthier Ambard, Olivier Robin, chromium...@chromium.org, browser-comp...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Mike Dougherty has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guillaume Jenkins (Gerrit)
Jul 22, 2026, 1:56:44 PM (2 days ago) Jul 22
to Gauthier Ambard, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Guillaume Jenkins voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 2:01:07 PM (2 days ago) Jul 22
to Gauthier Ambard, Ernesto Izquierdo Clua, chromium...@chromium.org, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I7605f6ab8f59bc4dff3f7696c8d258ec3a76b553
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Ernesto Izquierdo Clua <e...@google.com>
Commit-Queue: Ernesto Izquierdo Clua <e...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666479}
Files:
- M ios/chrome/browser/settings/ui_bundled/password/create_password_manager_title_view.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_details/add_password_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_details/password_details_table_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/password/password_manager_view_controller_items.mm
- M ios/chrome/browser/settings/ui_bundled/password/passwords_in_other_apps/passwords_in_other_apps_view_controller.mm
Change size: S
Delta: 5 files changed, 22 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ernesto Izquierdo Clua
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 2:12:53 PM (2 days ago) Jul 22
to Gauthier Ambard, Daniel White, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Replace Symbol helper with new helpers
This CL changes the symbol helpers, replacing the dual definitions
Custom/Settings by a version that has only a single helper.
This has been mostly vibe-coded.
This CL was uploaded by git cl split.
Bug: 537673111
Change-Id: I92f4056208e6b11e89dffd7f72df66f78143799e
Commit-Queue: Daniel White <daniel...@google.com>
Auto-Submit: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Daniel White <daniel...@google.com>
Cr-Commit-Position: refs/heads/main@{#1666489}
Files:
- M ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_menu_button.mm
- M ios/chrome/browser/price_notifications/ui_bundled/cells/price_notifications_table_view_item.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel White
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
It is loading more messages.
0 new messages