Alex Ovsienko (Gerrit)

unread,

Jul 21, 2026, 8:58:38 PM (yesterday) Jul 21

to Nate Fischer, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Nate Fischer

Alex Ovsienko has uploaded the change for review

Alex Ovsienko would like Nate Fischer to review this change.

Commit message

Migrate RunPylint presubmit commands to Pylint 3.2 in android_webview

Update all RunPylint presubmit commands to use Pylint 3.2 and add breakages
to list of disabled_warnings.

This CL was uploaded by git cl split.

R=ntf...@chromium.org

Bug: 537041607
Change-Id: I1353eff846a5d564e55b4559cb9bdb64656fc3a6
TAG=agy

Change diff

diff --git a/android_webview/tools/PRESUBMIT.py b/android_webview/tools/PRESUBMIT.py
index 5c0fb82..10a0132c 100644
--- a/android_webview/tools/PRESUBMIT.py
+++ b/android_webview/tools/PRESUBMIT.py
@@ -19,14 +19,33 @@
   checks = []
 
   src_root = input_api.os_path.join(input_api.PresubmitLocalPath(), '..', '..')
+  disabled_warnings = [
+      'bad-plugin-value',
+      'broad-exception-raised',
+      'consider-using-f-string',
+      'consider-using-with',
+      'duplicate-code',
+      'import-error',
+      'import-outside-toplevel',
+      'missing-class-docstring',
+      'missing-function-docstring',
+      'missing-module-docstring',
+      'no-self-argument',
+      'unnecessary-dunder-call',
+      'unnecessary-pass',
+      'unrecognized-option',
+      'unspecified-encoding',
+      'unused-argument',
+      'use-dict-literal',
+      'use-yield-from',
+      'useless-option-value',
+  ]
   checks.extend(
       input_api.canned_checks.GetPylint(
           input_api,
           output_api,
           pylintrc='pylintrc',
-          disabled_warnings=[
-              'R0801',  # suppress pylint duplicate code false positive
-          ],
+          disabled_warnings=disabled_warnings,
           # Allows pylint to find dependencies imported by scripts in this
           # directory.
           extra_paths_list=[
@@ -37,7 +56,7 @@
               input_api.os_path.join(src_root, 'third_party', 'catapult',
                                      'devil'),
           ],
-          version='2.7'))
+          version='3.2'))
   checks.extend(_GetPythonUnitTests(input_api, output_api))
   return input_api.RunTests(checks, False)

Change information

Files:

M android_webview/tools/PRESUBMIT.py

Change size: S

Delta: 1 file changed, 23 insertions(+), 4 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nate Fischer (Gerrit)

unread,

Jul 21, 2026, 9:09:40 PM (24 hours ago) Jul 21

to Alex Ovsienko, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko

Nate Fischer voted and added 1 comment

Votes added by Nate Fischer

Code-Review

+1

1 comment

File android_webview/tools/PRESUBMIT.py

Line 28, Patchset 1 (Parent): 'R0801', # suppress pylint duplicate code false positive

Nate Fischer . unresolved

Could you please carry this comment over to the `'duplicate-code'` line in the new patchset? (line 27)

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jul 21, 2026, 9:21:19 PM (24 hours ago) Jul 21

to Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Nate Fischer

Alex Ovsienko voted and added 1 comment

Votes added by Alex Ovsienko

Auto-Submit

+1

1 comment

File android_webview/tools/PRESUBMIT.py

Line 28, Patchset 1 (Parent): 'R0801', # suppress pylint duplicate code false positive

Nate Fischer . resolved

Could you please carry this comment over to the `'duplicate-code'` line in the new patchset? (line 27)

Alex Ovsienko

Done

Open in Gerrit

Related details

Attention is currently required from:

Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jul 21, 2026, 9:21:37 PM (24 hours ago) Jul 21

to Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Nate Fischer

Alex Ovsienko voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Stark (Gerrit)

unread,

Jul 21, 2026, 9:25:35 PM (24 hours ago) Jul 21

to Alex Ovsienko, Chromium LUCI CQ, Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko and Nate Fischer

Matt Stark voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jul 21, 2026, 9:27:01 PM (24 hours ago) Jul 21

to Chromium LUCI CQ, Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Nate Fischer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Stark (Gerrit)

unread,

Jul 21, 2026, 9:30:30 PM (23 hours ago) Jul 21

to Alex Ovsienko, Chromium LUCI CQ, Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko and Nate Fischer

Matt Stark voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Stark (Gerrit)

unread,

Jul 21, 2026, 9:59:40 PM (23 hours ago) Jul 21

to Alex Ovsienko, Chromium LUCI CQ, Nate Fischer, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko and Nate Fischer

Matt Stark voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Nate Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nate Fischer (Gerrit)

unread,

12:13 PM (9 hours ago) 12:13 PM

to Alex Ovsienko, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko and Matt Stark

Nate Fischer voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Matt Stark

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Stark (Gerrit)

unread,

7:21 PM (2 hours ago) 7:21 PM

to Alex Ovsienko, Nate Fischer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Attention needed from Alex Ovsienko

Matt Stark voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

8:00 PM (1 hour ago) 8:00 PM

to Nate Fischer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Alex Ovsienko voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

8:01 PM (1 hour ago) 8:01 PM

to Nate Fischer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org

Alex Ovsienko voted Commit-Queue+0

Commit-Queue

+0

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Migrate RunPylint presubmit commands to Pylint 3.2 in android_webview [chromium/src : main]

Alex Ovsienko (Gerrit)

Alex Ovsienko has uploaded the change for review

Commit message

Change diff

Change information

Related details

Nate Fischer (Gerrit)

Nate Fischer voted and added 1 comment

Votes added by Nate Fischer

1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted and added 1 comment

Votes added by Alex Ovsienko

1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Commit-Queue+2

Related details

Matt Stark (Gerrit)

Matt Stark voted Code-Review+1

Related details

Alex Ovsienko (Gerrit)

New activity on the change

Related details

Matt Stark (Gerrit)

Matt Stark voted Code-Review+1

Related details

Matt Stark (Gerrit)

Matt Stark voted Code-Review+1

Related details

Nate Fischer (Gerrit)

Nate Fischer voted Code-Review+1

Related details

Matt Stark (Gerrit)

Matt Stark voted Code-Review+1

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Commit-Queue+2

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Commit-Queue+0