Roll zmij: 1.0.2 => 1.0.12 in //third_party/rust. [chromium/src : main]

0 views
Skip to first unread message

Alex Kallam (Gerrit)

unread,
Jan 9, 2026, 11:44:59 AM (2 days ago) Jan 9
to chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from chrome-third-pa...@google.com

Alex Kallam added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alex Kallam . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c21cdee0e5d3e2d9f864e53bd614aacd89b81c2
Gerrit-Change-Number: 7417162
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jan 9, 2026, 11:47:26 AM (2 days ago) Jan 9
to Alex Kallam, chrome-third-pa...@google.com, Liza Burakova, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Liza Burakova

Message from gwsq

From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: li...@chromium.org

It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.

`//third_party/rust` reviewer(s): li...@chromium.org


Reviewer source(s):
li...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Liza Burakova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c21cdee0e5d3e2d9f864e53bd614aacd89b81c2
Gerrit-Change-Number: 7417162
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Liza Burakova <li...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Liza Burakova <li...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:46:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Liza Burakova (Gerrit)

unread,
Jan 9, 2026, 3:54:15 PM (2 days ago) Jan 9
to Alex Kallam, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Alex Kallam

Liza Burakova voted and added 1 comment

Votes added by Liza Burakova

Code-Review+1

1 comment

Patchset-level comments
Liza Burakova . resolved

Looked at the new unsafe unsafe blocks, they all seem small and encapsulated so no concerns from me.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Kallam
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c21cdee0e5d3e2d9f864e53bd614aacd89b81c2
Gerrit-Change-Number: 7417162
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Liza Burakova <li...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Kallam <aaka...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 20:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 10, 2026, 11:28:11 PM (18 hours ago) Jan 10
to Alex Kallam, Daniel Cheng, Liza Burakova, chrome-third-pa...@google.com, chromium...@chromium.org, chrome-rust-exper...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Roll zmij: 1.0.2 => 1.0.12 in //third_party/rust.

This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* zmij: 1.0.2 => 1.0.12; https://docs.rs/crate/zmij/1.0.12
Bug: None
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Change-Id: I7c21cdee0e5d3e2d9f864e53bd614aacd89b81c2
Reviewed-by: Liza Burakova <li...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567483}
Files:
  • M third_party/rust/chromium_crates_io/Cargo.lock
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/.cargo_vcs_info.json
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/.github/workflows/ci.yml
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.lock
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.toml
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.toml.orig
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/README.md
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/src/lib.rs
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/src/tests.rs
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/src/traits.rs
  • M third_party/rust/chromium_crates_io/vendor/zmij-v1/tests/test.rs
  • M third_party/rust/zmij/v1/BUILD.gn
  • M third_party/rust/zmij/v1/README.chromium
Change size: XL
Delta: 13 files changed, 605 insertions(+), 909 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Liza Burakova
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c21cdee0e5d3e2d9f864e53bd614aacd89b81c2
Gerrit-Change-Number: 7417162
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Alex Kallam <aaka...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Liza Burakova <li...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages