[kiosk] Follow-up fixes to app_mode unittests [chromium/src : main]

0 views
Skip to first unread message

Achuith Bhandarkar (Gerrit)

unread,
6:32 AM (6 hours ago) 6:32 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com
Attention needed from Hidehiko Abe

Achuith Bhandarkar added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Achuith Bhandarkar . resolved

PTAL Hidehiko-san

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
Gerrit-Change-Number: 8061009
Gerrit-PatchSet: 3
Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 10:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
8:18 AM (4 hours ago) 8:18 AM
to Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com
Attention needed from Achuith Bhandarkar

Hidehiko Abe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Achuith Bhandarkar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
    Gerrit-Change-Number: 8061009
    Gerrit-PatchSet: 3
    Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 12:18:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    8:19 AM (4 hours ago) 8:19 AM
    to Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com
    Attention needed from Achuith Bhandarkar

    Hidehiko Abe added 1 comment

    Commit Message
    Line 10, Patchset 3 (Latest):
    - Replace std::ignore with ASSERT_TRUE for [[nodiscard]] return values from
    TestUserSessionManager user addition methods.
    - Replace deprecated UserManager::GetActiveUser and SwitchActiveUser methods
    with SessionManager::GetActiveSession and SwitchActiveSession equivalents.
    - Add an ASSERT_FALSE check for empty AccountIds in LoginUser.
    - Include necessary session.h header.
    Hidehiko Abe . unresolved

    nit: could you wrap lines to fit within 72 chars?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Achuith Bhandarkar
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
      Gerrit-Change-Number: 8061009
      Gerrit-PatchSet: 3
      Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>
      Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>
      Gerrit-Comment-Date: Wed, 08 Jul 2026 12:18:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Achuith Bhandarkar (Gerrit)

      unread,
      9:37 AM (3 hours ago) 9:37 AM
      to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com

      Achuith Bhandarkar voted and added 2 comments

      Votes added by Achuith Bhandarkar

      Commit-Queue+2

      2 comments

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Achuith Bhandarkar . resolved

      Ty

      Commit Message

      - Replace std::ignore with ASSERT_TRUE for [[nodiscard]] return values from
      TestUserSessionManager user addition methods.
      - Replace deprecated UserManager::GetActiveUser and SwitchActiveUser methods
      with SessionManager::GetActiveSession and SwitchActiveSession equivalents.
      - Add an ASSERT_FALSE check for empty AccountIds in LoginUser.
      - Include necessary session.h header.
      Hidehiko Abe . resolved

      nit: could you wrap lines to fit within 72 chars?

      Achuith Bhandarkar

      Done

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
        Gerrit-Change-Number: 8061009
        Gerrit-PatchSet: 4
        Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:37:18 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        9:41 AM (3 hours ago) 9:41 AM
        to Achuith Bhandarkar, Hidehiko Abe, chromium...@chromium.org, chromeos-kio...@google.com

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        3 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        [kiosk] Follow-up fixes to app_mode unittests

        This is a follow-up to crrev.com/c/8035996


        - Replace std::ignore with ASSERT_TRUE for [[nodiscard]] return values
          from TestUserSessionManager user addition methods.
        - Replace deprecated UserManager::GetActiveUser and SwitchActiveUser
          methods with SessionManager::GetActiveSession and SwitchActiveSession
          equivalents.
        - Add an ASSERT_FALSE check for empty AccountIds in LoginUser.
        - Include necessary session.h header.

        TAG=agy
        CONV=8969088f-60a0-4a6c-ad28-2a9452a26ec5
        Bug: 268078468
        Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
        Reviewed-by: Hidehiko Abe <hide...@chromium.org>
        Commit-Queue: Achuith Bhandarkar <ach...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1658693}
        Files:
        • M chrome/browser/ash/app_mode/app_launch_utils_unittest.cc
        • M chrome/browser/ash/app_mode/auto_sleep/device_weekly_scheduled_suspend_controller_unittest.cc
        Change size: S
        Delta: 2 files changed, 15 insertions(+), 12 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Hidehiko Abe
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I38e8a8c60b4fbf60654f5cc289bd73f103726eef
        Gerrit-Change-Number: 8061009
        Gerrit-PatchSet: 5
        Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages