Synchronize C++/Rust frame pointer enabling in compiler settings [chromium/src : main]
0 views
Skip to first unread message
Dominik Röttsches (Gerrit)
3:48 AM (13 hours ago) 3:48 AM
to Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Łukasz Anforowicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
6:35 AM (10 hours ago) 6:35 AM
to Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Hans Wennborg and Łukasz Anforowicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Hans Wennborg
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
6:36 AM (10 hours ago) 6:36 AM
to Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Hans Wennborg and Łukasz Anforowicz
Dominik Röttsches added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominik Röttsches . resolved
With this change and `perf record -g` I do get intact stack traces for profiles across C++ and Rust.
Related details
Attention is currently required from:
- Hans Wennborg
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hans Wennborg (Gerrit)
6:38 AM (10 hours ago) 6:38 AM
to Dominik Röttsches, Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Dominik Röttsches and Łukasz Anforowicz
Hans Wennborg added 1 comment![]( "Open in Gerrit")
File build/config/compiler/BUILD.gn
Line 2521, Patchset 3 (Latest):
rustflags = [ "-Cforce-frame-pointers=yes" ]Hans Wennborg . unresolved
Maybe we should pass this also on Windows?
Related details
Attention is currently required from:
- Dominik Röttsches
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
6:58 AM (10 hours ago) 6:58 AM
to Chromium LUCI CQ, Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Hans Wennborg and Łukasz Anforowicz
Dominik Röttsches added 1 comment![]( "Open in Gerrit")
File build/config/compiler/BUILD.gn
Maybe we should pass this also on Windows?
Dominik Röttsches
Updated the change, setting `rustflags` irrespective of the platform.
Related details
Attention is currently required from:
- Hans Wennborg
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Röttsches (Gerrit)
8:56 AM (8 hours ago) 8:56 AM
to Chromium LUCI CQ, Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Attention needed from Hans Wennborg and Łukasz Anforowicz
Dominik Röttsches voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Hans Wennborg
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
10:12 AM (7 hours ago) 10:12 AM
to Dominik Röttsches, Chromium LUCI CQ, Hans Wennborg, chromium...@chromium.org
Attention needed from Hans Wennborg
Łukasz Anforowicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Anforowicz
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Łukasz Anforowicz . resolved
Thanks for looking into this - LGTM! (not triggering auto-submit in case @hans wants to take another look)
Related details
Attention is currently required from:
- Hans Wennborg
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hans Wennborg (Gerrit)
3:33 PM (1 hour ago) 3:33 PM
to Dominik Röttsches, Hans Wennborg, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Dominik Röttsches
Hans Wennborg voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hans Wennborg
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dominik Röttsches
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:38 PM (1 hour ago) 3:38 PM
to Dominik Röttsches, Hans Wennborg, Łukasz Anforowicz, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Synchronize C++/Rust frame pointer enabling in compiler settings
Ensure that rustc produces frame pointers when the gn setting
enable_frame_pointers is on. This ensures that both compilers for C++
and Rust generate frame pointers and that the stack can be unwound. This
avoids losing cohesion in stack traces in profiling, in particular when
profiling code that crosses the C++/Rust language boundary.
Tested locally: with this change I get stack traces and unwound
stacks in profiling when recording with `perf record -g ...`.
Fixed: 476343965
Change-Id: I69353eeccccc202881a08ba43fff4f9b2c3888bb
Auto-Submit: Dominik Röttsches <dr...@chromium.org>
Commit-Queue: Hans Wennborg <ha...@chromium.org>
Reviewed-by: Hans Wennborg <ha...@chromium.org>
Reviewed-by: Łukasz Anforowicz <luk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637878}
Files:
- M build/config/compiler/BUILD.gn
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hans Wennborg, +1 by Łukasz Anforowicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages