[Omnibox Next] Correct tab order in Variant 1 [chromium/src : main]

0 views
Skip to first unread message

Teresa Mao (Gerrit)

unread,
Jan 9, 2026, 1:59:43 PM (yesterday) Jan 9
to Wenhu Cheng, Dhruv Kathpalia, Paul Adedeji, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Ananya Seelam and Wenhu Cheng

Teresa Mao added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Teresa Mao . unresolved

Hi Wenhu, could you please verify the tab order of variant 2 and 3 as well? Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Ananya Seelam
  • Wenhu Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0bf31025dca3618a3263d738d3d811ea6a0f0254
Gerrit-Change-Number: 7418660
Gerrit-PatchSet: 2
Gerrit-Owner: Wenhu Cheng <wen...@google.com>
Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
Gerrit-CC: Paul Adedeji <paula...@google.com>
Gerrit-Attention: Ananya Seelam <ananya...@google.com>
Gerrit-Attention: Wenhu Cheng <wen...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 18:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Teresa Mao (Gerrit)

unread,
Jan 9, 2026, 2:02:50 PM (yesterday) Jan 9
to Wenhu Cheng, Dhruv Kathpalia, Paul Adedeji, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Ananya Seelam and Wenhu Cheng

Teresa Mao added 1 comment

Commit Message
Line 9, Patchset 2 (Latest):Correct the tab order in Variant 1 when typed or context added
After fix: https://screencast.googleplex.com/cast/NjIxNDI5MzE3ODU0ODIyNHxlNTA1ODczMi1hNQ
Teresa Mao . unresolved

nit:

```suggestion
Correct the tab order in Variant 1 when typed or context added.

After fix: https://screencast.googleplex.com/cast/NjIxNDI5MzE3ODU0ODIyNHxlNTA1ODczMi1hNQ
```

Gerrit-Comment-Date: Fri, 09 Jan 2026 19:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Wenhu Cheng (Gerrit)

unread,
Jan 9, 2026, 7:09:57 PM (21 hours ago) Jan 9
to Dhruv Kathpalia, Paul Adedeji, Teresa Mao, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Ananya Seelam and Teresa Mao

Wenhu Cheng added 2 comments

Patchset-level comments
File-level comment, Patchset 2:
Teresa Mao . resolved

Hi Wenhu, could you please verify the tab order of variant 2 and 3 as well? Thanks.

Wenhu Cheng

Hi Teresa, updated in comment

Commit Message
Line 9, Patchset 2:Correct the tab order in Variant 1 when typed or context added
After fix: https://screencast.googleplex.com/cast/NjIxNDI5MzE3ODU0ODIyNHxlNTA1ODczMi1hNQ
Teresa Mao . resolved

nit:

```suggestion
Correct the tab order in Variant 1 when typed or context added.

After fix: https://screencast.googleplex.com/cast/NjIxNDI5MzE3ODU0ODIyNHxlNTA1ODczMi1hNQ
```

Wenhu Cheng

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Ananya Seelam
  • Teresa Mao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bf31025dca3618a3263d738d3d811ea6a0f0254
    Gerrit-Change-Number: 7418660
    Gerrit-PatchSet: 4
    Gerrit-Owner: Wenhu Cheng <wen...@google.com>
    Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Paul Adedeji <paula...@google.com>
    Gerrit-Attention: Ananya Seelam <ananya...@google.com>
    Gerrit-Attention: Teresa Mao <te...@chromium.org>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 00:09:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Teresa Mao <te...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Orin Jaworski (Gerrit)

    unread,
    Jan 9, 2026, 8:11:52 PM (20 hours ago) Jan 9
    to Wenhu Cheng, Dhruv Kathpalia, Paul Adedeji, Teresa Mao, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
    Attention needed from Ananya Seelam, Teresa Mao and Wenhu Cheng

    Orin Jaworski voted and added 2 comments

    Votes added by Orin Jaworski

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Orin Jaworski . resolved

    LGTM

    File ui/webui/resources/cr_components/composebox/contextual_entrypoint_and_carousel.html.ts
    Line 113, Patchset 4 (Latest): ${this.submitButtonShown && this.searchboxLayoutMode === 'Compact'?
    Orin Jaworski . unresolved

    nit: whitespace for `?`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ananya Seelam
    • Teresa Mao
    • Wenhu Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bf31025dca3618a3263d738d3d811ea6a0f0254
    Gerrit-Change-Number: 7418660
    Gerrit-PatchSet: 4
    Gerrit-Owner: Wenhu Cheng <wen...@google.com>
    Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
    Gerrit-Reviewer: Orin Jaworski <or...@chromium.org>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Paul Adedeji <paula...@google.com>
    Gerrit-Attention: Ananya Seelam <ananya...@google.com>
    Gerrit-Attention: Teresa Mao <te...@chromium.org>
    Gerrit-Attention: Wenhu Cheng <wen...@google.com>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 01:11:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Teresa Mao (Gerrit)

    unread,
    Jan 9, 2026, 8:40:49 PM (20 hours ago) Jan 9
    to Wenhu Cheng, Orin Jaworski, Dhruv Kathpalia, Paul Adedeji, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
    Attention needed from Ananya Seelam, Orin Jaworski and Wenhu Cheng

    Teresa Mao voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ananya Seelam
    • Orin Jaworski
    • Wenhu Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bf31025dca3618a3263d738d3d811ea6a0f0254
    Gerrit-Change-Number: 7418660
    Gerrit-PatchSet: 5
    Gerrit-Owner: Wenhu Cheng <wen...@google.com>
    Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
    Gerrit-Reviewer: Orin Jaworski <or...@chromium.org>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Paul Adedeji <paula...@google.com>
    Gerrit-Attention: Ananya Seelam <ananya...@google.com>
    Gerrit-Attention: Orin Jaworski <or...@chromium.org>
    Gerrit-Attention: Wenhu Cheng <wen...@google.com>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 01:40:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Wenhu Cheng (Gerrit)

    unread,
    Jan 9, 2026, 9:48:08 PM (18 hours ago) Jan 9
    to Teresa Mao, Orin Jaworski, Dhruv Kathpalia, Paul Adedeji, Ananya Seelam, chromium...@chromium.org, oshima...@chromium.org
    Attention needed from Ananya Seelam, Orin Jaworski and Teresa Mao

    Wenhu Cheng added 1 comment

    File ui/webui/resources/cr_components/composebox/contextual_entrypoint_and_carousel.html.ts
    Line 113, Patchset 4: ${this.submitButtonShown && this.searchboxLayoutMode === 'Compact'?
    Orin Jaworski . resolved

    nit: whitespace for `?`

    Wenhu Cheng

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ananya Seelam
    • Orin Jaworski
    • Teresa Mao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bf31025dca3618a3263d738d3d811ea6a0f0254
    Gerrit-Change-Number: 7418660
    Gerrit-PatchSet: 8
    Gerrit-Owner: Wenhu Cheng <wen...@google.com>
    Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
    Gerrit-Reviewer: Orin Jaworski <or...@chromium.org>
    Gerrit-Reviewer: Teresa Mao <te...@chromium.org>
    Gerrit-CC: Dhruv Kathpalia <dhruvka...@google.com>
    Gerrit-CC: Paul Adedeji <paula...@google.com>
    Gerrit-Attention: Ananya Seelam <ananya...@google.com>
    Gerrit-Attention: Teresa Mao <te...@chromium.org>
    Gerrit-Attention: Orin Jaworski <or...@chromium.org>
    Gerrit-Comment-Date: Sat, 10 Jan 2026 02:47:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Orin Jaworski <or...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages