[Contextual tasks] Do not reanimate the side panel if already open [chromium/src : main]

0 views

Skip to first unread message

Yuheng Huang (Gerrit)

unread,

Jan 16, 2026, 6:25:47 PM (18 hours ago) Jan 16

to Shakti Sahu, Matthew Jones, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang

Attention needed from Shakti Sahu

Yuheng Huang voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Shakti Sahu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shakti Sahu (Gerrit)

unread,

Jan 16, 2026, 11:50:07 PM (13 hours ago) Jan 16

to Yuheng Huang, Matthew Jones, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang

Attention needed from Yuheng Huang

Shakti Sahu voted and added 1 comment

Votes added by Shakti Sahu

Code-Review

1 comment

File chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc

Line 281, Patchset 2 (Latest): if (!IsSidePanelOpenForContextualTask()) {

Shakti Sahu . unresolved

During animations, this method returns wrong value.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/side_panel/side_panel_ui.h;drc=b85ce935824810dbc34ccc72de0cb398d8cc9a29;l=81
But I guess that's okay since we are trying to show here?