[PWA_Install_Dialog]Parameterize Shortcut & Status Bar Tests with kWebAppInstallDialog [chromium/src : main]

0 views
Skip to first unread message

Luke Deng (Gerrit)

unread,
Jul 8, 2026, 6:15:32 PM (6 hours ago) Jul 8
to Dibyajyoti Pal, Adriana Ixba, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Adriana Ixba and Dibyajyoti Pal

Luke Deng voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adriana Ixba
  • Dibyajyoti Pal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
Gerrit-Change-Number: 8061657
Gerrit-PatchSet: 3
Gerrit-Owner: Luke Deng <luke...@google.com>
Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-Reviewer: Luke Deng <luke...@google.com>
Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-Attention: Adriana Ixba <ai...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 22:15:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adriana Ixba (Gerrit)

unread,
Jul 8, 2026, 6:31:04 PM (6 hours ago) Jul 8
to Luke Deng, Dibyajyoti Pal, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Dibyajyoti Pal and Luke Deng

Adriana Ixba voted and added 1 comment

Votes added by Adriana Ixba

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Adriana Ixba . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Dibyajyoti Pal
  • Luke Deng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
    Gerrit-Change-Number: 8061657
    Gerrit-PatchSet: 3
    Gerrit-Owner: Luke Deng <luke...@google.com>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-Attention: Luke Deng <luke...@google.com>
    Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 22:30:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dibyajyoti Pal (Gerrit)

    unread,
    Jul 8, 2026, 6:34:08 PM (6 hours ago) Jul 8
    to Luke Deng, Adriana Ixba, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
    Attention needed from Luke Deng

    Dibyajyoti Pal voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Luke Deng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
    Gerrit-Change-Number: 8061657
    Gerrit-PatchSet: 3
    Gerrit-Owner: Luke Deng <luke...@google.com>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-Attention: Luke Deng <luke...@google.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 22:33:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Luke Deng (Gerrit)

    unread,
    Jul 8, 2026, 7:38:31 PM (5 hours ago) Jul 8
    to Adriana Ixba, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

    Luke Deng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
    Gerrit-Change-Number: 8061657
    Gerrit-PatchSet: 3
    Gerrit-Owner: Luke Deng <luke...@google.com>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 23:38:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 8, 2026, 8:33:23 PM (4 hours ago) Jul 8
    to Luke Deng, Dibyajyoti Pal, Adriana Ixba, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [PWA_Install_Dialog]Parameterize Shortcut & Status Bar Tests with kWebAppInstallDialog

    Update `CreateShortcutBrowserTest` and `WebAppStatusBarTest` to run with
    both the `kWebAppInstallDialog` feature enabled and disabled.

    Previously, these test suites explicitly disabled the feature using
    `base::test::ScopedFeatureList`. By migrating them to
    `base::test::WithFeatureOverride` and changing the test macros to
    `IN_PROC_BROWSER_TEST_P`, we ensure test coverage for both states of the
    feature.
    Bug: 532155528
    Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
    Reviewed-by: Dibyajyoti Pal <diby...@chromium.org>
    Commit-Queue: Luke Deng <luke...@google.com>
    Reviewed-by: Adriana Ixba <ai...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1659168}
    Files:
    • M chrome/browser/ui/web_applications/create_shortcut_browsertest.cc
    • M chrome/browser/ui/web_applications/status_bar_browsertest.cc
    Change size: M
    Delta: 2 files changed, 32 insertions(+), 35 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Adriana Ixba, +1 by Dibyajyoti Pal
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I461f5a863c2757b70c270d66db104f04a9576742
    Gerrit-Change-Number: 8061657
    Gerrit-PatchSet: 4
    Gerrit-Owner: Luke Deng <luke...@google.com>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages