[Contextual Tasks] Create WebUI bindings when IsContextualTasksUIEnabled [chromium/src : main]
Duncan Mercer (Gerrit)
Duncan Mercer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: aj...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): aj...@chromium.org
Reviewer source(s):
aj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Alex Gough
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Gough (Gerrit)
Alex Gough voted and added 1 comment![]( "Open in Gerrit")
- Duncan Mercer
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Duncan Mercer (Gerrit)
Duncan Mercer voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
[Contextual Tasks] Create WebUI bindings when IsContextualTasksUIEnabled
Switch the CHECK in for the WebUI binding to check
IsContextualTasksUIEnabled() instead of kContextualTasks. A previous CL
added a new flag to allow users to get to the Contextual Tasks side
panel with the kContextualTasks flag, which causes a render crash since
the WebUI bindings are created.
Context: crrev.com/c/8086133
- M chrome/browser/chrome_browser_interface_binders_webui_parts_desktop.cc
Code-Review: +1 by Alex Gough
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |