Scale pixel test screenshot timeout on ASAN [chromium/src : main]

0 views
Skip to first unread message

Brian Sheedy (Gerrit)

unread,
5:01 PM (4 hours ago) 5:01 PM
to Jonathan Lee, Yuly Novikov, chromium...@chromium.org
Attention needed from Jonathan Lee

Brian Sheedy voted and added 1 comment

Votes added by Brian Sheedy

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brian Sheedy . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7ce0c090d00c4967b3207545f69d6a27a954890
Gerrit-Change-Number: 8131473
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 21:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Lee (Gerrit)

unread,
5:04 PM (4 hours ago) 5:04 PM
to Brian Sheedy, Chromium LUCI CQ, Yuly Novikov, chromium...@chromium.org
Attention needed from Brian Sheedy

Jonathan Lee voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Sheedy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia7ce0c090d00c4967b3207545f69d6a27a954890
    Gerrit-Change-Number: 8131473
    Gerrit-PatchSet: 1
    Gerrit-Owner: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
    Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 21:04:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Brian Sheedy (Gerrit)

    unread,
    6:51 PM (2 hours ago) 6:51 PM
    to Jonathan Lee, Chromium LUCI CQ, Yuly Novikov, chromium...@chromium.org
    Attention needed from Jonathan Lee

    Brian Sheedy voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jonathan Lee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia7ce0c090d00c4967b3207545f69d6a27a954890
    Gerrit-Change-Number: 8131473
    Gerrit-PatchSet: 1
    Gerrit-Owner: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-CC: Yuly Novikov <ynov...@chromium.org>
    Gerrit-Attention: Jonathan Lee <jonath...@google.com>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 22:51:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Brian Sheedy (Gerrit)

    unread,
    7:23 PM (2 hours ago) 7:23 PM
    to Jonathan Lee, Chromium LUCI CQ, Yuly Novikov, chromium...@chromium.org
    Gerrit-Comment-Date: Wed, 22 Jul 2026 23:23:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    8:13 PM (1 hour ago) 8:13 PM
    to Brian Sheedy, Jonathan Lee, Yuly Novikov, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Scale pixel test screenshot timeout on ASAN

    Adds a timeout multiplier when taking a screenshot in pixel tests with
    ASAN enabled. There is already a multiplier for slow tests, and testing
    via the UTR indicates that scaling the timeout helps some tests pass
    with ASAN.
    Bug: 536977902
    Change-Id: Ia7ce0c090d00c4967b3207545f69d6a27a954890
    Auto-Submit: Brian Sheedy <bsh...@chromium.org>
    Commit-Queue: Brian Sheedy <bsh...@chromium.org>
    Reviewed-by: Jonathan Lee <jonath...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1666729}
    Files:
    • M content/test/gpu/gpu_tests/pixel_integration_test.py
    Change size: XS
    Delta: 1 file changed, 4 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jonathan Lee
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia7ce0c090d00c4967b3207545f69d6a27a954890
    Gerrit-Change-Number: 8131473
    Gerrit-PatchSet: 2
    Gerrit-Owner: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages