Remove PS owners from cookie files [chromium/src : main]

0 views
Skip to first unread message

Fiona Macintosh (Gerrit)

unread,
5:53 AM (6 hours ago) 5:53 AM
to Christian Dullweber, chromium...@chromium.org, Permissions Reviews, dullweb...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, omnibox-...@chromium.org
Attention needed from Christian Dullweber

Fiona Macintosh voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christian Dullweber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
Gerrit-Change-Number: 8061658
Gerrit-PatchSet: 2
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 09:52:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Dullweber (Gerrit)

unread,
8:20 AM (3 hours ago) 8:20 AM
to Fiona Macintosh, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, dullweb...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, omnibox-...@chromium.org
Attention needed from Fiona Macintosh

Christian Dullweber added 1 comment

File chrome/browser/ui/views/location_bar/cookie_controls/OWNERS
Line 1, Patchset 2 (Parent):file://components/privacy_sandbox/OWNERS
Christian Dullweber . unresolved

Could you add chrome/browser/ui/cookie_controls/OWNERS here?

Open in Gerrit

Related details

Attention is currently required from:
  • Fiona Macintosh
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
    Gerrit-Change-Number: 8061658
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 12:20:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fiona Macintosh (Gerrit)

    unread,
    9:20 AM (2 hours ago) 9:20 AM
    to Chromium LUCI CQ, Christian Dullweber, chromium...@chromium.org, Permissions Reviews, dullweb...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, omnibox-...@chromium.org
    Attention needed from Christian Dullweber

    Fiona Macintosh voted and added 1 comment

    Votes added by Fiona Macintosh

    Auto-Submit+1

    1 comment

    File chrome/browser/ui/views/location_bar/cookie_controls/OWNERS
    Line 1, Patchset 2 (Parent):file://components/privacy_sandbox/OWNERS
    Christian Dullweber . resolved

    Could you add chrome/browser/ui/cookie_controls/OWNERS here?

    Fiona Macintosh

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christian Dullweber
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
      Gerrit-Change-Number: 8061658
      Gerrit-PatchSet: 3
      Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
      Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 13:20:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Christian Dullweber <dull...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Christian Dullweber (Gerrit)

      unread,
      10:43 AM (1 hour ago) 10:43 AM
      to Fiona Macintosh, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, dullweb...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, omnibox-...@chromium.org
      Attention needed from Fiona Macintosh

      Christian Dullweber voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fiona Macintosh
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
      Gerrit-Change-Number: 8061658
      Gerrit-PatchSet: 3
      Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
      Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 14:42:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      10:54 AM (1 hour ago) 10:54 AM
      to Fiona Macintosh, Christian Dullweber, chromium...@chromium.org, Permissions Reviews, dullweb...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, omnibox-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Remove PS owners from cookie files
      Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
      Auto-Submit: Fiona Macintosh <fmaci...@google.com>
      Reviewed-by: Christian Dullweber <dull...@chromium.org>
      Commit-Queue: Christian Dullweber <dull...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1659547}
      Files:
      • M chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/OWNERS
      • M chrome/browser/ui/cookie_controls/OWNERS
      • M chrome/browser/ui/views/location_bar/cookie_controls/OWNERS
      • M chrome/browser/ui/views/page_info/OWNERS
      • M components/browser_ui/site_settings/OWNERS
      • M components/content_settings/OWNERS
      • M components/page_info/android/OWNERS
      • M components/privacy_sandbox/OWNERS
      Change size: S
      Delta: 8 files changed, 2 insertions(+), 20 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Christian Dullweber
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec26976095eb20f513e85d617cb99685e09b1a45
      Gerrit-Change-Number: 8061658
      Gerrit-PatchSet: 4
      Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages